View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|13982||Bug reports||[All Projects] Survey design||public||2018-08-20 21:08||2018-10-26 23:47|
|Target Version||Fixed in Version||3.15.x|
|Summary||13982: Uploading survey resources (via kcfinder) does not work with CRedisCache|
kcfinder does not work when using CRedisCache because the code in bootstrap.php only conditionally checks for the use of DBHttpSession instead of generally supporting CHttpSession derived classes such as CCacheHttpSession. Reference:
Upon failure a popup with the message "You don't have permissions to browse server." is shown when navigating to the "Resources" section of survey in survey settings.
I was able to change the code in checkLSSession (in bootstrap.php) to load configs, call Yii::createAppliation, and call Yii::app()->session->open(). Note the changed code does not create new LSSessionSaveHandler. With this change, I was able to use kcfinder with CRedisCache. I think that with my changes, the LSSessionSaveHandler is redundant because the solution should work with any CHttpSession derived class which returns true from 'getUseCustomStorage'. kcfinder requires a call to 'session_set_save_handler' and CHttpSession makes this call when 'getUseCustomStorage' returns true:
So, I just want to make sure that my approach is sane before I clean up the code and submit a PR which would eliminate some of the code in bootstrap.php. Idea taken from https://www.yiiframework.com/wiki/421/syncing-sessions-between-yii-and-kcfinder#c19588
|Steps To Reproduce|
My relevant config sections:
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||3.13.2+180709|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||Postgres|
|Operating System (Server)||linux|
|Webserver software & version||FPM|
I created a PR so that ideas and code can be reviewed: https://github.com/LimeSurvey/LimeSurvey/pull/1112
I also confirmed that the solution works with DBHttpSession.
CRedisCache is not supported by LimeSurvey. I don't think we will put any effort in it for now.
Thanks Louis. The solution in the PR works with CRedisCache, existing DBHttpSession, and should work with any CHttpSession derived class. Is there any reason that the more general solution should not be preferred? Maybe there is a different preferred strategy?
By the way, I have CRedisCache working fine for other aspects of sessioning. It's only the kcfinder integration that I am currently having issues. The PR fixes the issue but I was hoping to get an expert's opinion on the strategy.
I've seen your PR. We'll merge it after a review and some testing.
@LouisGac : if Yii1 accept redis cache : LS can accept Redis cache.
I think the 2 PR are really great and can be merged https://github.com/LimeSurvey/LimeSurvey/pull/1111 + https://github.com/LimeSurvey/LimeSurvey/pull/1112
Any update on this issue? Anything I can do to help?
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27949
It's certainly possible that I'm missing something but I think there may have been a mixup. PR https://github.com/LimeSurvey/LimeSurvey/pull/1111 (fix for bug 13888) has been merged but PR https://github.com/LimeSurvey/LimeSurvey/pull/1112 which is a fix for this issue has not been merged.
I think there was some confusion on this issue because the fix to master was for a different issue (13888). Anything I can do to help with this issue? PR changes?
About confusion : it's my fault …
Ok, no problem. But should we reopen this bug then?
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28408
|2018-08-20 21:08||caseylucas||New Issue|
|2018-08-20 22:20||caseylucas||Note Added: 48832|
|2018-08-21 11:36||LouisGac||Note Added: 48837|
|2018-08-21 15:46||caseylucas||Note Added: 48842|
|2018-08-22 12:21||LouisGac||Note Added: 48848|
|2018-08-22 12:26||DenisChenu||Note Added: 48849|
|2018-09-13 17:55||caseylucas||Note Added: 49027|
||Changeset attached||=> LimeSurvey master c0ef15f5|
||Note Added: 49031|
||Assigned To||=> user70560|
||Resolution||open => fixed|
|2018-09-14 09:06||DenisChenu||Changeset removed||LimeSurvey master c0ef15f5 =>|
|2018-09-14 17:12||caseylucas||Note Added: 49046|
|2018-10-03 18:13||caseylucas||Note Added: 49226|
|2018-10-04 09:54||DenisChenu||Note Added: 49227|
|2018-10-04 16:22||caseylucas||Note Added: 49241|
|2018-10-16 17:27||DenisChenu||Assigned To||DenisChenu =>|
|2018-10-16 17:28||DenisChenu||Assigned To||=> DenisChenu|
|2018-10-16 17:28||DenisChenu||Status||new => assigned|
|2018-10-16 17:28||DenisChenu||Resolution||fixed => open|
|2018-10-26 18:27||DenisChenu||Changeset attached||=> LimeSurvey master 378db43d|
|2018-10-26 18:27||DenisChenu||Note Added: 49455|
|2018-10-26 18:27||DenisChenu||Resolution||open => fixed|
|2018-10-26 23:46||DenisChenu||Status||assigned => resolved|
|2018-10-26 23:46||DenisChenu||Fixed in Version||=> 3.15.x|
|2018-10-26 23:47||caseylucas||Note Added: 49456|