View Issue Details

IDProjectCategoryView StatusLast Update
13908Bug reports[All Projects] Survey takingpublic2018-08-28 11:51
ReporterDenisChenuAssigned Tomarkusfluer 
PrioritynoneSeverityminor 
Status assignedResolutionopen 
Product Version3.13.x 
Target VersionFixed in Version 
Summary13908: Token form , home page (and some other) shown javascript issue
Description

Since https://github.com/LimeSurvey/LimeSurvey/commit/194ef1664dfba716801a170543ee05594849b886 : a lot of page have uneeded EM javascript.

Steps To Reproduce

Quit browser (or open a new private window)
Go to home page

If you have a current survey open and reopen home page : it shown EM from current survey …

Additional Information

get the current LimeExpressionManager::singleton(); when not initialized without controlling we have

  • Same survey
  • Same language
  • We need it
    Seems really a bad idea …
TagsNo tags attached.
Complete LimeSurvey version number (& build)3.13.2 github
I will donate to the project if issue is resolvedNo
Browsernot relevant (FF and chrome here)
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2018-07-25 16:15

developer  

LouisGac

LouisGac

2018-07-25 16:20

manager   ~48570

it should not use the same layout....

DenisChenu

DenisChenu

2018-07-26 01:08

developer   ~48576

No,

It's not fix the issue … it's just hide it …
The issue is forcing EM even if not initialized … not initialized mean not started, the we are totally unsure where we are …

DenisChenu

DenisChenu

2018-07-26 13:02

developer   ~48578

In 2.73 (and previously) we test if LimeExpressionManager::getLEMsurveyId() is same than current sid.
I don't find where, but we must always test it (and reset EM) if it's the case.
https://github.com/LimeSurvey/LimeSurvey/blob/47d8381d710eaf844a739cc2daf85565823f841b/application/helpers/SurveyRuntimeHelper.php#L485

Here : https://github.com/LimeSurvey/LimeSurvey/commit/194ef1664dfba716801a170543ee05594849b886#diff-796aba4d06254b9caea9d461e4ea80c9R7252
We get the current EM even if it's not related to current survey. I'm sure at 100% user have DB issue with such situation (receive submit error)

Issue History

Date Modified Username Field Change
2018-07-25 16:15 DenisChenu New Issue
2018-07-25 16:15 DenisChenu File Added: Capture du 2018-07-25 16-07-02.png
2018-07-25 16:15 DenisChenu File Added: Capture du 2018-07-25 16-11-30.png
2018-07-25 16:15 DenisChenu File Added: Capture du 2018-07-25 16-11-56.png
2018-07-25 16:20 LouisGac Note Added: 48570
2018-07-26 01:08 DenisChenu Note Added: 48576
2018-07-26 13:02 DenisChenu Note Added: 48578
2018-08-28 11:51 LouisGac Assigned To => markusfluer
2018-08-28 11:51 LouisGac Status new => assigned