View Issue Details

IDProjectCategoryView StatusLast Update
13749Bug reports[All Projects] Theme editorpublic2018-06-15 19:48
ReporterDenisChenuAssigned To 
PrioritynoneSeverityminor 
Status newResolutionopen 
Product Version3.9.x 
Target VersionFixed in Version 
Summary13749: FTP rename default theme : send error at all survey with this template
Description

After FTP rename of default theme all survey related to this theme (opr another renamed theme) broke

Steps To Reproduce

set a default theme to extend_vanilla
set some survey to extend_vanilla
rename to my_beautifull_theme
launch a survey

Additional Information

Second pass is OK
Need to filter defaulttheme always

It's happen too without FTP, but don't find the exact way to reproduce without FTP

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.9.0 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionnot relevant
Operating System (Server)not relevant
Webserver software & versionnot relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2018-06-08 00:47

developer  

PHP notice -default template.html (23,889 bytes)
DenisChenu

DenisChenu

2018-06-08 01:08

developer   ~48027

Last edited: 2018-06-08 01:10

View 3 revisions

@LouisGac : i think fixing it at
https://github.com/LimeSurvey/LimeSurvey/blob/83e3fb711b3db89a9383cdbb73f94f9acc45dc75/application/core/LSYii_Application.php#L151
/ Always fix default theme /
$this->setConfig('defaulttheme',Template::templateNameFilter($this->getConfig('defaulttheme')));

But you totally rework templateNameFilter and fix DB inside …

Then need to fix it each time we load defaulttheme, then i update here https://github.com/LimeSurvey/LimeSurvey/blob/83e3fb711b3db89a9383cdbb73f94f9acc45dc75/application/models/TemplateConfiguration.php#L164
$oInstance = self::getInstanceFromTemplateName(Template::templateNameFilter(App()->getConfig('defaulttheme')));

But same issue

DenisChenu

DenisChenu

2018-06-09 17:20

developer   ~48035

And currently the name of template is filtered each time Survey is loaded, then :

At end : parent template didn't exist, then don't have option …

DenisChenu

DenisChenu

2018-06-15 19:48

developer   ~48189

Since travis has this issue since we use it …
https://travis-ci.org/LimeSurvey/LimeSurvey/jobs/392787314#L801

I really think we must have a finally fedult template option come from core, even if all are null/empty

Issue History

Date Modified Username Field Change
2018-06-08 00:47 DenisChenu New Issue
2018-06-08 00:47 DenisChenu File Added: PHP notice -default template.html
2018-06-08 00:47 DenisChenu Assigned To => DenisChenu
2018-06-08 00:47 DenisChenu Status new => assigned
2018-06-08 00:50 DenisChenu Assigned To DenisChenu =>
2018-06-08 00:50 DenisChenu Status assigned => new
2018-06-08 01:08 DenisChenu Note Added: 48027
2018-06-08 01:09 DenisChenu Note Edited: 48027 View Revisions
2018-06-08 01:10 DenisChenu Note Edited: 48027 View Revisions
2018-06-09 17:20 DenisChenu Note Added: 48035
2018-06-09 17:21 DenisChenu Product Version 3.8.x => 3.9.x
2018-06-15 19:48 DenisChenu Note Added: 48189