View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|13738||Bug reports||[All Projects] RemoteControl||public||2018-06-03 15:25||2018-06-14 20:33|
|Target Version||Fixed in Version||3.10.x|
|Summary||13738: RPC method |
|Steps To Reproduce|
in latest version, an extra validation was created when adding a given response... This method - in case the survey has a
A current call to
OfflineSurveys, due to lack of an RPC
Otherwise, is it also possible to add a method to enable/disable this validation on adding a given response? It could make perfect sense to enable it by default on web responses, there is no backward compatibility issues here, but it completely breaks how OfflineSurveys submit responses to LimeSurvey server.
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||3.8.1+180524|
|I will donate to the project if issue is resolved||No|
|Browser||N/A - REST Client|
|Database & DB-Version||MySQL 5|
|Server OS (if known)||Ubuntu 14 TLS|
|Webserver software & version (if known)||Apache 2|
|PHP Version||PHP Version 7.0.30|
file_upload_response.html (32,200 bytes)
Hej Olle, this is related to the remote control fix you already applied recently. There is still another issue, see details above.
Can we add (validateFiles = TRUE) to RPC method add_response that we can set to false to maintain backward compatibility
Who ever implemented this feature in the first place should be responsible in fixing it. Did you ask the person I linked on github?
@aaskoura Maybe you should open a separate ticket for that issue?
@olle, which exact commit do you refer to? Who has adjusted that function recently without looking at backwards compatibility?
@Mazi, I pinged you in this commit: https://github.com/LimeSurvey/LimeSurvey/commit/a6b9fe0542699faa29ca93bb4007e1db172cb6f2
You should get in touch with the implementor.
The issue is here : https://github.com/LimeSurvey/LimeSurvey/commit/66c1871d981128178f8cebe9ff91ff7bfb77d024 :)
pardo-bsso seems to be not available. So who wants to repair his bugs...?
@olle: You already fixed a related issue, can you give it a try?
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27365
@Mazi Pushed a fix. Feel free to test, but don't git pull into a production environment (some things are broken right now).
Does the fix only look that complex (many adjusted files)? Is it sufficient to only adjust the remotecontrol_handle.php and export_helper.php files for testing?
Whoops, the fix included some composer files. I did not expect them to be included, that was a mistake by me. Only the two first files are the actual fix.
It looks like after the recent fix the API returns invalid or unexpected token. We'll analyse the issue and post comments here.
LimeSurvey: master 8dd05df8
2018-06-11 14:35:32Details Diff
|Fixed issue 13738: RPC method is not working.||
|mod - application/helpers/export_helper.php||Diff File|
|mod - application/helpers/remotecontrol/remotecontrol_handle.php||Diff File|
|mod - third_party/composer/autoload_classmap.php||Diff File|
|mod - third_party/composer/autoload_namespaces.php||Diff File|
|mod - third_party/composer/autoload_psr4.php||Diff File|
|mod - third_party/composer/autoload_static.php||Diff File|
|2018-06-03 15:25||aaskoura||New Issue|
|2018-06-03 15:25||aaskoura||File Added: file_upload_response.html|
|2018-06-03 15:42||Mazi||Assigned To||=> ollehar|
|2018-06-03 15:42||Mazi||Status||new => assigned|
|2018-06-03 15:43||Mazi||Note Added: 47953|
|2018-06-04 10:37||aaskoura||Note Added: 47954|
|2018-06-04 10:46||ollehar||Note Added: 47955|
|2018-06-04 10:46||ollehar||Note Added: 47956|
|2018-06-04 10:55||Mazi||Note Added: 47957|
|2018-06-04 13:39||ollehar||Note Added: 47961|
|2018-06-05 08:00||DenisChenu||Note Added: 47980|
|2018-06-05 12:20||ollehar||Note Added: 47986|
|2018-06-07 23:30||Mazi||Note Added: 48023|
|2018-06-11 14:36||ollehar||Changeset attached||=> LimeSurvey master 8dd05df8|
|2018-06-11 14:36||ollehar||Note Added: 48044|
|2018-06-11 14:36||ollehar||Resolution||open => fixed|
|2018-06-11 14:36||ollehar||Note Added: 48045|
|2018-06-11 14:36||ollehar||Status||assigned => feedback|
|2018-06-11 16:11||Mazi||Note Added: 48048|
|2018-06-11 16:23||ollehar||Note Added: 48049|
|2018-06-11 16:25||ollehar||Status||feedback => resolved|
|2018-06-11 16:32||markusfluer||Status||resolved => closed|
|2018-06-11 16:32||markusfluer||Fixed in Version||=> 3.10.x|
|2018-06-14 20:33||Mazi||Status||closed => feedback|
|2018-06-14 20:33||Mazi||Resolution||fixed => reopened|
|2018-06-14 20:33||Mazi||Note Added: 48116|