View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
13719Bug reportsTheme editorpublic2018-05-26 17:492018-07-09 14:10
ReporterDenisChenu Assigned Tomarkusfluer 
PrioritynoneSeverityminor 
Status closedResolutionwon't fix 
Product Version3.8.x 
Summary13719: Harder for template manager to replace core javascript function
Description

When done the package limesurvey + template-default : it was done for Template manager to easily update and use own function,
Now it's more hard then 3.0alpha

Steps To Reproduce

https://github.com/LimeSurvey/LimeSurvey/commit/7306666023f4003dff7ab7ee8ee1fdb3aa82eded#commitcomment-29140288

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)3.8.1 github and before
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

markusfluer

markusfluer

2018-07-09 14:10

administrator   ~48477

The core javascript function are the minimal functionality used with our shipped themes.
It is possible to copy or extend the theme and then replace all functionality by a more open, respectively more fitting way.
We have discussed this and won't change the default templates back.
This wrapping in global objects speeds up JavaScript execution by ~10% and is necessary to prevent double or triple loading in ajax mode.

Issue History

Date Modified Username Field Change
2018-05-26 17:49 DenisChenu New Issue
2018-07-09 14:10 markusfluer Note Added: 48477
2018-07-09 14:10 markusfluer Assigned To => markusfluer
2018-07-09 14:10 markusfluer Status new => closed
2018-07-09 14:10 markusfluer Resolution open => won't fix