View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
13676 | Bug reports | Theme editor | public | 2018-05-16 02:34 | 2018-05-25 11:30 |
Reporter | duvemyster | Assigned To | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.6.x | ||||
Summary | 13676: Saving {{ : }} in a twig file crashes Theme Editor... | ||||
Description | Yes, the colon is a syntax error. But in Version 3.7.2+180508, adding this to 1 twig file this results in the 'Theme editor' link for all themes leading to a browser message that the server is redirecting the request for this address in a way that will never complete. Subsequent use of the browser back button leads to the following appropriate limesurvey message: Arguments must be separated by a comma. Unexpected token "punctuation" of value ":" ("punctuation" expected with value ","). The behavior at demo.limesurvey.org (3.6.3) is a little different/better. Entering something like {{Test:Test}} or {{TOKEN:ATTRIBUTE_1}} there (yes, neither one something that you'd want to enter anyway) leads to inability to re-access the theme editor for that particular extended theme to correct the error. | ||||
Steps To Reproduce | Extend a theme, add {{Test:Test}}, then "Copy to local template and save changes". | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 3.7.2+180508 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Firefox Qantum 60.0 (64-bit) | ||||
Database type & version | Maridb with Mysql client api 5.5.58 | ||||
Server OS (if known) | Linux | ||||
Webserver software & version (if known) | Apache 2.0 | ||||
PHP Version | PHP Version 5.6.30-0+deb8u1 | ||||
related to | 13532 | closed | Invalid function in template : Unable to delete or fix it |
yes you're right, it should only show an error message in the preview. |
|
Resolved? |
|
In 3.7.2+180508, 'Copy to local template and save changes' on nav_bar.twig actually changed themes/survey/vanilla/views/subviews/header/nav_bar.twig' rather than saving it to the new theme. That is also occurring in Version 3.7.3+180516. |
|
(That may be why all 'Theme editor' links were crashing in 3.7.2+180508, as nav_bar.twig was the file where I had added the {{ : }}. ) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27197 |
|
Version 3.8.1+180524 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2018-05-16 02:35 | duvemyster | New Issue | |
2018-05-16 10:36 | ollehar | Assigned To | => LouisGac |
2018-05-16 10:36 | ollehar | Status | new => assigned |
2018-05-16 11:20 |
|
Note Added: 47600 | |
2018-05-16 12:12 | ollehar | Note Added: 47613 | |
2018-05-16 13:20 |
|
Relationship added | related to 13532 |
2018-05-16 18:10 | duvemyster | Note Added: 47655 | |
2018-05-16 18:32 | duvemyster | Note Added: 47656 | |
2018-05-22 16:55 |
|
Sticky Issue | No => Yes |
2018-05-22 17:15 |
|
Changeset attached | => LimeSurvey master afb7e325 |
2018-05-22 17:15 |
|
Note Added: 47709 | |
2018-05-22 17:15 |
|
Resolution | open => fixed |
2018-05-22 17:16 |
|
Sticky Issue | Yes => No |
2018-05-22 17:35 |
|
Status | assigned => resolved |
2018-05-25 11:30 | c_schmitz | Note Added: 47822 | |
2018-05-25 11:30 | c_schmitz | Status | resolved => closed |