View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
13669 | Bug reports | Theme editor | public | 2018-05-12 19:16 | 2018-09-03 17:14 |
Reporter | Tuvlan | Assigned To | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.7.x | ||||
Summary | 13669: Stylesheet missing in themes/survey fruity | ||||
Description | If you create a child-theme of fruity, by default this theme has a import of the css/ajaxify.css file which doesn't exist in the css base directory of fruity .
In the vanilla css directory this file instead exists. We copied the ajaxify.css from vanilla to fruity and the 404 file not found error is gone.
| ||||
Tags | css, theme | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 3.7.2+180508 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MySQL | ||||
Server OS (if known) | Debian 3.16.56-1 (2018-04-28) x86_64 | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | 7.0.30 | ||||
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27758 |
|
also this fix: |
|
First commit is the real fix. But it will be applied only to new installation, or if you reset your themes after update (but then you'll lose your specific configuration for options) With the second commit, not existing files are not registered anymore: so no more errors, even if you don't reset your themes. |
|
also, to makes things more clear, to avoid those kind of mistakes in the future: https://github.com/LimeSurvey/LimeSurvey/commit/920160d02befdb00f96c24610f25cd82e33ba824 https://github.com/LimeSurvey/LimeSurvey/commit/b6c4ce0658208c697ab88da51b8dba7ed2a86995 https://github.com/LimeSurvey/LimeSurvey/commit/1b5890adbc8a82355d3f52104f69fbd003188b62 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27764 |
|
With last commit: Now, files are added to the parent theme where the file exist. So it avoid many possible issue, that's why many notes disappeared. |
|
Indeed, what was a bug before (adding a file that doesn't exist locally and that already exists in a parent theme ) become now a functionality: it give the possibility to reorder the file loading of any theme from any theme. |
|
Version 3.14.8+180829 released |
|
LimeSurvey: master 78fb5f46 2018-08-07 14:51
Details Diff |
Fixed issue 13669: Stylesheet missing in themes/survey fruity |
Affected Issues 13669 |
|
mod - themes/survey/bootswatch/config.xml | Diff File | ||
rm - themes/survey/bootswatch/css/ajaxify.css | Diff | ||
mod - themes/survey/fruity/config.xml | Diff File | ||
mod - themes/survey/vanilla/config.xml | Diff File | ||
LimeSurvey: master 61c7034a 2018-08-07 20:21
Details Diff |
Fixed issue 13669: recursive way, for easy maintenance |
Affected Issues 13669 |
|
mod - application/core/LSYii_ClientScript.php | Diff File | ||
mod - application/models/TemplateConfiguration.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-05-12 19:16 | Tuvlan | New Issue | |
2018-05-12 19:18 | Tuvlan | Tag Attached: theme | |
2018-05-12 19:18 | Tuvlan | Tag Attached: css | |
2018-05-12 19:19 | Tuvlan | Issue Monitored: Tuvlan | |
2018-05-16 11:48 |
|
Sticky Issue | No => Yes |
2018-05-16 11:48 |
|
Assigned To | => LouisGac |
2018-05-16 11:48 |
|
Status | new => confirmed |
2018-08-07 14:05 |
|
Changeset attached | => LimeSurvey master 78fb5f46 |
2018-08-07 14:05 |
|
Note Added: 48671 | |
2018-08-07 14:05 |
|
Resolution | open => fixed |
2018-08-07 14:08 |
|
Note Added: 48672 | |
2018-08-07 14:12 |
|
Note Added: 48673 | |
2018-08-07 15:20 |
|
Note Added: 48674 | |
2018-08-07 15:25 |
|
Status | confirmed => resolved |
2018-08-07 18:22 |
|
Changeset attached | => LimeSurvey master 61c7034a |
2018-08-07 18:22 |
|
Note Added: 48742 | |
2018-08-07 18:25 |
|
Note Added: 48743 | |
2018-08-07 18:28 |
|
Note Added: 48747 | |
2018-08-17 15:45 |
|
Sticky Issue | Yes => No |
2018-09-03 17:14 | c_schmitz | Note Added: 48945 | |
2018-09-03 17:14 | c_schmitz | Status | resolved => closed |
2021-08-04 13:05 | guest | Bug heat | 4 => 6 |