View Issue Details

This bug affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
13596Bug reportsTheme editorpublic2018-06-04 16:45
ReporterDenisChenu Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.6.x 
Summary13596: template assets is not resetted when updfate config
Description

When adding a file from "assets" of template, assets directory seems not updated

Steps To Reproduce

Add a file (manually) in css/ directory
Add it in config
The assets doesn't have it

Additional Information

Update custom.css fix the issue

TagsNo tags attached.
Attached Files
Bug heat2
Complete LimeSurvey version number (& build)3.6.1 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2018-06-04 15:23

developer   ~47973

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27306

LouisGac

LouisGac

2018-06-04 16:45

developer   ~47977

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27311

Related Changesets

LimeSurvey: master 0d99224f

2018-06-04 15:23:02

user70560


Committer: LouisGac Details Diff
Dev: Assets hash solution (#1057)

Fixed issue 13606 : Unable to reset manually single asset
Dev: hash function use for whole path, then global var set here
Dev: generatePath is used path by path

Fixed issue 13497 : Editor screen can be loaded without css after save
Dev: moving global reset to only this template
Dev: less time to generate assets

Fixed issue 13596: template assets is not resetted when update config
Dev: need to do it if user add a file in TemplateConfiguration_files_*
Dev: do it only for global theme (?)

Dev: move injectglobalsettings to LSYii_Application
Dev: maybe create a now function to set all config ?

Dev: Fix installmer and move all set configs part to one function

Dev: usage of DB for asset version number
Dev: hash solution for indexed pk in DB

Dev: oups on phpdoc
Dev: same other improvment than other pull request

Dev: broken update … remove test line ;)
Affected Issues
13497, 13596, 13606
mod - application/config/version.php Diff File
mod - application/controllers/admin/themeoptions.php Diff File
mod - application/controllers/admin/themes.php Diff File
mod - application/core/LSYii_Application.php Diff File
mod - application/core/LSYii_AssetManager.php Diff File
mod - application/helpers/globalsettings_helper.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
add - application/models/AssetVersion.php Diff File
mod - application/models/Template.php Diff File
mod - installer/create-database.php Diff File

LimeSurvey: master c3d25219

2018-06-04 16:45:15

user70560


Committer: LouisGac Details Diff
Fix multiple issues with theme assets (#1048)

Fixed issue 13606 : Unable to reset manually single asset
Dev: hash function use for whole path, then global var set here
Dev: generatePath is used path by path

Fixed issue 13497 : Editor screen can be loaded without css after save
Dev: moving global reset to only this template
Dev: less time to generate assets

Fixed issue 13596: template assets is not resetted when update config
Dev: need to do it if user add a file in TemplateConfiguration_files_*
Dev: do it only for global theme (?)

Dev: move injectglobalsettings to LSYii_Application
Dev: maybe create a now function to set all config ?

Dev: Fix installmer and move all set configs part to one function

Dev: Create a DB for asset version number and use it for Template

Dev: fix upgrade , remove dev test lien :/

Fixed issue : reset asset when upload or delete a template file
Dev: rename Template functions to be more clear (we don't delete really the asset directory)
Affected Issues
13497, 13596, 13606
mod - application/controllers/admin/themeoptions.php Diff File
mod - application/controllers/admin/themes.php Diff File
mod - application/core/LSYii_Application.php Diff File
mod - application/core/LSYii_AssetManager.php Diff File
mod - application/helpers/globalsettings_helper.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
add - application/models/AssetVersion.php Diff File
mod - application/models/Template.php Diff File
mod - installer/create-database.php Diff File

Issue History

Date Modified Username Field Change
2018-04-12 16:41 DenisChenu New Issue
2018-04-12 16:41 DenisChenu File Added: Capture du 2018-04-12 16-35-47.png
2018-05-16 13:10 LouisGac Assigned To => LouisGac
2018-05-16 13:10 LouisGac Status new => closed
2018-05-16 13:10 LouisGac Resolution open => no change required
2018-06-04 15:23 LouisGac Changeset attached => LimeSurvey master 0d99224f
2018-06-04 15:23 LouisGac Note Added: 47973
2018-06-04 15:23 LouisGac Resolution no change required => fixed
2018-06-04 16:45 LouisGac Changeset attached => LimeSurvey master c3d25219
2018-06-04 16:45 LouisGac Note Added: 47977