View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
13529Bug reportsExpression Managerpublic2018-03-23 18:082022-03-17 09:38
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.5.x 
Summary13529: Group title and description + Survey name and description are not updated vi EM javascript
Description

If you use Expression Manager in group description : this was not updated via javascript

Same for other text.

Steps To Reproduce

If you use , in group description You answer {count(QCODE1.NAOK,QCODE2.NAOK …)} in this group this was not updated via javascript
Import survey and template here : https://bugs.limesurvey.org/view.php?id=13527
for title

Additional Information

This is due to lack of @param integer $questionNum - the $qid of question being replaced - needed for properly alignment of question-level relevance and tailoring
in ExpressionManager::ProcessString function.

In 2.73 : we use questionNum in template_replace (for name/description etc …) in templateèreplace function https://github.com/LimeSurvey/LimeSurvey/blob/2.73/application/helpers/replacements_helper.php#L755 the title and description are updated
But not for group + groupdescription (i'm sure we have a bug report about this)

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)3.5.4 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
parent of 13533 closedDenisChenu Unable to use Expression Manager inside template 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2018-03-26 10:07

administrator   ~47211

Not really a bug, these were static by design.
DenisChenu

DenisChenu

2018-03-26 10:47

developer   ~47213

What ???

We can use dynamic EM inside title + survey description in 2.74, since 1.98. But not in 3.X ???

It's REALLY a needed feature …
c_schmitz

c_schmitz

2018-03-26 10:59

administrator   ~47215

Ah ok, I though it was not possible in 2.x either.

Thanks for fixing it.
DenisChenu

DenisChenu

2018-03-26 11:33

developer   ~47216

I'm sure there are a bug in Group description about this, but whole template goes to EM.

Currently : i use it a lot …

But : related to https://bugs.limesurvey.org/view.php?id=13533
This one seems biggest …
DenisChenu

DenisChenu

2018-03-26 17:38

developer   ~47218

https://github.com/LimeSurvey/LimeSurvey/pull/1025
c_schmitz

c_schmitz

2018-03-29 14:59

administrator   ~47283

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26903

Related Changesets

LimeSurvey: master d1a27926

2018-03-29 14:59:46

user70560


Committer: c_schmitz Details Diff 		Fixed issue 13529: Survey text are not updated via EM javascript

Fixed issue 13533 : Unable to use Expression Manager inside template		 Affected Issues
13529
mod - application/config/internal.php Diff File
mod - application/core/LSETwigViewRenderer.php Diff File
mod - application/core/LS_Twig_Extension.php Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - themes/survey/vanilla/views/subviews/header/head.twig Diff File
mod - themes/survey/vanilla/views/subviews/messages/welcome.twig Diff File
mod - themes/survey/vanilla/views/subviews/survey/group_subviews/group_desc.twig Diff File
mod - themes/survey/vanilla/views/subviews/survey/group_subviews/group_name.twig Diff File

Issue History

Date Modified Username Field Change
2018-03-23 18:08 DenisChenu New Issue
2018-03-26 10:07 c_schmitz Note Added: 47211
2018-03-26 10:47 DenisChenu Note Added: 47213
2018-03-26 10:59 c_schmitz Note Added: 47215
2018-03-26 10:59 c_schmitz Assigned To => DenisChenu
2018-03-26 10:59 c_schmitz Status new => assigned
2018-03-26 11:33 DenisChenu Note Added: 47216
2018-03-26 11:33 DenisChenu Relationship added parent of 13533
2018-03-26 17:38 DenisChenu Note Added: 47218
2018-03-29 14:59 c_schmitz Changeset attached => LimeSurvey master d1a27926
2018-03-29 14:59 c_schmitz Note Added: 47283
2018-03-29 14:59 c_schmitz Assigned To DenisChenu => c_schmitz
2018-03-29 14:59 c_schmitz Resolution open => fixed
2018-04-04 10:19 DenisChenu Assigned To c_schmitz => DenisChenu
2018-04-04 10:19 DenisChenu Status assigned => resolved
2018-04-06 11:47 markusfluer Status resolved => closed