13511: Allow new attribute in beforeQuestionRender (previously exist but undocumented) - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

4

ID	Project	Category	View Status	Date Submitted	Last Update

13511	Feature requests	Plugins	public	2018-03-21 15:35	2018-03-22 15:50

Reporter	DenisChenu	Assigned To	ollehar1
Priority	none	Severity	feature
Status	assigned	Resolution	fixed

Summary	13511: Allow new attribute in beforeQuestionRender (previously exist but undocumented)
Description	There are an undocumented beforeQuestionRender Possible output , but i think it can be very interesting. https://github.com/LimeSurvey/LimeSurvey/pull/667 This allow to add data-XXX for example
Additional Information	data attribute seems the best way for javascripting. I didn't remind if i use it on an existing plugin , but i already use a lot data-options=".json_encode($option)." on another system
Tags	No tags attached.

Bug heat	4
Story point estimate
Users affected %

DenisChenu 2018-03-22 11:18 developer ~47180	https://github.com/LimeSurvey/LimeSurvey/pull/1022

DenisChenu 2018-03-22 11:18 developer ~47181	And great for aria too

ollehar1 2018-03-22 15:50 reporter ~47190	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26836

LimeSurvey: master f1957a37 2018-03-22 16:50 ~~user70560~~ Committer: ollehar1 Details Diff	beforeQuestionRender Class + attributes (#1022) * Fixed issue 13510: beforeQuestionRender didn't include Class Dev: this one seems really needed … adding a class by plugin is needed Dev: but can not remove included function in old twig file * Dev: remove deprecated function Dev: getQuestionReplacement NEED question qanda, currently return only empty replacement Dev: didn't fix 13490 * New feature 13511: Allow new attribute in beforeQuestionRender Dev: previously exist but undocumented Dev: replace of QUESTION_ESSENTIALS		Affected Issues 13490, 13510, 13511
	mod - application/core/LS_Twig_Extension.php		Diff File
	mod - application/helpers/SurveyRuntimeHelper.php		Diff File
	mod - application/helpers/replacements_helper.php		Diff File
	mod - themes/survey/vanilla/views/subviews/survey/question_container.twig		Diff File

Date Modified	Username	Field	Change
2018-03-21 15:35	DenisChenu	New Issue
2018-03-22 10:54	DenisChenu	Summary	Undocumented beforeQuestionRender part => Allow new attribute in beforeQuestionRender (previously exist but undocumented)
2018-03-22 11:18	DenisChenu	Assigned To	=> DenisChenu
2018-03-22 11:18	DenisChenu	Status	new => assigned
2018-03-22 11:18	DenisChenu	Note Added: 47180
2018-03-22 11:18	DenisChenu	Note Added: 47181
2018-03-22 15:50	ollehar1	Changeset attached	=> LimeSurvey master f1957a37
2018-03-22 15:50	ollehar1	Note Added: 47190
2018-03-22 15:50	ollehar1	Assigned To	DenisChenu => ollehar1
2018-03-22 15:50	ollehar1	Resolution	open => fixed