13392: Token with useleft at 0 or less can take the survey - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

13392	Bug reports	Survey participants (Tokens)	public	2018-02-20 18:15	2018-02-21 16:37

Reporter	DenisChenu	Assigned To	ollehar
Priority	immediate	Severity	minor
Status	closed	Resolution	fixed
Product Version	3.4.x
Fixed in Version	3.4.x

Summary	13392: Token with useleft at 0 or less can take the survey
Description	Token use left seems not tested when starting survey or when sending email.
Steps To Reproduce	Import included lsa, sends email start survey
Additional Information	At token creation useleft must be set by default to 1
Tags	No tags attached.
Attached Files	survey_archive_useleft.lsa (4,747 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	3.4.0github
I will donate to the project if issue is resolved	No
Browser	not relevant
Database type & version	not relevant
Server OS (if known)	not relevant
Webserver software & version (if known)	not relevant
PHP Version	not relevant

User List	There are no users monitoring this issue.

ollehar 2018-02-21 10:46 administrator ~46633	Good catch.

ollehar 2018-02-21 10:53 administrator ~46634	This seem to only be a problem if token does not have a survey completed date (or no response).

ollehar 2018-02-21 11:22 administrator ~46637	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26528

DenisChenu 2018-02-21 11:30 developer ~46638	https://github.com/LimeSurvey/LimeSurvey/commit/9495d883293e8540c4f281d0738309491798366e#commitcomment-27693672 I think we can add directly default in Model : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Survey.php#L173 for example. Let me check and push if it's OK.

ollehar1 2018-02-21 13:52 reporter ~46665	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26536

LimeSurvey: master 9495d883 2018-02-21 11:21:22 ollehar Details Diff	Fixed issue 13392: Token with useleft at 0 or less can take the survey	Affected Issues 13392
	mod - application/controllers/survey/index.php	Diff File
	mod - application/models/Token.php	Diff File
LimeSurvey: master ab75b411 2018-02-21 12:55:43 ~~user70560~~ Committer: ollehar1 Details Diff	Fixed issue 13392 : new token form set useleft to 1 (#1008) * Fixed issue 13392 : new token form set useleft to 1 Dev: All form must use Models … * Dev: cleaner way, send only attributes even with existing token	Affected Issues 13392
	mod - application/controllers/admin/tokens.php	Diff File
	mod - application/models/Token.php	Diff File
	mod - application/views/admin/token/tokenform.php	Diff File

Date Modified	Username	Field	Change
2018-02-20 18:15	DenisChenu	New Issue
2018-02-20 18:15	DenisChenu	File Added: survey_archive_useleft.lsa
2018-02-21 08:43	c_schmitz	Assigned To	=> ollehar
2018-02-21 08:43	c_schmitz	Status	new => assigned
2018-02-21 08:44	c_schmitz	Priority	none => immediate
2018-02-21 10:46	ollehar	Note Added: 46633
2018-02-21 10:53	ollehar	Note Added: 46634
2018-02-21 11:22	ollehar	Changeset attached	=> LimeSurvey master 9495d883
2018-02-21 11:22	ollehar	Note Added: 46637
2018-02-21 11:22	ollehar	Resolution	open => fixed
2018-02-21 11:23	ollehar	Status	assigned => resolved
2018-02-21 11:23	ollehar	Fixed in Version	=> 3.4.x
2018-02-21 11:30	DenisChenu	Status	resolved => feedback
2018-02-21 11:30	DenisChenu	Resolution	fixed => reopened
2018-02-21 11:30	DenisChenu	Note Added: 46638
2018-02-21 13:52	ollehar1	Changeset attached	=> LimeSurvey master ab75b411
2018-02-21 13:52	ollehar1	Note Added: 46665
2018-02-21 15:34	ollehar	Status	feedback => resolved
2018-02-21 15:35	ollehar	Resolution	reopened => fixed
2018-02-21 16:37	ollehar	Status	resolved => closed