View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
13337Bug reportsImport/Exportpublic2018-02-12 13:432019-05-23 10:04
ReporterDeusdeorum Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.3.x 
Fixed in Version3.15.x 
Summary13337: fail on csv token import
Description

Uploading a .csv-file generated from excel and specific mac does not work anymore.

Steps To Reproduce

Create a survey, set up it to use a token table and create a small tokens.csv-file containing firstname;lastname;email;token in excel and upload it to the token table, zero participants will be imported.

Additional Information

Included the same file generated from mac excel 2011, mac excel 2015, windows excel where only the latter works. All files work on 2.06LTS and 2.50+ Build 160526 (only have those two to test against...)

TagsNo tags attached.
Attached Files
tokens_mac_excel_v2011.csv (223 bytes)    
firstname;lastname;email;token
test1;test1;;test1
test2;test2;;test2
test3;test3;;test3
test4;test4;;test4
test5;test5;;test5
test6;test6;;test6
test7;test7;;test7
test8;test8;;test8
test9;test9;;test9
test10;test10;;test10
tokens_mac_excel_v2011.csv (223 bytes)   
tokens_mac_excel_v2015.csv (226 bytes)    
firstname;lastname;email;token
test1;test1;;test1
test2;test2;;test2
test3;test3;;test3
test4;test4;;test4
test5;test5;;test5
test6;test6;;test6
test7;test7;;test7
test8;test8;;test8
test9;test9;;test9
test10;test10;;test10
tokens_mac_excel_v2015.csv (226 bytes)   
tokens_windows_excel.csv (238 bytes)    
firstname;lastname;email;token
test1;test1;;test1
test2;test2;;test2
test3;test3;;test3
test4;test4;;test4
test5;test5;;test5
test6;test6;;test6
test7;test7;;test7
test8;test8;;test8
test9;test9;;test9
test10;test10;;test10
tokens_windows_excel.csv (238 bytes)   
Bug heat12
Complete LimeSurvey version number (& build)3.3.0 github
I will donate to the project if issue is resolvedNo
Browser
Database type & version 5.5.5-10.1.26-MariaDB-0+deb9u1
Server OS (if known)Debian GNU/Linux 9.3
Webserver software & version (if known) nginx/1.10.3
PHP Version 7.0.27-0+deb9u1

Users monitoring this issue

duvemyster

Activities

ollehar

ollehar

2018-02-12 14:34

administrator   ~46395

Which options did you choose when you exported the tokens?
ollehar

ollehar

2018-02-12 14:36

administrator   ~46396

Did you get this error message?

Selection_391.png (19,064 bytes)   
Selection_391.png (19,064 bytes)   
Deusdeorum

Deusdeorum

2018-02-12 14:39

reporter   ~46397

Just remove all the duplicate stuff. Sorry.

import-csv.png (130,834 bytes)
ollehar

ollehar

2018-02-12 15:11

administrator   ~46402

Works for me on latest git pull.

Selection_392.png (57,961 bytes)   
Selection_392.png (57,961 bytes)   
Deusdeorum

Deusdeorum

2018-02-15 09:29

reporter   ~46499

@olle I just tried on demo.limesurvey.org to verify it's not my installation. And it still doesn't work. And it works on 2.06LTS and 2.50+ Build 160526.

  • tokens_windows_excel.csv WORKS
  • tokens_mac_excel_v2011.csv Does not work
  • tokens_mac_excel_v2015.csv Does not work

All of the .csv-files are generated from respective excel versions. My guess is that there's some kind of encoding problem while detecting the character set of the file.
LouisGac

LouisGac

2018-05-16 12:45

developer   ~47624

we need somone one to confirm that he still face that bug.
else we'll close it.

Deusdeorum

Deusdeorum

2018-05-29 11:14

reporter   ~47894

@LouisGac Using the same files for version 3.7.3 I still can't import the csv-files from mac attached here. I can look deeper to see if there's any encoding stuff or something. But the same files works on 2.06LTS and a 2.50+ build
DenisChenu

DenisChenu

2018-09-04 16:03

developer   ~48966

Last edited: 2018-09-04 16:25

Git version : no update of csv file - PHP5.6
Unable to import :
0 records in CSV
0 records met minimum requirements
0 records imported

Difference is in line feed : only CR for mac, CR;LF; for windows
Update CR to LF (unix) work
…………………
Same file on same server with same user : work on 2.73 …

Capture du 2018-09-04 16-01-54.png (4,979 bytes)   
Capture du 2018-09-04 16-01-54.png (4,979 bytes)   
c_schmitz

c_schmitz

2018-09-04 16:54

administrator   ~48967

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=27889

Related Changesets

LimeSurvey: master 9419b901

2018-09-04 16:54:12

c_schmitz

Details Diff 		Fixed issue 13337: Fail on CSV token import when import file with Mac line endings Affected Issues
13337
mod - application/controllers/admin/tokens.php Diff File
mod - application/core/LSYii_Controller.php Diff File
mod - application/models/SettingGlobal.php Diff File
mod - application/models/UpdateForm.php Diff File

Issue History

Date Modified Username Field Change
2018-02-12 13:43 Deusdeorum New Issue
2018-02-12 13:43 Deusdeorum File Added: tokens_mac_excel_v2011.csv
2018-02-12 13:43 Deusdeorum File Added: tokens_mac_excel_v2015.csv
2018-02-12 13:43 Deusdeorum File Added: tokens_windows_excel.csv
2018-02-12 13:49 Deusdeorum Additional Information Updated
2018-02-12 14:21 ollehar Assigned To => ollehar
2018-02-12 14:21 ollehar Status new => assigned
2018-02-12 14:34 ollehar Note Added: 46395
2018-02-12 14:36 ollehar File Added: Selection_391.png
2018-02-12 14:36 ollehar Note Added: 46396
2018-02-12 14:36 ollehar Assigned To ollehar =>
2018-02-12 14:36 ollehar Status assigned => feedback
2018-02-12 14:39 Deusdeorum File Added: import-csv.png
2018-02-12 14:39 Deusdeorum Note Added: 46397
2018-02-12 14:39 Deusdeorum Status feedback => new
2018-02-12 15:11 ollehar File Added: Selection_392.png
2018-02-12 15:11 ollehar Note Added: 46402
2018-02-13 17:01 ollehar Status new => feedback
2018-02-15 09:29 Deusdeorum Note Added: 46499
2018-02-15 09:29 Deusdeorum Status feedback => new
2018-04-27 17:35 duvemyster Issue Monitored: duvemyster
2018-05-16 12:45 LouisGac Assigned To => LouisGac
2018-05-16 12:45 LouisGac Status new => feedback
2018-05-16 12:45 LouisGac Note Added: 47624
2018-05-29 11:14 Deusdeorum Note Added: 47894
2018-05-29 11:14 Deusdeorum Status feedback => assigned
2018-09-04 16:03 DenisChenu File Added: Capture du 2018-09-04 16-01-54.png
2018-09-04 16:03 DenisChenu Note Added: 48966
2018-09-04 16:03 DenisChenu Note Edited: 48966
2018-09-04 16:25 DenisChenu Note Edited: 48966
2018-09-04 16:54 c_schmitz Changeset attached => LimeSurvey master 9419b901
2018-09-04 16:54 c_schmitz Note Added: 48967
2018-09-04 16:54 c_schmitz Assigned To LouisGac => c_schmitz
2018-09-04 16:54 c_schmitz Resolution open => fixed
2019-05-23 10:04 c_schmitz Status assigned => closed
2019-05-23 10:04 c_schmitz Fixed in Version => 3.15.x
2021-08-10 20:23 guest Bug heat 10 => 12