View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
13233Bug reportsTheme editorpublic2018-01-22 17:212018-02-09 17:02
ReporterGabryxx7 Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.0.x 
Summary13233: [Bootswatch theme] Cyborg theme keeps being loaded even if not selected
Description

I copied the bootswatch theme to customize it, I set the cosmos theme but I noticed that the cyborg.min.css file is always loaded anyway even if the Cyborg theme is not selected.
I checked all my files and I never import it, but it's messing up the page css!

Steps To Reproduce
  • Copy the Bootswatch theme
  • Preview a questionnaire, the html page will show the cyborg.min.css as imported even if the selected theme is different (Cosmos in this case)
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)3.0.5+180118
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMYSQL v.5.5
Server OS (if known)Debian 6
Webserver software & version (if known)Apache
PHP VersionPHP 5.6.32

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2018-01-24 11:26

developer   ~45970

at which level do you select the variation? Survey? Survey Group? Global?
Gabryxx7

Gabryxx7

2018-01-24 13:49

reporter   ~45984

I just tried by:

  1. Setting the Cosmos theme on the extended Bootswatch theme that I am using. I set "inherit" for both the survey group and the survey, while I set the "cosmos" variation at global level (Configuration -> Themes -> Theme options -> Bootswatch theme).
  2. Setting Cosmos variation for both the Extended theme (in the options) and the survey, while the survey group is still on "inherit".
  3. Selecting cosmos for all of them (Survey, Survey group and Global)
Gabryxx7

Gabryxx7

2018-01-24 13:54

reporter   ~45986

Well I just found out and solved it, but I still think it should not be like that.

The only place where Cyborg was selected is the original Bootswatch theme, as soon as I set it to "Basic Bootstrap", the cyborg css file was not included anymore on the <head>.
I just think it should not be like that, if the theme is extended, the least general choice should be preferred over the other. So the order of importance I think should be more like Original Theme variation -> Extended Theme variation -> Survey group variation -> Survey variation, where the first one will be overridden by the second one, the second one will be overridden by the third one and so on (of course we are supposing none of them is set on "inherit").

I think what happened is that both headers (the one from the original bootswatch theme and the extended one) were being included in the html, causing it to load the two variations.
LouisGac

LouisGac

2018-01-24 14:16

developer   ~45991

indeed, they should not be any transmission from Original Theme variation to Extended Theme variation ....
c_schmitz

c_schmitz

2018-02-09 17:02

administrator   ~46370

Version 3.3.0 released

Issue History

Date Modified Username Field Change
2018-01-22 17:21 Gabryxx7 New Issue
2018-01-24 11:26 LouisGac Note Added: 45970
2018-01-24 13:49 Gabryxx7 Note Added: 45984
2018-01-24 13:54 Gabryxx7 Note Added: 45986
2018-01-24 14:16 LouisGac Note Added: 45991
2018-01-26 14:14 LouisGac Assigned To => LouisGac
2018-01-26 14:14 LouisGac Status new => resolved
2018-01-26 14:14 LouisGac Resolution open => fixed
2018-02-09 17:02 c_schmitz Note Added: 46370
2018-02-09 17:02 c_schmitz Status resolved => closed