View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
13120 | Bug reports | Other | public | 2018-01-04 08:50 | 2018-01-10 11:35 |
Reporter | TonisOrmisson | Assigned To | |||
Priority | urgent | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.0.0-rc.x | ||||
Summary | 13120: Cant change to custom default survey template | ||||
Description | Cant change to custom default survey template | ||||
Steps To Reproduce | have a custom tempolate in upload/themes/... go to global settings (btw the theme is not visible on survey theme selection) | ||||
Additional Information | Exception Error: Can't find a manifest for kuddelmuddel_base in ' /var/www/html/themes/survey/kuddelmuddel_base/ ' /var/www/html/application/models/TemplateManifest.php(574) 562 $bOldEntityLoaderState = libxml_disable_entity_loader(true); // @see: http://phpsecurity.readthedocs.io/en/latest/Injection-Attacks.html#xml-external-entity-injection Stack Trace 664 public function setBasics($sTemplateName = '', $iSurveyId = '') #1 253 #2 365 if (!is_file("$sUserTemplateRootDir/$sTemplatePath") #3 | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 3.0.1 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | na | ||||
Server OS (if known) | na | ||||
Webserver software & version (if known) | na | ||||
PHP Version | na | ||||
also: |
|
this workaround worked for me: in Linux - in dopcument root directory: |
|
This will not fix the bug in LS :| |
|
Tonis: could you please upload here your template so I can check if it's valid? |
|
A problem may be the entry in DB table 'templates.folder' : 'erweitert_vanilla' . LimeSurvey then actually looks for the template in folder LS/themes/survey/erweitert_vanilla.
... |
|
Louis, the Template: |
|
ok I'll do some testing this afternoon to check if it's a general problem. |
|
the folder in templates table has no path yes. This is how it looks after pushing the theme->install button: +-------------------+-------------------+ |
|
ok so indeed the problem was the name of the template (too long) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=25861 |
|
so the problem was the harsh validation of template name removing the dashes |
|
Thank you very much for your bug fix. Debian 8.9
Error: Can't find a manifest for erweitert_vanilla in ' /var/www/html/LS/themes/survey/erweitert_vanilla/ ' i.e.: the system is looking for the child theme in the parent theme directory this workaround works: setting a link from themes/survey/erweitert_vanilla to upload/themes/survey/erweitert_vanilla in Debian - in document root directory: |
|
Haenelt: those steps to reproduce are easier to understand. |
|
Ok, I understand that the name validation has been changed. Error: Can't find a manifest for .... in LS/themes/ yada yada |
|
yep I got it. I'll push the fix today |
|
Excellent, thanks |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=25895 |
|
should be fixed now |
|
Great! Works perfectly now. |
|
Thanks, works for me also |
|
LimeSurvey: master 41dd8d32 2018-01-09 12:10
Details Diff |
Fixed issue 13120: Cant use dash in template name |
Affected Issues 13120 |
|
mod - application/controllers/admin/surveyadmin.php | Diff File | ||
LimeSurvey: master e930664e 2018-01-10 11:45
Details Diff |
Fixed issue 13120: Cant change to custom default survey template |
Affected Issues 13120 |
|
mod - application/models/Template.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-01-04 08:50 | TonisOrmisson | New Issue | |
2018-01-04 09:53 | TonisOrmisson | Note Added: 45418 | |
2018-01-05 11:28 | Haenelt | Note Added: 45425 | |
2018-01-05 11:53 | TonisOrmisson | Note Added: 45426 | |
2018-01-08 11:28 |
|
Note Added: 45451 | |
2018-01-08 11:28 |
|
Sticky Issue | No => Yes |
2018-01-08 11:46 | Haenelt | Note Added: 45463 | |
2018-01-08 11:57 | TonisOrmisson | Note Added: 45467 | |
2018-01-08 11:57 |
|
Note Added: 45468 | |
2018-01-08 12:06 |
|
Priority | none => urgent |
2018-01-08 13:46 | TonisOrmisson | Note Added: 45488 | |
2018-01-08 16:07 | lmad | Issue Monitored: lmad | |
2018-01-09 10:30 |
|
Note Added: 45501 | |
2018-01-09 11:10 |
|
Changeset attached | => LimeSurvey master 41dd8d32 |
2018-01-09 11:10 |
|
Note Added: 45502 | |
2018-01-09 11:10 |
|
Assigned To | => LouisGac |
2018-01-09 11:10 |
|
Resolution | open => fixed |
2018-01-09 11:11 |
|
Note Added: 45503 | |
2018-01-09 11:58 |
|
Sticky Issue | Yes => No |
2018-01-09 11:59 |
|
Status | new => resolved |
2018-01-09 12:21 | Haenelt | Note Added: 45505 | |
2018-01-09 14:05 |
|
Note Added: 45512 | |
2018-01-10 08:46 | TonisOrmisson | Note Added: 45537 | |
2018-01-10 10:03 |
|
Note Added: 45538 | |
2018-01-10 10:07 | TonisOrmisson | Note Added: 45539 | |
2018-01-10 10:45 |
|
Changeset attached | => LimeSurvey master e930664e |
2018-01-10 10:45 |
|
Note Added: 45541 | |
2018-01-10 10:49 |
|
Note Added: 45542 | |
2018-01-10 11:02 | Haenelt | Note Added: 45543 | |
2018-01-10 11:18 | TonisOrmisson | Note Added: 45544 | |
2018-01-10 11:35 |
|
Status | resolved => closed |
2021-08-03 07:32 | guest | Bug heat | 6 => 8 |