View Issue Details

IDProjectCategoryView StatusLast Update
13091Bug reportsPluginspublic2018-06-01 17:46
ReporterDenisChenu Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionwon't fix 
Product Version3.0.0-rc.x 
Summary13091: Old plugin can break Plugin management (even deactivated)
Description

Just extend \ls\pluginmanager\PluginBase : unable to manage plugin

Steps To Reproduce

https://github.com/SondagesPro/LS-sendMailAjax last version

Additional Information

Not same issue than https://bugs.limesurvey.org/view.php?id=13090 then 2 separate bug

Fatal error: Class 'ls\pluginmanager\PluginBase' not found in /home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey_develop/plugins/sendMailAjax/sendMailAjax.php on line 21

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.0.0
I will donate to the project if issue is resolvedNo
Sync to Zoho Project
Browsernot relevant
Database & DB-Versionmysql 5.something
Server OS (if known)debian7+dotdeb (i know, must update)
Webserver software & version (if known)apache2
PHP VersionPHP5.6

Relationships

related to 13090 closedLouisGac Very Old plugin can break Plugin management (even deactivated) 
has duplicate 13191 closed Plugin manager goes blank after upgrade from Version 2.73.0+171219 to Version 3.0.4+180116 

Activities

DenisChenu

DenisChenu

2017-12-20 17:55

developer   ~45349

The bug is "deactivated", if it's activated : it's a plugin issue, but not activated : it's a LimeSurvey issue in my point of view

DenisChenu

DenisChenu

2018-01-09 18:48

developer   ~45531

I think extend PluginBase is the good solution.

But it was disable at 2.63 ? No ?

https://github.com/SondagesPro/LS-sendMailAjax/commit/d5438c107c737af9b0e9388e9a5ac6d99570e940

DenisChenu

DenisChenu

2018-01-09 19:24

developer   ~45535

OK : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/core/PluginBase.php is currently in 3.0
And in 2.67 too
https://github.com/LimeSurvey/LimeSurvey/commit/e8d2a9ecf360071786570e3e06b3843b59049e92#diff-5a91a12f23c22838ec1eb101856b1f1b

BUT : i's not in API : https://github.com/LimeSurvey/LimeSurvey/commit/212a0e73e039e645faf8d91dc371553768ecb0e1#commitcomment-20983028

DenisChenu

DenisChenu

2018-01-09 19:28

developer   ~45536

Last edited: 2018-01-09 19:28

View 2 revisions

About the orginal issue , i think we need a plugin.xml/plugin.json/… … anything

With an array
'compatibility' =>(
'min'=>
'max'=>
)

For starting, and add more extra option/information (licence , homepage etc …) after.

I can take it if OK.

DenisChenu

DenisChenu

2018-01-17 15:18

developer   ~45867

Current solution : 2.72+3.0 compatible plugins.
change 'ls\pluginmanager\PluginBase' into 'PluginBase'

LouisGac

LouisGac

2018-05-23 11:23

developer   ~47738

no retro compatibility for plugins

DenisChenu

DenisChenu

2018-06-01 17:46

developer   ~47941

@LouisGac : i understand the no retro compatibility, the point is
«Don't load old plugin that can broke LimeSurvey»

You have a 2.63 plugin, you use comfortupdate to don't have to go to FTP
You update to 3.8 …

Nothing to do : you must go to FTP …

Issue History

Date Modified Username Field Change
2017-12-20 17:54 DenisChenu New Issue
2017-12-20 17:55 DenisChenu Note Added: 45349
2017-12-20 17:55 DenisChenu Relationship added related to 13090
2018-01-09 18:48 DenisChenu Note Added: 45531
2018-01-09 19:24 DenisChenu Note Added: 45535
2018-01-09 19:28 DenisChenu Note Added: 45536
2018-01-09 19:28 DenisChenu Note Edited: 45536 View Revisions
2018-01-17 15:16 DenisChenu Relationship added has duplicate 13191
2018-01-17 15:18 DenisChenu Note Added: 45867
2018-05-23 11:23 LouisGac Sticky Issue No => Yes
2018-05-23 11:23 LouisGac Assigned To => LouisGac
2018-05-23 11:23 LouisGac Status new => closed
2018-05-23 11:23 LouisGac Resolution open => won't fix
2018-05-23 11:23 LouisGac Note Added: 47738
2018-06-01 17:46 DenisChenu Note Added: 47941