View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
12734Bug reportsImport/Exportpublic2017-09-28 18:492018-01-15 10:41
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.7x.x 
Fixed in Version2.7x.x 
Summary12734: SPSS : exporting complete or uncomplete make different syntax
Description

When exporting complete or uncomplete : we can have different syntax file. I think it must be the same

Steps To Reproduce

Import included survey : export all and just uncomplete after. the size/with of variable are not the same.

Additional Information

I think there are another biggest issue : even with SPSS>16 : text size can be cut to 1 character by syntax (even when export whole).

My big issue : who know SPSS syntax ????

TagsNo tags attached.
Attached Files
survey_archive_SPSS_littleissue.lsa (3,071 bytes)
Bug heat8
Complete LimeSurvey version number (& build)2.71.1
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionmysql
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
related to 12697 closedDenisChenu SPSS Export - responses truncated for incomplete answers 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2017-09-28 18:58

developer   ~44522

OK : confirm the biggest issue : SPSS syntax can truncate text and numeric value. Due to : take 500 1st line to know the width … bad code here …

survey_archive_SPSS_bigissue.lsa (6,862 bytes)
DenisChenu

DenisChenu

2017-09-29 08:36

developer   ~44525

I found only this part about SPSS/PSPP format …
https://www.gnu.org/software/pspp/manual/html_node/String-Formats.html#String-Formats
https://www.gnu.org/software/pspp/manual/html_node/Basic-Numeric-Formats.html#Basic-Numeric-Formats

But seems it's for .dat format file (fixed column width …). Need help from SPSS specialist :)

https://github.com/LimeSurvey/LimeSurvey/pull/815
jelo

jelo

2017-09-29 16:34

partner   ~44531

Limesurvey has never generated SPSS syntax code which was correct in terms of variable length. That was even the case in 2.05, 2.06.
A manual edit was always necessary since the length of textfields was often set wrong.
I would recommend removing the magic code which decides about the length. Just set max. length in the syntax file (at least when the newer SPSS versions are choosen).
There was some input (last year or even longer ago) by Tammo to get the SPSS export fixed. Perhaps he can tell you if the input was used in the code.
DenisChenu

DenisChenu

2017-09-29 17:11

developer   ~44534

I already find the max length of string size in triple-s with success. It's the reason i think we can get it :).
You can test with copy pasting the 2 files on https://github.com/LimeSurvey/LimeSurvey/pull/815

Currently : there are issue with Arry number : always show as dropdown.
And i think we can have better way to show number : for example with integer setting : https://framagit.org/SondagePro-LimeSurvey-plugin/exportTripleS/blob/master/tripleSHelper.php#L925 :).

But like say on github : try to fix issue here and really improve code and create a new core plugin for 3.0.

user70560

2017-10-30 15:39

  ~44903

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=24334
DenisChenu

DenisChenu

2017-10-30 18:20

developer   ~44905

I apply fix in 3.0 after
DenisChenu

DenisChenu

2017-10-31 14:54

developer   ~44910

Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=24350
c_schmitz

c_schmitz

2018-01-15 10:41

administrator   ~45779

Version 3.0.3 released.

Related Changesets

LimeSurvey: master aaaf8454

2017-10-30 15:39:02

user70560


Committer: GitHub Details Diff 		Fixed issue 12697: SPSS Export - responses truncated for incomplete answers (#815)

Fixed issue 12697: SPSS Export - responses truncated for incomplete answers
Dev: force_refresh before exporting (like export by plugins)
Dev: unsure it fix THIS issue, but clearly : force_refresh seem needed
Fixed issue 12734: SPSS : exporting complete or uncomplete make different syntax
Dev: get the real size for string/text in the DB
Dev: Must review numeric (N/K) part ?
Dev: What for float ?
Dev: Fix invalid var without minus
Dev: MAX for max …
Dev: Fix export Array text and multi text as string (get size)
Dev: default is to export as string
Dev: Fix other/comment issue …
Dev: Fix badly set array number as dropdown for text input
Dev: fix controller part
Dev: Fix width of numeric is total width
Dev: readding $length_vallabel = 120;
Dev: constant for all SPSS version ?
Dev: Fixed issue other and comment must be string		 Affected Issues
12697, 12734
mod - application/controllers/admin/export.php Diff File
mod - application/helpers/export_helper.php Diff File

LimeSurvey: develop 50f83ded

2017-10-31 14:54:12

DenisChenu

Details Diff 		Fixed issue 12697: SPSS Export - responses truncated for incomplete answers
Fixed issue 12734: SPSS : exporting complete or uncomplete make different syntax
Dev: Conflicts: application/helpers/export_helper.php		 Affected Issues
12697, 12734
mod - application/controllers/admin/export.php Diff File
mod - application/helpers/export_helper.php Diff File

Issue History

Date Modified Username Field Change
2017-09-28 18:49 DenisChenu New Issue
2017-09-28 18:49 DenisChenu File Added: survey_archive_SPSS_littleissue.lsa
2017-09-28 18:58 DenisChenu File Added: survey_archive_SPSS_bigissue.lsa
2017-09-28 18:58 DenisChenu Note Added: 44522
2017-09-29 08:36 DenisChenu Note Added: 44525
2017-09-29 16:34 jelo Note Added: 44531
2017-09-29 17:11 DenisChenu Note Added: 44534
2017-10-03 08:23 DenisChenu Relationship added has duplicate 12697
2017-10-13 13:47 DenisChenu Assigned To => DenisChenu
2017-10-13 13:47 DenisChenu Status new => assigned
2017-10-13 13:48 DenisChenu Relationship replaced related to 12697
2017-10-13 13:48 DenisChenu Relationship replaced has duplicate 12697
2017-10-13 13:48 DenisChenu Relationship replaced related to 12697
2017-10-30 15:39 user70560 Changeset attached => LimeSurvey master aaaf8454
2017-10-30 15:39 user70560 Note Added: 44903
2017-10-30 15:39 user70560 Assigned To DenisChenu => user70560
2017-10-30 15:39 user70560 Resolution open => fixed
2017-10-30 18:20 DenisChenu Assigned To user70560 => DenisChenu
2017-10-30 18:20 DenisChenu Status assigned => resolved
2017-10-30 18:20 DenisChenu Fixed in Version => 2.7x.x
2017-10-30 18:20 DenisChenu Note Added: 44905
2017-10-31 14:54 DenisChenu Changeset attached => LimeSurvey develop 50f83ded
2017-10-31 14:54 DenisChenu Note Added: 44910
2018-01-15 10:41 c_schmitz Note Added: 45779
2018-01-15 10:41 c_schmitz Status resolved => closed