View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12652 | Bug reports | Plugins | public | 2017-09-06 16:09 | 2019-04-30 09:10 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.67.x | ||||
Fixed in Version | 3.0.x | ||||
Summary | 12652: AuditLog plugin reset langage to default when register | ||||
Description | When registering to a survey with AuditLog activated (on token) : language is resetted to the default website. | ||||
Steps To Reproduce | Set your global settings to en (for example) | ||||
Additional Information | Issue is in the API : https://github.com/LimeSurvey/LimeSurvey/blob/454b9f6ca0db6b6a7a5c83c7bbdf5eee2c50ec32/plugins/AuditLog/AuditLog.php#L345 getCurrentUser use Yii::app()->user and Yii::app()->user set langage to default if not set … for this user. Then if you're not connected : always reset always … The API must be fixed, but need fix like https://github.com/LimeSurvey/LimeSurvey/blob/454b9f6ca0db6b6a7a5c83c7bbdf5eee2c50ec32/application/models/Permission.php#L696 (usage of Limesurvey specific session part) or fix Yii (replace getUser function) | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 4 | ||||
Complete LimeSurvey version number (& build) | 20170906 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
Issue introduced here : https://github.com/LimeSurvey/LimeSurvey/commit/308a039b0fcdf61423ee63477eebfaceeb9d9f32 |
|
https://github.com/LimeSurvey/LimeSurvey/pull/803 fix it before API |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=23854 |
|
LimeSurvey: master fb2fc9fc 2017-09-08 15:59:44
Committer: GitHub Details Diff |
Fixed issue 12652: AuditLog plugin reset langage to default when register (#803) Dev: really unsure original issue about language in pluin manager is fixed Dev: but pluginmanager extend admincontroller : ths one can set lang Fixed issue : login form language are not updated after error. |
Affected Issues 12652 |
|
mod - application/controllers/AdminController.php | Diff File | ||
mod - application/controllers/admin/authentication.php | Diff File | ||
mod - application/core/LSWebUser.php | Diff File | ||
mod - application/core/LSYii_Controller.php | Diff File | ||
mod - application/views/admin/authentication/login.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2017-09-06 16:09 | DenisChenu | New Issue | |
2017-09-06 16:09 | DenisChenu | File Added: limesurvey_survey_registerAuditLog.lss | |
2017-09-06 17:30 | DenisChenu | Note Added: 44397 | |
2017-09-06 19:44 | DenisChenu | Assigned To | => DenisChenu |
2017-09-06 19:44 | DenisChenu | Status | new => assigned |
2017-09-06 19:44 | DenisChenu | Note Added: 44398 | |
2017-09-08 15:59 |
|
Changeset attached | => LimeSurvey master fb2fc9fc |
2017-09-08 15:59 |
|
Note Added: 44408 | |
2017-09-08 15:59 |
|
Assigned To | DenisChenu => user70560 |
2017-09-08 15:59 |
|
Resolution | open => fixed |
2018-10-17 09:57 | DenisChenu | Status | assigned => resolved |
2018-10-17 09:57 | DenisChenu | Fixed in Version | => 3.0.x |
2019-04-30 09:10 | c_schmitz | Status | resolved => closed |