View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
12201Bug reportsSurvey takingpublic2017-03-14 15:542017-05-22 17:39
Reporteruser14106Assigned Touser14106 
PrioritynoneSeveritycrash 
Status closedResolutionfixed 
Product Version2.64.x 
Fixed in Version2.64.x 
Summary12201: Quotas not triggered for secondary languages
Description

related to recent quota-grid changes.
Quota languagesetting get not loaded in getQuotaInformation() for secondary languages.
Quotas not triggered for secondary languages.

I'll post a with a fix PR in a minute ..

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)2.64.1
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMariaDB
Server OS (if known)Linux
Webserver software & version (if known)Apache2
PHP Version7

Users monitoring this issue

There are no users monitoring this issue.

Activities

user14106

2017-03-14 16:04

  ~43283

https://github.com/LimeSurvey/LimeSurvey/pull/661
DenisChenu

DenisChenu

2017-03-14 16:09

developer   ~43284

I didn't understand something .

Why remove the language restriction ? https://github.com/LimeSurvey/LimeSurvey/pull/661/files#diff-a9dbc6157f3066d12e04af89a4bca062L4355

If you have 10 quota with 10 language , then here : https://github.com/LimeSurvey/LimeSurvey/pull/661/files#diff-a9dbc6157f3066d12e04af89a4bca062R4362 you do if for 100 elements , not for 10.

We need $oSurvey->quotas restricted by actual language , no ? App()->getLanguage();

user70560

2017-03-15 13:40

  ~43285

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=22474
c_schmitz

c_schmitz

2017-05-22 17:39

administrator   ~43688

Release 2.65.1 Build 170522

Related Changesets

LimeSurvey: master 888578de

2017-03-15 14:40

user14106

Committer: user70560


Details Diff		 Fixed issue 12201: Quotas not triggered for secondary languages (#661)

Dev: use mainLanguagesetting and remove loop from getting it
Dev: remove unused variables		 Affected Issues
12201
mod - application/helpers/common_helper.php Diff File
mod - application/models/Quota.php Diff File

Issue History

Date Modified Username Field Change
2017-03-14 15:54 user14106 New Issue
2017-03-14 15:54 user14106 Status new => assigned
2017-03-14 15:54 user14106 Assigned To => user14106
2017-03-14 16:04 user14106 Note Added: 43283
2017-03-14 16:09 DenisChenu Note Added: 43284
2017-03-15 13:40 user70560 Changeset attached => LimeSurvey master 888578de
2017-03-15 13:40 user70560 Note Added: 43285
2017-03-15 13:40 user70560 Assigned To user14106 => user70560
2017-03-15 13:40 user70560 Resolution open => fixed
2017-03-15 13:43 DenisChenu Assigned To user70560 => user14106
2017-03-15 13:43 DenisChenu Status assigned => resolved
2017-03-15 13:43 DenisChenu Fixed in Version => 2.64.x
2017-05-22 17:39 c_schmitz Note Added: 43688
2017-05-22 17:39 c_schmitz Status resolved => closed