View Issue Details

IDProjectCategoryView StatusLast Update
12190Bug reports[All Projects] Pluginspublic2017-10-23 10:42
ReportertammoAssigned ToLouisGac 
PrioritynormalSeveritycrash 
Status feedbackResolutionopen 
Product Version 
Target Version3.0.xFixed in Version 
Summary12190: Fatal error when plugin is missing
Description

When plugin is missing LimeSurvey crashes.

Fatal error: Call to a member function readConfigFile() on a non-object in D:\Dropbox\sites\drupal\hoofdtoegang\limegit.toolsforresearch.com\public_html\application\libraries\PluginManager\PluginManager.php on line 426

I re-installed L:imeSurvey, using the old databse. Earlier I had Olle's great right-click plugin in the installation, now I forgot to place it. I think LimeSurvey should not crash, but give an error and go on...

Steps To Reproduce

Re-install Limesurvey (without additional plugins) using a database in which a plugin was activated.

TagsNo tags attached.
Complete LimeSurvey version number (& build)Git Develop branche
I will donate to the project if issue is resolvedNo
Browserff
Database & DB-Versionff
Server OS (if known)ff
Webserver software & version (if known)ff
PHP Versionff

Activities

DenisChenu

DenisChenu

2017-03-11 12:05

developer   ~43263

Are you sure you have the last develop version ?
https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/libraries/PluginManager/PluginManager.php#L426

commited here : https://github.com/LimeSurvey/LimeSurvey/commit/8307ad6e65eb43d4970be137146cb3e85b3c9651

tammo

tammo

2017-03-11 12:50

developer   ~43264

Yes, I am sure. Just tested again:

Fatal error: Class 'PluginEvent' not found in D:\Dropbox\sites\drupal\hoofdtoegang\limegit.toolsforresearch.com\public_html\application\controllers\SurveysController.php on line 43

DenisChenu

DenisChenu

2017-03-12 02:42

developer   ~43265

Not same issue here, initial issue : Fatal error: Call to a member function readConfigFile() on a non-object in D:\Dropbox\sites\drupal\hoofdtoegang\limegit.toolsforresearch.com\public_html\application\libraries\PluginManager\PluginManager.php on line 426

DenisChenu

DenisChenu

2017-03-12 02:44

developer   ~43266

@olle related to @deprecated issue ? Did we confirm deprecation of PluginEvent (need to use \ls\pluginmanager\PluginEvent) ?
related : https://www.limesurvey.org/forum/plugins/108432-preparing-plugin-for-api-update

ollehar

ollehar

2017-03-13 11:11

administrator   ~43275

I agree with marking PluginEvent as deprecated, but not to remove it. As you say, the full namespace should be used instead.

ollehar

ollehar

2017-10-10 16:16

administrator   ~44562

What's the status of this?

DenisChenu

DenisChenu

2017-10-10 17:45

developer   ~44564

See https://github.com/LimeSurvey/LimeSurvey/pull/792#issuecomment-327083001

Then : user can not update plugins and update limesurvey after OR update limesurvey + update plugins after.

Currently no way to have a clean 2.5X+3.0 plugin

ollehar

ollehar

2017-10-11 10:55

administrator   ~44569

True. Although there is one dirty way: Check class_exists('\ls\pluginmanager\PluginBase') or class_exists('\LimeSurvey\PluginManager\PluginBase'), then adapt after.

DenisChenu

DenisChenu

2017-10-11 11:05

developer   ~44570

Yes, right … :(

ollehar

ollehar

2017-10-13 14:50

administrator   ~44669

Still a problem?

DenisChenu

DenisChenu

2017-10-13 15:11

developer   ~44671

Maybe a manual part ? https://manual.limesurvey.org/Category:Plugin_Development
(working code, because https://bugs.limesurvey.org/view.php?id=12727#c44505 )

Issue History

Date Modified Username Field Change
2017-03-10 15:07 tammo New Issue
2017-03-11 12:05 DenisChenu Note Added: 43263
2017-03-11 12:50 tammo Note Added: 43264
2017-03-12 02:42 DenisChenu Note Added: 43265
2017-03-12 02:42 DenisChenu Assigned To => ollehar
2017-03-12 02:42 DenisChenu Status new => assigned
2017-03-12 02:44 DenisChenu Note Added: 43266
2017-03-13 11:11 ollehar Note Added: 43275
2017-10-10 16:16 ollehar Status assigned => feedback
2017-10-10 16:16 ollehar Note Added: 44562
2017-10-10 16:17 ollehar Priority none => normal
2017-10-10 17:45 DenisChenu Note Added: 44564
2017-10-11 10:55 ollehar Note Added: 44569
2017-10-11 11:05 DenisChenu Note Added: 44570
2017-10-13 14:50 ollehar Note Added: 44669
2017-10-13 15:11 DenisChenu Note Added: 44671
2017-10-23 10:42 LouisGac Assigned To ollehar => LouisGac