View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
12176Bug reportsResponse browsingpublic2017-03-07 21:062017-03-10 18:07
Reportermfavetti Assigned Tomfavetti  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.64.x 
Fixed in Version2.64.x 
Summary12176: Fatal error in admin response controller
Description

Fatal error: 'break' not in the 'loop' or 'switch' context in /srv/www/limesurvey2/application/controllers/admin/responses.php on line 581

Additional Information

See: https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/admin/responses.php#L581
Problem created by this commit: https://github.com/LimeSurvey/LimeSurvey/commit/0c4ebb9b62faa30e444d7a0ce84d243b38e49268

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Users monitoring this issue

There are no users monitoring this issue.

Activities

mfavetti

mfavetti

2017-03-07 21:09

developer   ~43195

https://github.com/LimeSurvey/LimeSurvey/pull/654
DenisChenu

DenisChenu

2017-03-07 23:15

developer   ~43199

I understand the bug and the fix , but how you reproduce ?

user70560

2017-03-07 23:15

  ~43200

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=22453
mfavetti

mfavetti

2017-03-07 23:18

developer   ~43201

Just try to view the responses for any survey. The controller throws a fatal error, so nothing that uses it will work.
DenisChenu

DenisChenu

2017-03-08 00:25

developer   ~43204

Strange : because :

  1. Create a survey
  2. Add upload file type
  3. Activate surveyr, send a file
  4. Go to browsing
  5. download file without issue

PHP version ?
(my debug is at 2 always)
mfavetti

mfavetti

2017-03-08 00:31

developer   ~43205

With that break statement there, I get the fatal error when try to do step 4.

PHP 7.0.16
mfavetti

mfavetti

2017-03-08 00:33

developer   ~43206

I just found this: http://stackoverflow.com/questions/34871198/fatal-error-break-not-in-the-loop-or-switch-context-in

Are you on PHP 5?
DenisChenu

DenisChenu

2017-03-08 07:56

developer   ~43208

Yep 5.6

Related Changesets

LimeSurvey: master 9b16f5e7

2017-03-08 00:15

mfavetti

Committer: user70560


Details Diff		 Fixed issue 12176: Fatal error in admin response controller (#654) Affected Issues
12176
mod - application/controllers/admin/responses.php Diff File

Issue History

Date Modified Username Field Change
2017-03-07 21:06 mfavetti New Issue
2017-03-07 21:06 mfavetti Status new => assigned
2017-03-07 21:06 mfavetti Assigned To => mfavetti
2017-03-07 21:09 mfavetti Note Added: 43195
2017-03-07 21:11 mfavetti Project Feature requests => Bug reports
2017-03-07 21:12 mfavetti Priority none => high
2017-03-07 21:12 mfavetti Severity feature => partial_block
2017-03-07 21:12 mfavetti Reproducibility have not tried => always
2017-03-07 21:12 mfavetti Product Version => 2.64.x
2017-03-07 23:15 DenisChenu Note Added: 43199
2017-03-07 23:15 user70560 Changeset attached => LimeSurvey master 9b16f5e7
2017-03-07 23:15 user70560 Note Added: 43200
2017-03-07 23:15 user70560 Assigned To mfavetti => user70560
2017-03-07 23:15 user70560 Resolution open => fixed
2017-03-07 23:16 DenisChenu Assigned To user70560 => mfavetti
2017-03-07 23:16 DenisChenu Status assigned => resolved
2017-03-07 23:18 mfavetti Note Added: 43201
2017-03-08 00:25 DenisChenu Note Added: 43204
2017-03-08 00:31 mfavetti Note Added: 43205
2017-03-08 00:33 mfavetti Note Added: 43206
2017-03-08 07:56 DenisChenu Note Added: 43208
2017-03-08 07:56 DenisChenu PHP Version => 7
2017-03-10 18:07 c_schmitz Status resolved => closed
2017-03-10 18:07 c_schmitz Fixed in Version => 2.64.x