View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
12117Feature requestsConditionspublic2017-05-16 20:18
Reporteruser14106Assigned Toc_schmitz  
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Summary12117: Add actioncolumn chackboxws to quota-list view to enable bulk activate/deactivate
Description

Add actionColumn to quota-list view to enable bulk activate/deactivate.

Sometimes we have tens of quotas. And sometimes they need to be adjusted & re-adjusted. Turned on & off. Having bulk options would be more effective.

TagsNo tags attached.
Bug heat14
Story point estimate
Users affected %

Users monitoring this issue

DenisChenu, ollehar

Activities

DenisChenu

DenisChenu

2017-02-09 09:53

developer   ~42989

+1 but more : all quotas views must be reviewed currently, no ?

Maybe using Yii CGridView http://www.yiiframework.com/doc/api/1.1/CGridView

user14106

2017-02-09 10:09

  ~42990

I was assuming it is already using GridView and hoping It would be a rather easy fix and try to do it myself. But then discovered that it's not and switching to gridview would be substantial extra work :(

DenisChenu

DenisChenu

2017-02-09 10:29

developer   ~42991

;)

user14106

2017-02-11 15:49

  ~43001

Oh well...
I started to work on switching this on gridview ...
here:
https://github.com/TonisOrmisson/LimeSurvey/tree/quota-views-grid
let's see how it ends up

Mazi

Mazi

2017-02-17 19:53

updater   ~43033

Olle, would it be possible to also use the Mass Action plugin you created for mass editing quota details?

Often the URL or similar details have to be adjusted for a dozen quotas.

ollehar

ollehar

2017-02-20 11:41

administrator   ~43034

Sure. Add an issue on the github account.

user14106

2017-02-22 13:59

  ~43064

I think I need some help here.

I started working on switching the Quotas view to gridview And adding the MassiveActions that I was asking for.
I have got the grid up, but massive actions are throwing invalid selected items at me.

I have left some debugging output to the modal to see the selected id-s before final confirmation. And I get invalid IDs from there.
Maybe anybody could help me find how I get the wrong pk-s in the sItems?
There is a separate branch here
https://github.com/TonisOrmisson/LimeSurvey/tree/quota-views-grid

user14106

2017-02-22 14:23

  ~43067

seems I still found it
related to this:
https://github.com/yiisoft/yii/issues/3241

user14106

2017-02-22 14:58

  ~43068

The problem is that I am creating an additional table row for each quota where to put the Quota items stuff.
But the gridView takes the Id-s in a way that extra rows will mess up getChecked() result.

Any ideas how to solve this?

Any decent ways to display additional content which looks like an extra row, but is not a <tr> ?

c_schmitz

c_schmitz

2017-02-28 14:45

administrator   ~43096

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=22393

Related Changesets

LimeSurvey: master 59f51956

2017-02-28 15:44

user14106

Committer: c_schmitz


Details Diff
New feature 12117: Massive actions for quotas Affected Issues
12117
mod - application/controllers/admin/quotas.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/models/Quota.php Diff File
mod - application/models/QuotaLanguageSetting.php Diff File
mod - application/models/Survey.php Diff File
mod - application/models/SurveyLanguageSetting.php Diff File
add - application/views/admin/quotas/_form.php Diff File
add - application/views/admin/quotas/_form_langsetting.php Diff File
add - application/views/admin/quotas/_form_langsettings.php Diff File
mod - application/views/admin/quotas/editquota_view.php Diff File
rm - application/views/admin/quotas/editquotalang_view.php Diff
mod - application/views/admin/quotas/newquota_view.php Diff File
add - application/views/admin/quotas/viewquotas_massive_langsettings_form.php Diff File
add - application/views/admin/quotas/viewquotas_massive_selector.php Diff File
add - application/views/admin/quotas/viewquotas_quota_actions.php Diff File
add - application/views/admin/quotas/viewquotas_quota_members.php Diff File
add - application/views/admin/quotas/viewquotas_quota_members_actions.php Diff File
add - application/views/admin/quotas/viewquotas_quota_members_item.php Diff File
mod - application/views/admin/quotas/viewquotas_view.php Diff File
rm - application/views/admin/quotas/viewquotasfooter_view.php Diff
rm - application/views/admin/quotas/viewquotasrow_view.php Diff
rm - application/views/admin/quotas/viewquotasrowsub_view.php Diff

Issue History

Date Modified Username Field Change
2017-02-08 14:06 user14106 New Issue
2017-02-09 09:52 DenisChenu Issue Monitored: DenisChenu
2017-02-09 09:53 DenisChenu Note Added: 42989
2017-02-09 10:09 user14106 Note Added: 42990
2017-02-09 10:29 DenisChenu Note Added: 42991
2017-02-11 15:49 user14106 Note Added: 43001
2017-02-17 19:52 Mazi Issue Monitored: ollehar
2017-02-17 19:53 Mazi Note Added: 43033
2017-02-20 11:41 ollehar Note Added: 43034
2017-02-22 13:59 user14106 Note Added: 43064
2017-02-22 14:23 user14106 Note Added: 43067
2017-02-22 14:58 user14106 Note Added: 43068
2017-02-28 14:45 c_schmitz Changeset attached => LimeSurvey master 59f51956
2017-02-28 14:45 c_schmitz Note Added: 43096
2017-02-28 14:45 c_schmitz Assigned To => c_schmitz
2017-02-28 14:45 c_schmitz Resolution open => fixed
2017-05-16 20:18 user14106 Status new => closed
2021-08-02 22:00 guest Bug heat 10 => 14