View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12046 | Feature requests | Theme editor | public | 2017-01-12 09:04 | 2020-04-21 18:19 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | feature | ||
Status | closed | Resolution | fixed | ||
Summary | 12046: Reset boostrap extension to default | ||||
Description | Currently there are a lot of manual update in boostrap.css : https://github.com/LimeSurvey/LimeSurvey/commits/develop/application/extensions/bootstrap/assets/css/bootstrap.css It make harder to update boostrap to the last version .... I really think when we add an extension , we must NOT update it. Or if we update we fork it to allow merging from master more easily. | ||||
Additional Information | At this time i can not review what are updated because github are broken. | ||||
Tags | No tags attached. | ||||
Bug heat | 4 | ||||
Story point estimate | |||||
Users affected % | |||||
child of | 12045 | closed | DenisChenu | Theming for template |
Child of 12045, because without fixing this : it make harder to make a feature for 12045 |
|
Child of https://bugs.limesurvey.org/view.php?id=12052 : no background for alert-danger in admin theme |
|
I do not know if I understand you completely, but I strongly support the idea of using Bootstrap only in a plain vanilla way and overriding it in another .css file, therby making it possible to update bootstrap. Possible structure: |
|
And of course the distinction between functional and styling is not very clear, but we surely can find a way of working. |
|
So: in core and in template: |
|
And: yes, this is less efficient than putting it all in one file, but it is better for maintenance and for the end user. |
|
@tammo : boostrap.css core are replaced by boostrap.css included in template if template want it. The "issue" with boostrap.css are : it contains core +functionnality+theme+ etc .... |
|
This is not the way LS do … But : less-skelvanilla use variables.less same than bootstrap. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2017-01-12 09:04 | DenisChenu | New Issue | |
2017-01-12 09:04 | DenisChenu | Relationship added | parent of 12045 |
2017-01-12 09:05 | DenisChenu | Relationship deleted | parent of 12045 |
2017-01-12 09:05 | DenisChenu | Relationship added | related to 12045 |
2017-01-12 09:05 | DenisChenu | Relationship replaced | child of 12045 |
2017-01-12 09:06 | DenisChenu | Note Added: 42682 | |
2017-01-14 12:16 | DenisChenu | Tag Attached: 12052 | |
2017-01-14 12:18 | DenisChenu | Note Added: 42728 | |
2017-01-14 12:37 | tammo | Note Added: 42729 | |
2017-01-14 12:50 | tammo | Note Added: 42730 | |
2017-01-14 12:52 | tammo | Note Added: 42731 | |
2017-01-14 12:53 | tammo | Note Added: 42732 | |
2017-01-14 17:00 | DenisChenu | Note Added: 42733 | |
2017-01-15 16:13 | c_schmitz | Tag Detached: 12052 | |
2020-04-21 18:19 | DenisChenu | Assigned To | => DenisChenu |
2020-04-21 18:19 | DenisChenu | Status | new => closed |
2020-04-21 18:19 | DenisChenu | Resolution | open => fixed |
2020-04-21 18:19 | DenisChenu | Note Added: 57295 |