View Issue Details

IDProjectCategoryView StatusLast Update
12046Feature requests[All Projects] Theme editorpublic2017-01-15 16:13
ReporterDenisChenuAssigned To 
PrioritynoneSeverityfeature 
Status newResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary12046: Reset boostrap extension to default
Description

Currently there are a lot of manual update in boostrap.css : https://github.com/LimeSurvey/LimeSurvey/commits/develop/application/extensions/bootstrap/assets/css/bootstrap.css

It make harder to update boostrap to the last version ....

I really think when we add an extension , we must NOT update it. Or if we update we fork it to allow merging from master more easily.

Additional Information

At this time i can not review what are updated because github are broken.

TagsNo tags attached.

Relationships

child of 12045 new Theming for template 

Activities

DenisChenu

DenisChenu

2017-01-12 09:06

developer   ~42682

Child of 12045, because without fixing this : it make harder to make a feature for 12045

DenisChenu

DenisChenu

2017-01-14 12:18

developer   ~42728

Child of https://bugs.limesurvey.org/view.php?id=12052 : no background for alert-danger in admin theme

tammo

tammo

2017-01-14 12:37

partner   ~42729

I do not know if I understand you completely, but I strongly support the idea of using Bootstrap only in a plain vanilla way and overriding it in another .css file, therby making it possible to update bootstrap.

Possible structure:
bootstrap.css
ls-functional.css
ls-styling.css

tammo

tammo

2017-01-14 12:50

partner   ~42730

And of course the distinction between functional and styling is not very clear, but we surely can find a way of working.

tammo

tammo

2017-01-14 12:52

partner   ~42731

So: in core
bootstrap.css (plain)
ls-functional (only functional css statements)

and in template:
update-functional.css (for overrides of the functional stylesheet)
template.css (which is styling.css)
or a combination of these two...

tammo

tammo

2017-01-14 12:53

partner   ~42732

And: yes, this is less efficient than putting it all in one file, but it is better for maintenance and for the end user.

DenisChenu

DenisChenu

2017-01-14 17:00

developer   ~42733

@tammo : boostrap.css core are replaced by boostrap.css included in template if template want it.

The "issue" with boostrap.css are : it contains core +functionnality+theme+ etc ....

Issue History

Date Modified Username Field Change
2017-01-12 09:04 DenisChenu New Issue
2017-01-12 09:04 DenisChenu Relationship added parent of 12045
2017-01-12 09:05 DenisChenu Relationship deleted parent of 12045
2017-01-12 09:05 DenisChenu Relationship added related to 12045
2017-01-12 09:05 DenisChenu Relationship replaced child of 12045
2017-01-12 09:06 DenisChenu Note Added: 42682
2017-01-14 12:16 DenisChenu Tag Attached: 12052
2017-01-14 12:18 DenisChenu Note Added: 42728
2017-01-14 12:37 tammo Note Added: 42729
2017-01-14 12:50 tammo Note Added: 42730
2017-01-14 12:52 tammo Note Added: 42731
2017-01-14 12:53 tammo Note Added: 42732
2017-01-14 17:00 DenisChenu Note Added: 42733
2017-01-15 16:13 c_schmitz Tag Detached: 12052