View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
11934Bug reportsDocumentationpublic2017-07-21 17:08
Reportertammo Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionwon't fix 
Product Version2.56.x 
Summary11934: {SAVE} {CLEARALL} still show up, even when deleted from navigator.pstpl
Description

When you delete the {SAVE} and/or{CLEARALL} from navigator.pstpl, they still show up on the screen.

Steps To Reproduce

Works in any survey when user switched on: "Participant may save and resume later"

Possibly due to some javascript magic which replaces these items and displays then in the navbar.

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)2.56 and 3.0.0 alpha
I will donate to the project if issue is resolvedNo
Browserff
Database type & versionff
Server OS (if known)ff
Webserver software & version (if known)ff
PHP Versionff

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-11-21 19:47

developer   ~42098

Screenshot please ? If it's for "header" : {SAVE_LINKS} and {CLEARALL_LINKS} work without need of SAVE and CLEARALL.
Manual need update

tammo

tammo

2016-11-21 20:01

developer   ~42099

Last edited: 2016-11-21 20:02

Screenshot: look at any survey, with or without {SAVE} {CLEARALL} in navigator.pstpl... There is just no visible difference.

In what template file can I find {SAVE_LINKS} and {CLEARALL_LINKS}?

tpartner

tpartner

2016-11-21 22:32

partner   ~42101

The {CLEARALL_LINKS} placeholder simply inserts an anchor element that is used to click the #clearall element inserted via {CLEARALL}.

The point is that if there is no {CLEARALL}, then {CLEARALL_LINKS} shouldn't be rendered - there is nothing to click.

@tammo - those placeholders are in startpage.pstpl.

DenisChenu

DenisChenu

2016-11-22 08:18

developer   ~42102

@tpartner {CLEARALL_LINKS} work out of the box in 3.0 : no need {CLEARALL}.

You can use {CLEARALL_LINKS} without {CLEARALL} : this is the fact.
Even in the old 25X with removing CLEARALL : it work : http://testing.sondages.pro/answershtml/index.php/899541

See https://github.com/LimeSurvey/LimeSurvey/commit/f2b923e1b30f4281e65e103ae4d1a5ca4af06518

The (action_LINK} need js, the {action} don't need js if is inside form.

It's a documentation issue, not a code issue.

tpartner

tpartner

2016-11-22 12:17

partner   ~42120

@DenisChenu, it may be fixed in 3.x but it is not fixed it 2.56.1.

I just tested with a new pull, and if the {CLEARALL} placeholder is removed, clicking on the inserted {CLEARALL_LINKS} element does nothing.

DenisChenu

DenisChenu

2016-11-22 14:02

developer   ~42123

OK, then not me . I totally rework all HTML, and move 'template' function to 'core' function for this reason.
This is managed in template.js , not elsewhere : we can not fix it in user template.

LouisGac

LouisGac

2017-04-25 11:56

developer   ~43444

template engine is rewritten in develop branch.

tammo

tammo

2017-04-25 11:59

developer   ~43446

Right. I guess some more errors will be resolved this way

c_schmitz

c_schmitz

2017-07-21 17:08

administrator   ~44144

Version 3.0.0-beta.1 released

Issue History

Date Modified Username Field Change
2016-11-21 18:59 tammo New Issue
2016-11-21 18:59 tammo Status new => assigned
2016-11-21 18:59 tammo Assigned To => DenisChenu
2016-11-21 19:47 DenisChenu Note Added: 42098
2016-11-21 20:01 tammo Note Added: 42099
2016-11-21 20:02 tammo Note Edited: 42099
2016-11-21 22:32 tpartner Note Added: 42101
2016-11-22 08:18 DenisChenu Note Added: 42102
2016-11-22 08:18 DenisChenu Category Survey design => Documentation
2016-11-22 08:18 DenisChenu Product Version 2.56.x => 3.0
2016-11-22 08:18 DenisChenu Target Version 2.56.x => 3.0.x
2016-11-22 12:17 tpartner Note Added: 42120
2016-11-22 14:01 DenisChenu Product Version 3.0 => 2.56.x
2016-11-22 14:01 DenisChenu Fixed in Version => 3.0
2016-11-22 14:01 DenisChenu Target Version 3.0.x =>
2016-11-22 14:01 DenisChenu Assigned To DenisChenu =>
2016-11-22 14:01 DenisChenu Status assigned => new
2016-11-22 14:02 DenisChenu Note Added: 42123
2017-04-25 11:56 LouisGac Assigned To => LouisGac
2017-04-25 11:56 LouisGac Status new => resolved
2017-04-25 11:56 LouisGac Resolution open => won't fix
2017-04-25 11:56 LouisGac Note Added: 43444
2017-04-25 11:59 tammo Note Added: 43446
2017-07-21 17:08 c_schmitz Note Added: 44144
2017-07-21 17:08 c_schmitz Status resolved => closed