View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11908 | Feature requests | Survey taking | public | 2016-11-15 01:23 | 2018-04-06 11:48 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | feature | ||
Status | closed | Resolution | fixed | ||
Fixed in Version | 3.0 | ||||
Summary | 11908: Remove the "has-error" when it's not needed anymore | ||||
Description | If a mandatory array question type is send with some unanswered : But when the row his answered : the class still here | ||||
Additional Information | Easy with radio only Must be in survey.js : core issue. After template can try some with EM , but EM id broken for lines actually : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/expressions/em_manager_helper.php#L6614 | ||||
Tags | answers_html | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Story point estimate | |||||
Users affected % | |||||
I put this in Feature : it's a feature, but not a request. Needed feature |
|
@tammo : i start to work on it next week. But there are some glitch here.
See http://getbootstrap.com/css/#forms-control-validation Some possible solution
|
|
And also tricky for questions when minimal 2 and maximal 4 need to be answered. But that will be another challenge... |
|
It's another issue : must be done with Expression Manager + Expression Manager event. Think : |
|
OK, |
|
Tammo are not in "assigned possibility", just need an advice ... Looking at system, maybe it's better to remove the 'has-error' from PHP. Adding it to the new 'template-default' package for starting (or limesurvey-public) , doping it only in javascript. https://github.com/LimeSurvey/LimeSurvey/commit/f1e783477051b1e97750dc386a0a5ce9a6324f1b We have some issue :
Then : not by core. And then just add 'ls-mandatory-error' on the line + text-error and the 'answertext'. OK ? |
|
Sounds like a reasonable suggestion to me. A related question: Can we have different mandatory warning messages for different question types? E.g. for Array Texts it would be nice to tell the user something more specific. Instead of just "This error is mandatory..." we should add "...please enter text at every text field." a) Is this possible? |
|
a + b : already done: https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/expressions/em_manager_helper.php#L6398 We don't use enter text, think we use 'Please fill ...' PS : really helpfull : tank or checkbox is needed for example. BUT : my english is so poor : u just don't update language string if i can ;) |
|
LimeSurvey: develop 2ad7bb1c 2016-12-02 20:02 Details Diff |
Dev: start feature 11908: Remove the "has-error" when it's not needed anymore |
Affected Issues 11908 |
|
mod - application/core/packages/limesurvey/survey.js | Diff File | ||
mod - application/helpers/SurveyRuntimeHelper.php | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/10point/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/5point/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/array/dropdown/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/array/no_dropdown/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/column/answer.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/dualscale/answer.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/dualscale/answer_dropdown.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/increasesamedecrease/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/cells/answer_td.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/texts/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/texts/rows/cells/answer_td.php | Diff File | ||
mod - application/views/survey/questions/answer/multiplenumeric/rows/input/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/multiplenumeric/rows/sliders/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/multipleshorttext/rows/answer_row_inputtext.php | Diff File | ||
mod - application/views/survey/questions/answer/multipleshorttext/rows/answer_row_textarea.php | Diff File | ||
LimeSurvey: develop e49aaf89 2016-12-07 10:43 Details Diff |
Dev: Feature 11908: Remove the "has-error" when it's not needed anymore Dev: use text-danger for th.answertex, remove it when not needed Dev: soing some test, but please : test it :) Dev: for :text and select : we can use :empty class (nopt submitted) Dev: but template related issue (color ...) |
Affected Issues 11908 |
|
mod - application/core/packages/limesurvey/survey.js | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File | ||
mod - application/views/layouts/public.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/dualscale/answer_dropdown.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/answer_row.php | Diff File | ||
mod - application/views/survey/questions/answer/arrays/texts/rows/answer_row.php | Diff File | ||
mod - scripts/dualscale.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-11-15 01:23 | DenisChenu | New Issue | |
2016-11-15 01:23 | DenisChenu | Status | new => assigned |
2016-11-15 01:23 | DenisChenu | Assigned To | => DenisChenu |
2016-11-15 01:24 | DenisChenu | Note Added: 41948 | |
2016-11-26 10:56 | DenisChenu | Tag Attached: answers_html | |
2016-11-26 11:10 | DenisChenu | Note Added: 42243 | |
2016-11-26 11:10 | DenisChenu | File Added: Capture du 2016-11-26 11-00-42.png | |
2016-11-26 11:10 | DenisChenu | File Added: Capture du 2016-11-26 11-07-40.png | |
2016-11-26 16:12 | tammo | Note Added: 42245 | |
2016-11-27 00:52 | DenisChenu | Note Added: 42246 | |
2016-12-02 18:26 | DenisChenu | Note Added: 42323 | |
2016-12-02 19:04 | DenisChenu | Changeset attached | => LimeSurvey develop 2ad7bb1c |
2016-12-03 10:29 | DenisChenu | Assigned To | DenisChenu => Mazi |
2016-12-03 10:29 | DenisChenu | Status | assigned => feedback |
2016-12-03 10:29 | DenisChenu | Note Added: 42332 | |
2016-12-05 11:22 | Mazi | Note Added: 42361 | |
2016-12-05 11:53 | DenisChenu | Note Added: 42364 | |
2016-12-05 11:53 | DenisChenu | Status | feedback => assigned |
2016-12-05 11:53 | DenisChenu | Assigned To | Mazi => DenisChenu |
2016-12-05 11:53 | DenisChenu | Note Edited: 42364 | |
2016-12-05 11:54 | DenisChenu | Note Edited: 42364 | |
2016-12-07 10:26 | DenisChenu | Changeset attached | => LimeSurvey develop e49aaf89 |
2016-12-07 10:27 | DenisChenu | Status | assigned => resolved |
2016-12-07 10:27 | DenisChenu | Resolution | open => fixed |
2016-12-07 10:27 | DenisChenu | Fixed in Version | => 3.0 |
2018-04-06 11:48 |
|
Status | resolved => closed |