View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
11906Bug reportsSurvey editingpublic2016-11-14 18:462016-11-18 12:56
Reportervkuzmin Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.54 
Fixed in Version2.56.x 
Summary11906: Сan not see the quota name when you select an answer for quota
Description

When you choose a question you see 'quota name'. After that you should choose one of the answers and quota name didnt show, only two ' symbols.

I dont have any errors in console.

Steps To Reproduce
  1. Make some questions.
  2. Make new quota.
  3. Try to add a question to that quota.
Additional Information

limesurvey\application\views\admin\quotas\newanswer_view.php line 11:22 looks fine but %s is empty:

div class="jumbotron message-box">
<div class='row'>
<h2><?php echo sprintf(gT("New answer for quota '%s'"), $quota_name);?></h2>
<p class="lead">
<?php eT("Select question");?>:
</p>

TagsNo tags attached.
Attached Files
quotas.png (9,808 bytes)   
quotas.png (9,808 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)Version 2.55.2+161103
I will donate to the project if issue is resolvedNo
BrowserChrome and Firefox
Database type & versionMySQL 5.7.14
Server OS (if known)Windows 7 sp1 x64
Webserver software & version (if known)Apache/2.4.23 (Win32)
PHP VersionPHP/5.6.24

Users monitoring this issue

There are no users monitoring this issue.

Activities

vkuzmin

vkuzmin

2016-11-14 18:50

reporter   ~41937

i'm sorry, limesurvey\application\views\admin\quotas\newanswer_view.php 16:17, not newanswer_view.php
vkuzmin

vkuzmin

2016-11-14 18:51

reporter   ~41938

Third try. limesurvey\application\views\admin\quotas\newanswertwo_view.php 16:17
LouisGac

LouisGac

2016-11-16 16:53

developer   ~41987

thank you for that detailed bug report
LouisGac

LouisGac

2016-11-16 16:58

developer   ~41989

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=21438
vkuzmin

vkuzmin

2016-11-16 17:07

reporter   ~41991

Ins not about apostrophe, that bug is somewhere else. Check it again please.
LouisGac

LouisGac

2016-11-16 17:10

developer   ~41992

Last edited: 2016-11-16 17:17

yeah you're right, it doesn't fix it.
vkuzmin

vkuzmin

2016-11-16 17:19

reporter   ~41994

look at limesurvey\application\controllers\admin\quotas.php

457:17
$aData['quota_name'] = $quota_name;
$aViewUrls[] = 'newanswer_view';

and 479:13
$aData['quota_name'] = $sQuotaName;
$aViewUrls[] = 'newanswertwo_view';

May be it somewhere here?
LouisGac

LouisGac

2016-11-16 17:29

developer   ~41995

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=21439
LouisGac

LouisGac

2016-11-16 17:29

developer   ~41996

yep it was indeed. Thank you for your great bug report.
Feel free to do some Pull Request to the repository
vkuzmin

vkuzmin

2016-11-16 17:47

reporter   ~41997

And once again. Please, fix 482:13 in quotas.php

Current:
$aData['quota_name'] = $sQuotaName;

I think that should be:
$aData['quota_name'] = $quota_name;
LouisGac

LouisGac

2016-11-17 10:28

developer   ~42012

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=21446
LouisGac

LouisGac

2016-11-17 10:29

developer   ~42013

so many commits for such a little bug....

Related Changesets

LimeSurvey: master 4a3ebd11

2016-11-16 16:57:43

LouisGac

Details Diff 		Fixed issue 11906: Сan not see the quota name when you select an answer for quota Affected Issues
11906
mod - application/views/admin/quotas/newanswertwo_view.php Diff File

LimeSurvey: master 06dd9885

2016-11-16 17:29:07

LouisGac

Details Diff 		Fixed issue 11906: Сan not see the quota name when you select an answer for quota Affected Issues
11906
mod - application/controllers/admin/quotas.php Diff File
mod - application/views/admin/quotas/newanswertwo_view.php Diff File

LimeSurvey: master b17221a7

2016-11-17 10:27:36

LouisGac

Details Diff 		Fixed issue 11906: Сan not see the quota name when you select an answer for quota Affected Issues
11906
mod - application/controllers/admin/quotas.php Diff File

Issue History

Date Modified Username Field Change
2016-11-14 18:46 vkuzmin New Issue
2016-11-14 18:46 vkuzmin File Added: quotas.png
2016-11-14 18:50 vkuzmin Note Added: 41937
2016-11-14 18:51 vkuzmin Note Added: 41938
2016-11-16 16:53 LouisGac Note Added: 41987
2016-11-16 16:58 LouisGac Changeset attached => LimeSurvey master 4a3ebd11
2016-11-16 16:58 LouisGac Note Added: 41989
2016-11-16 16:58 LouisGac Assigned To => LouisGac
2016-11-16 16:58 LouisGac Resolution open => fixed
2016-11-16 16:58 LouisGac Status new => resolved
2016-11-16 17:07 vkuzmin Note Added: 41991
2016-11-16 17:10 LouisGac Note Added: 41992
2016-11-16 17:11 LouisGac Note Edited: 41992
2016-11-16 17:17 LouisGac Note Edited: 41992
2016-11-16 17:19 vkuzmin Note Added: 41994
2016-11-16 17:29 LouisGac Changeset attached => LimeSurvey master 06dd9885
2016-11-16 17:29 LouisGac Note Added: 41995
2016-11-16 17:29 LouisGac Note Added: 41996
2016-11-16 17:47 vkuzmin Note Added: 41997
2016-11-17 10:28 LouisGac Changeset attached => LimeSurvey master b17221a7
2016-11-17 10:28 LouisGac Note Added: 42012
2016-11-17 10:29 LouisGac Note Added: 42013
2016-11-18 12:55 c_schmitz Fixed in Version => 2.56.x
2016-11-18 12:56 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing