View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11882 | Bug reports | Survey editing | public | 2016-11-07 17:58 | 2017-07-21 17:08 |
Reporter | tammo | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.55.x | ||||
Target Version | 3.0.x | ||||
Summary | 11882: Mobile view: short free text with prefic and suffix | ||||
Description | ... leaves very little space for respondent. Se image | ||||
Tags | answers_html | ||||
Attached Files | |||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | 2.55 answers_html | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | ff | ||||
Database type & version | ff | ||||
Server OS (if known) | ff | ||||
Webserver software & version (if known) | ff | ||||
PHP Version | ff | ||||
Yes : see my comment in some of my commit or in another bug report I think use same system than bs is OK. Here it's for fixed suffix/preffix. For example : i user use $ or € as suffix : he surely want it in same line, even in phone. If we force suffix/preffix at 100% no float : then a lot of user don't have a good experience. For try: use '$' as prefix / 'year' as sufix etc .... |
|
Can discuss tomorrow |
|
See uploaded file : boostrap have same issue. PS : this can be fixed in template easily too. |
|
Commented here : https://github.com/LimeSurvey/LimeSurvey/blob/answers_html/templates/default/css/template-core.css#L107 |
|
I agree that prefix/suffix is intended for 1 word only. We could make it much more sophisticated by looking via Javascript if it contains multiple words, but that is for premium (= paid) templates. For now I would settle on max (x) characters, where x is debatable, I would say max = 8 |
|
Can't we use a more dynamic approach so that the text field always gets a fixed min space and if prefix/suffix are too long to fit in, the get place above/below the input field? Would be great if that still worked because checking for a single character is not sufficient (my two cents). |
|
dynamic => js ? |
|
Second Denis comment about leaving the behaviour like it is. At least for the moment. I can think of situations where the suffix and prefix are not short. But it looks like a minor issue (not everything can be done in mobileview as good as on a bigger screen estate). |
|
Idea one : add a specific class in template.css for such purpose : can use this class to force block display if question have this class. But : core (and default) give the same behaviour than BS input-group input-group-addon |
|
Give me the name of the class 'class-to-force-block-on-prefix-and-suffix' seems long ..... |
|
prefix-block |
|
No : here is the class for prefix and sufix. Idea is a Question class (in the attribute) The wrapper force-prefix-block force-suffix-block seems better (for my Point of view) |
|
OK, as long as we document it correctly. |
|
Idea: shall we put all classes that can be used as an extra class in the readme of the template? And explain what they do? |
|
I start to add some comment to template.css / separate function in template.js etc .... Auto documented document seems better. BUT : here : core or template issue ? |
|
Depends where the .css code for the extra classes is located: if you put it in survey.css I think it should be documented in the general documentation. Extra classes that have their .css in template should be documented somewhere in the template. readme or other file, as long as the user can find it |
|
@tammo: I absolutely second your idea of documenting the main classes. @DenisChenu: By "dynamic" I wasn't thinking about JS but about simple CSS to let the elements float above/below each other if the place is too small to have a lengthy prefix and suffix. |
|
if the place is too small => need dynamic. And : what is too small ? When WE decide it's too small ? 10 caracter ? 16 caracter ? But if we have IIIIIII it take less placve than OOOOOOOOO with some font. And user can prefer to have smaller font in such case etc ...... http://michikono.github.io/boxfit/demo.html |
|
For keeping going I would prefer a two step approach:
But for now: simple and proceed. |
|
|
|
Dev: issue is reopen : I remove whole ls-input-group for survey.css : leave it for template |
|
I reopen it myself ;). I fix it survey.css : Maybe in another release add some class specific for this usage |
|
https://manual.limesurvey.org/QS:Suffix |
|
Version 3.0.0-beta.1 released |
|
LimeSurvey: develop 6a520ea3 2016-11-09 01:43 Details Diff |
Dev: issue 11882: Mobile view: short free text with prefic and suffix Dev: issue is reopen : remove whole ls-input-group for survey.css : leave it for template |
Affected Issues 11882 |
|
mod - templates/default/css/template.css | Diff File | ||
LimeSurvey: develop ca1a59df 2016-11-10 10:51 Details Diff |
Dev 11882: Mobile view: short free text with prefic and suffix |
Affected Issues 11882 |
|
mod - application/core/packages/limesurvey/survey.css | Diff File | ||
mod - application/views/survey/questions/multiplenumeric/rows/dynamic.php | Diff File | ||
mod - application/views/survey/questions/multiplenumeric/rows/input/answer_row.php | Diff File | ||
mod - application/views/survey/questions/multipleshorttext/rows/answer_row_inputtext.php | Diff File | ||
mod - application/views/survey/questions/multipleshorttext/rows/answer_row_textarea.php | Diff File | ||
mod - application/views/survey/questions/numerical/answer.php | Diff File | ||
mod - application/views/survey/questions/shortfreetext/text/item.php | Diff File | ||
mod - application/views/survey/questions/shortfreetext/textarea/item.php | Diff File | ||
mod - templates/default/css/template-core.css | Diff File | ||
mod - templates/default/css/template.css | Diff File | ||
LimeSurvey: develop 4eb8912b 2016-11-10 11:00 Details Diff |
Dev 11882: Mobile view: short free text with prefic and suffix Dev: Add .suffix-prefix-force class for force display at right/left |
Affected Issues 11882 |
|
mod - application/core/packages/limesurvey/survey.css | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-11-07 17:58 | tammo | New Issue | |
2016-11-07 17:58 | tammo | Status | new => assigned |
2016-11-07 17:58 | tammo | Assigned To | => DenisChenu |
2016-11-07 17:58 | tammo | File Added: shortfreetext.png | |
2016-11-08 00:41 | DenisChenu | Note Added: 41757 | |
2016-11-08 00:41 | DenisChenu | Status | assigned => feedback |
2016-11-08 00:41 | DenisChenu | Note Added: 41758 | |
2016-11-08 00:44 | DenisChenu | File Added: bootstrap-same-issue.png | |
2016-11-08 00:45 | DenisChenu | Note Added: 41759 | |
2016-11-08 00:46 | DenisChenu | Assigned To | DenisChenu => tammo |
2016-11-08 01:04 | DenisChenu | Note Added: 41760 | |
2016-11-08 14:42 | DenisChenu | Tag Attached: answers_html | |
2016-11-08 14:44 | tammo | Note Added: 41776 | |
2016-11-08 15:37 | Mazi | Note Added: 41778 | |
2016-11-08 15:47 | DenisChenu | Note Added: 41780 | |
2016-11-08 15:54 | jelo | Note Added: 41781 | |
2016-11-08 16:01 | DenisChenu | Note Added: 41782 | |
2016-11-08 16:02 | DenisChenu | Note Added: 41783 | |
2016-11-08 16:03 | tammo | Note Added: 41784 | |
2016-11-08 16:11 | DenisChenu | Note Added: 41785 | |
2016-11-08 16:13 | tammo | Note Added: 41786 | |
2016-11-08 16:17 | tammo | Note Added: 41787 | |
2016-11-08 16:18 | tammo | Note Edited: 41787 | |
2016-11-08 16:44 | DenisChenu | Note Added: 41791 | |
2016-11-08 17:54 | tammo | Note Added: 41794 | |
2016-11-08 17:56 | Mazi | Note Added: 41795 | |
2016-11-08 19:17 | DenisChenu | Note Added: 41796 | |
2016-11-08 19:17 | DenisChenu | Assigned To | tammo => DenisChenu |
2016-11-08 19:21 | tammo | Note Added: 41797 | |
2016-11-08 19:21 | tammo | Status | feedback => assigned |
2016-11-08 19:45 | DenisChenu | Note Added: 41799 | |
2016-11-09 00:46 | DenisChenu | Changeset attached | => LimeSurvey develop 6a520ea3 |
2016-11-09 00:47 | DenisChenu | Status | assigned => resolved |
2016-11-09 00:47 | DenisChenu | Resolution | open => fixed |
2016-11-09 00:47 | DenisChenu | Fixed in Version | => 3.0 |
2016-11-09 00:47 | DenisChenu | Note Added: 41800 | |
2016-11-10 09:36 | DenisChenu | Status | resolved => feedback |
2016-11-10 09:36 | DenisChenu | Resolution | fixed => reopened |
2016-11-10 09:36 | DenisChenu | Note Added: 41824 | |
2016-11-10 10:10 | DenisChenu | Changeset attached | => LimeSurvey develop 4eb8912b |
2016-11-10 10:11 | DenisChenu | Changeset attached | => LimeSurvey develop ca1a59df |
2016-11-10 10:11 | DenisChenu | Status | feedback => closed |
2016-11-10 10:11 | DenisChenu | Resolution | reopened => fixed |
2016-11-10 10:11 | DenisChenu | Note Added: 41827 | |
2016-11-10 10:11 | DenisChenu | Status | closed => resolved |
2017-07-21 17:08 | c_schmitz | Note Added: 44165 | |
2017-07-21 17:08 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |