View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
11882Bug reportsSurvey editingpublic2017-07-21 17:08
Reportertammo Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.55.x 
Target Version3.0.x 
Summary11882: Mobile view: short free text with prefic and suffix
Description

... leaves very little space for respondent. Se image

Tagsanswers_html
Attached Files
shortfreetext.png (8,543 bytes)   
shortfreetext.png (8,543 bytes)   
bootstrap-same-issue.png (17,143 bytes)   
bootstrap-same-issue.png (17,143 bytes)   
Bug heat10
Complete LimeSurvey version number (& build)2.55 answers_html
I will donate to the project if issue is resolvedNo
Browserff
Database type & versionff
Server OS (if known)ff
Webserver software & version (if known)ff
PHP Versionff

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-11-08 00:41

developer   ~41757

Yes : see my comment in some of my commit or in another bug report

I think use same system than bs is OK. Here it's for fixed suffix/preffix. For example : i user use $ or € as suffix : he surely want it in same line, even in phone.
For my experience : suffix/prefix are short and are more user with only one string.

If we force suffix/preffix at 100% no float : then a lot of user don't have a good experience.
I think, but unsure : suffix/prefix are most used with little word.

For try: use '$' as prefix / 'year' as sufix etc ....

DenisChenu

DenisChenu

2016-11-08 00:41

developer   ~41758

Can discuss tomorrow

DenisChenu

DenisChenu

2016-11-08 00:45

developer   ~41759

See uploaded file : boostrap have same issue.

PS : this can be fixed in template easily too.
But , maybe : in default allow breakline

DenisChenu

DenisChenu

2016-11-08 01:04

developer   ~41760

Commented here : https://github.com/LimeSurvey/LimeSurvey/blob/answers_html/templates/default/css/template-core.css#L107

tammo

tammo

2016-11-08 14:44

developer   ~41776

I agree that prefix/suffix is intended for 1 word only.

We could make it much more sophisticated by looking via Javascript if it contains multiple words, but that is for premium (= paid) templates. For now I would settle on max (x) characters, where x is debatable, I would say max = 8

Mazi

Mazi

2016-11-08 15:37

updater   ~41778

Can't we use a more dynamic approach so that the text field always gets a fixed min space and if prefix/suffix are too long to fit in, the get place above/below the input field?
I often use something like:
"I am |___| years old"

Would be great if that still worked because checking for a single character is not sufficient (my two cents).

DenisChenu

DenisChenu

2016-11-08 15:47

developer   ~41780

dynamic => js ?

jelo

jelo

2016-11-08 15:54

partner   ~41781

Second Denis comment about leaving the behaviour like it is. At least for the moment. I can think of situations where the suffix and prefix are not short. But it looks like a minor issue (not everything can be done in mobileview as good as on a bigger screen estate).

DenisChenu

DenisChenu

2016-11-08 16:01

developer   ~41782

Idea one : add a specific class in template.css for such purpose : can use this class to force block display if question have this class.

But : core (and default) give the same behaviour than BS input-group input-group-addon

DenisChenu

DenisChenu

2016-11-08 16:02

developer   ~41783

Give me the name of the class 'class-to-force-block-on-prefix-and-suffix' seems long .....

tammo

tammo

2016-11-08 16:03

developer   ~41784

prefix-block
suffix-block

DenisChenu

DenisChenu

2016-11-08 16:11

developer   ~41785

No : here is the class for prefix and sufix. Idea is a Question class (in the attribute)

The wrapper force-prefix-block force-suffix-block seems better (for my Point of view)

tammo

tammo

2016-11-08 16:13

developer   ~41786

OK, as long as we document it correctly.

tammo

tammo

2016-11-08 16:17

developer   ~41787

Last edited: 2016-11-08 16:18

Idea: shall we put all classes that can be used as an extra class in the readme of the template?

And explain what they do?

DenisChenu

DenisChenu

2016-11-08 16:44

developer   ~41791

I start to add some comment to template.css / separate function in template.js etc ....

Auto documented document seems better.

BUT : here : core or template issue ?

tammo

tammo

2016-11-08 17:54

developer   ~41794

Depends where the .css code for the extra classes is located: if you put it in survey.css I think it should be documented in the general documentation. Extra classes that have their .css in template should be documented somewhere in the template. readme or other file, as long as the user can find it

Mazi

Mazi

2016-11-08 17:56

updater   ~41795

@tammo: I absolutely second your idea of documenting the main classes.

@DenisChenu: By "dynamic" I wasn't thinking about JS but about simple CSS to let the elements float above/below each other if the place is too small to have a lengthy prefix and suffix.

DenisChenu

DenisChenu

2016-11-08 19:17

developer   ~41796

if the place is too small => need dynamic.

And : what is too small ? When WE decide it's too small ? 10 caracter ? 16 caracter ? But if we have IIIIIII it take less placve than OOOOOOOOO with some font. And user can prefer to have smaller font in such case etc ...... http://michikono.github.io/boxfit/demo.html

tammo

tammo

2016-11-08 19:21

developer   ~41797

For keeping going I would prefer a two step approach:

  1. make a "workable" solution that is not too much work. I would say: 8 characters (8xO).
  2. (but after 3.0 is launched) discuss and work out a more flexible solution. Some suggestions have already been mentioned.

But for now: simple and proceed.
My 2 cents...

DenisChenu

DenisChenu

2016-11-08 19:45

developer   ~41799

  1. make a "workable" solution that is not too much work. => New Css class attribute
DenisChenu

DenisChenu

2016-11-09 00:47

developer   ~41800

Dev: issue is reopen : I remove whole ls-input-group for survey.css : leave it for template

DenisChenu

DenisChenu

2016-11-10 09:36

developer   ~41824

I reopen it myself ;).

I fix it survey.css :
@media (min-width: 768px) { Show like a table }

Maybe in another release add some class specific for this usage

DenisChenu

DenisChenu

2016-11-10 10:11

developer   ~41827

https://manual.limesurvey.org/QS:Suffix
https://manual.limesurvey.org/QS:Prefix

c_schmitz

c_schmitz

2017-07-21 17:08

administrator   ~44165

Version 3.0.0-beta.1 released

Related Changesets

LimeSurvey: develop 6a520ea3

2016-11-09 00:43:51

DenisChenu

Details Diff
Dev: issue 11882: Mobile view: short free text with prefic and suffix
Dev: issue is reopen : remove whole ls-input-group for survey.css : leave it for template
Affected Issues
11882
mod - templates/default/css/template.css Diff File

LimeSurvey: develop ca1a59df

2016-11-10 09:51:35

DenisChenu

Details Diff
Dev 11882: Mobile view: short free text with prefic and suffix Affected Issues
11882
mod - application/core/packages/limesurvey/survey.css Diff File
mod - application/views/survey/questions/multiplenumeric/rows/dynamic.php Diff File
mod - application/views/survey/questions/multiplenumeric/rows/input/answer_row.php Diff File
mod - application/views/survey/questions/multipleshorttext/rows/answer_row_inputtext.php Diff File
mod - application/views/survey/questions/multipleshorttext/rows/answer_row_textarea.php Diff File
mod - application/views/survey/questions/numerical/answer.php Diff File
mod - application/views/survey/questions/shortfreetext/text/item.php Diff File
mod - application/views/survey/questions/shortfreetext/textarea/item.php Diff File
mod - templates/default/css/template-core.css Diff File
mod - templates/default/css/template.css Diff File

LimeSurvey: develop 4eb8912b

2016-11-10 10:00:43

DenisChenu

Details Diff
Dev 11882: Mobile view: short free text with prefic and suffix
Dev: Add .suffix-prefix-force class for force display at right/left
Affected Issues
11882
mod - application/core/packages/limesurvey/survey.css Diff File

Issue History

Date Modified Username Field Change
2016-11-07 17:58 tammo New Issue
2016-11-07 17:58 tammo Status new => assigned
2016-11-07 17:58 tammo Assigned To => DenisChenu
2016-11-07 17:58 tammo File Added: shortfreetext.png
2016-11-08 00:41 DenisChenu Note Added: 41757
2016-11-08 00:41 DenisChenu Status assigned => feedback
2016-11-08 00:41 DenisChenu Note Added: 41758
2016-11-08 00:44 DenisChenu File Added: bootstrap-same-issue.png
2016-11-08 00:45 DenisChenu Note Added: 41759
2016-11-08 00:46 DenisChenu Assigned To DenisChenu => tammo
2016-11-08 01:04 DenisChenu Note Added: 41760
2016-11-08 14:42 DenisChenu Tag Attached: answers_html
2016-11-08 14:44 tammo Note Added: 41776
2016-11-08 15:37 Mazi Note Added: 41778
2016-11-08 15:47 DenisChenu Note Added: 41780
2016-11-08 15:54 jelo Note Added: 41781
2016-11-08 16:01 DenisChenu Note Added: 41782
2016-11-08 16:02 DenisChenu Note Added: 41783
2016-11-08 16:03 tammo Note Added: 41784
2016-11-08 16:11 DenisChenu Note Added: 41785
2016-11-08 16:13 tammo Note Added: 41786
2016-11-08 16:17 tammo Note Added: 41787
2016-11-08 16:18 tammo Note Edited: 41787
2016-11-08 16:44 DenisChenu Note Added: 41791
2016-11-08 17:54 tammo Note Added: 41794
2016-11-08 17:56 Mazi Note Added: 41795
2016-11-08 19:17 DenisChenu Note Added: 41796
2016-11-08 19:17 DenisChenu Assigned To tammo => DenisChenu
2016-11-08 19:21 tammo Note Added: 41797
2016-11-08 19:21 tammo Status feedback => assigned
2016-11-08 19:45 DenisChenu Note Added: 41799
2016-11-09 00:46 DenisChenu Changeset attached => LimeSurvey develop 6a520ea3
2016-11-09 00:47 DenisChenu Status assigned => resolved
2016-11-09 00:47 DenisChenu Resolution open => fixed
2016-11-09 00:47 DenisChenu Fixed in Version => 3.0
2016-11-09 00:47 DenisChenu Note Added: 41800
2016-11-10 09:36 DenisChenu Status resolved => feedback
2016-11-10 09:36 DenisChenu Resolution fixed => reopened
2016-11-10 09:36 DenisChenu Note Added: 41824
2016-11-10 10:10 DenisChenu Changeset attached => LimeSurvey develop 4eb8912b
2016-11-10 10:11 DenisChenu Changeset attached => LimeSurvey develop ca1a59df
2016-11-10 10:11 DenisChenu Status feedback => closed
2016-11-10 10:11 DenisChenu Resolution reopened => fixed
2016-11-10 10:11 DenisChenu Note Added: 41827
2016-11-10 10:11 DenisChenu Status closed => resolved
2017-07-21 17:08 c_schmitz Note Added: 44165
2017-07-21 17:08 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing