View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11852 | Bug reports | Survey editing | public | 2016-11-01 14:47 | 2017-07-21 17:08 |
Reporter | tammo | Assigned To | DenisChenu | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Summary | 11852: Slider questions messed up due to wrong statement in survey.css | ||||
Description | See image. In the html the tag <div class="ls-input-group"> appears. Directly before that tab and after that tag there are col-xx-xx statements, resulting in nested cols. I think the tag should be: <div class="ls-input-group row"> and in the css, the statemnent: display: table should be changed. | ||||
Tags | answers_html | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 2.55 git | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | ff | ||||
Database type & version | ff | ||||
Server OS (if known) | ff | ||||
Webserver software & version (if known) | ff | ||||
PHP Version | ff | ||||
You don't have a reset here : with reset : need a display:table. I'm unsure about "ls-input-group" : i use it more like input-group + input-group-addon in BS : great to add a little information just right/left an input. Must be used only for suffix/preffix, but here : there are answers part inside. For the screenshot : what is the 'column_width' setting ? |
|
Proposed solution: Include reset IN slider-container : move the ls-input-group to slider container. |
|
This is the survey I use for testing |
|
Display: all in one... |
|
OK, thanks : yes big issue here :) |
|
Fix committed to answers_html branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21226 |
|
OK : fixed : put input-group in the slider only completly fix the issue. reset button is just near slider : more clear. But right answer part is after reset button. About ls-input-group .ls-input-group-addon : see https://github.com/LimeSurvey/LimeSurvey/commit/a0e26df9789c68639ab1179334f35c058d6fa787#diff-9ad3040bab7d1b1a562414c5f7d2edebR98 ls-input-group-addon must have near same purpose than http://getbootstrap.com/components/#input-groups-basic i think. And, for example Your vanity URL is not good on little phone (no place in input) |
|
I think we are getting close, but not there yet. Just an idea: currently the order of divs is: prefix - slider - suffix Could this be an idea: prefix - suffix - slider using col-sm-push/pull http://getbootstrap.com/css/#grid-column-ordering |
|
Maybe great ide : bnut why ? What is the purpose ? |
|
I suggested this to avoid that in mobile it looks like on the picture. I think it might be better to have the prefix and suffix both above the slider and not like now: prefix above, suffix below slider... |
|
More like this: see image 3 |
|
Where does that red dotted line come from? |
|
See image 4 for better alignment: all close to red dotted line. |
|
Image 4 |
|
OK, understand, but still : i'm not OK with this. HTML must be presented like he must be readed, not like it must be seen. If you put an order : you didn't put it for 'visually' see in thhis order : you put an order because it's better. And think here : its' more a template related issue : i find a way for 'lumen' but not for devel. For the red border : it's here to be sure ls-answers have all same margin/padding (row fixing). It's devel template : |
|
Fix committed to answers_html branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21249 |
|
Version 3.0.0-beta.1 released |
|
LimeSurvey: answers_html a0e26df9 2016-11-01 18:39 Details Diff |
Dev: Fixed issue 11852 bad place for input-group in slider question |
Affected Issues 11852 |
|
mod - application/core/packages/limesurvey/survey.css | Diff File | ||
mod - application/views/survey/questions/multiplenumeric/rows/sliders/answer_row.php | Diff File | ||
mod - styles-public/numeric-slider.css | Diff File | ||
mod - templates/default/css/ls-functional.css | Diff File | ||
mod - templates/flatmodern/css/template-core.css | Diff File | ||
mod - templates/lumen/css/template-core.css | Diff File | ||
LimeSurvey: answers_html 862cc544 2016-11-02 20:11 Details Diff |
Dev: Fixed issue 11852: Slider questions messed up due to wrong statement in survey.css Dev: add slider-item to answer-item Dev: fix some part of global css since remove ls-input-group from wrapper |
Affected Issues 11852 |
|
mod - application/helpers/qanda_helper.php | Diff File | ||
mod - application/views/survey/questions/multiplenumeric/rows/sliders/answer_row.php | Diff File | ||
mod - styles-public/numeric-slider.css | Diff File | ||
mod - templates/default/css/template-core.css | Diff File | ||
rm - templates/default/scripts/bootstrap-slider.js | Diff | ||
mod - templates/default/scripts/template.js | Diff File | ||
mod - templates/default/views/endpage.pstpl | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-11-01 14:47 | tammo | New Issue | |
2016-11-01 14:47 | tammo | Status | new => assigned |
2016-11-01 14:47 | tammo | Assigned To | => DenisChenu |
2016-11-01 14:47 | tammo | File Added: slider.png | |
2016-11-01 16:39 | DenisChenu | Note Added: 41650 | |
2016-11-01 16:40 | DenisChenu | Product Version | 2.55.x => 3.0 |
2016-11-01 16:42 | DenisChenu | Note Added: 41651 | |
2016-11-01 16:44 | tammo | File Added: limesurvey_survey_459676(1).lss | |
2016-11-01 16:44 | tammo | Note Added: 41652 | |
2016-11-01 16:44 | tammo | Note Added: 41653 | |
2016-11-01 17:03 | DenisChenu | Note Added: 41654 | |
2016-11-01 17:40 | DenisChenu | Changeset attached | => LimeSurvey answers_html a0e26df9 |
2016-11-01 17:40 | DenisChenu | Note Added: 41655 | |
2016-11-01 17:40 | DenisChenu | Resolution | open => fixed |
2016-11-01 17:45 | DenisChenu | Status | assigned => resolved |
2016-11-01 17:45 | DenisChenu | Fixed in Version | => 3.0 |
2016-11-01 17:45 | DenisChenu | Note Added: 41656 | |
2016-11-01 18:12 | tammo | File Added: slider-2.png | |
2016-11-01 18:12 | tammo | Note Added: 41657 | |
2016-11-01 18:15 | DenisChenu | Note Added: 41659 | |
2016-11-01 18:15 | DenisChenu | Status | resolved => feedback |
2016-11-01 18:15 | DenisChenu | Resolution | fixed => reopened |
2016-11-01 18:16 | DenisChenu | Note Edited: 41659 | |
2016-11-01 18:17 | tammo | Note Added: 41660 | |
2016-11-01 18:17 | tammo | Status | feedback => assigned |
2016-11-01 18:22 | tammo | File Added: slider-3.png | |
2016-11-01 18:22 | tammo | Note Added: 41661 | |
2016-11-01 18:22 | tammo | Note Added: 41662 | |
2016-11-01 18:23 | tammo | Note Edited: 41661 | |
2016-11-01 18:26 | tammo | File Added: slider-4.png | |
2016-11-01 18:26 | tammo | Note Added: 41663 | |
2016-11-01 18:26 | tammo | File Deleted: slider-4.png | |
2016-11-01 18:26 | tammo | File Added: slider-4.png | |
2016-11-01 18:27 | tammo | File Added: slider-5.png | |
2016-11-01 18:27 | tammo | Note Added: 41664 | |
2016-11-01 19:33 | DenisChenu | Note Added: 41665 | |
2016-11-02 15:39 | DenisChenu | Tag Attached: answers_html | |
2016-11-02 15:39 | DenisChenu | Target Version | 3.0.x => 3.0 |
2016-11-02 19:13 | DenisChenu | Changeset attached | => LimeSurvey answers_html 862cc544 |
2016-11-02 19:13 | DenisChenu | Note Added: 41673 | |
2016-11-02 19:14 | DenisChenu | Status | assigned => resolved |
2016-11-02 19:14 | DenisChenu | Resolution | reopened => fixed |
2017-07-21 17:08 | c_schmitz | Note Added: 44177 | |
2017-07-21 17:08 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |