View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11847 | Bug reports | Theme editor | public | 2016-10-31 02:12 | 2017-07-21 17:07 |
Reporter | DenisChenu | Assigned To | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.55.x | ||||
Fixed in Version | 3.0.x | ||||
Summary | 11847: Don't move all template in asset directory (views not needed) | ||||
Description | Actually : we move whole template to assets : i think we must add a "assets" directory. But this causes other concerns : what to do with {TEMPLATEURL} : actual one use real templateurl : not asset => then updating an image source update only the viewed source after F5 reload. It's OK for css image | ||||
Additional Information | Unsure if we need 2 url or not ? ASSETURL ? Complex for Survey manager ... | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 20161031 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
If you have 5 minutes before "big update" and if you find another idea for "image source" Another idea: The one for assets is used by "user who know it's better to have an asset (and {TEMPLATEASSETURL}", other user use "base dir". PS: this can wait AFTER the big update of thursday. |
|
http://www.yiiframework.com/doc/api/1.1/CAssetManager#excludeFiles-detail |
|
You want to exclude files directory ? But : is user want to use body{background-image(../files/bg.jpg)} .... It work actually, but what for TEMPLATEASSETURL |
|
OUps ... sorry : you think 'add viewdirectory' to excludeFiles. Yep : great idea |
|
.... And if , for another package : we need views directory ..... Must extend clientScript->registerPackage ... For another release than 3.0 |
|
Indeed, only JS, CSS and pictures needs to be in the assets (anything that the browser can cache). Views will never be cached by the browser, so they can be excluded without problems. |
|
Yes : but : Solution 1: adding asset directory with js/css and files
Solution 2: adding only js/css and files directory and put views and pstpl in excludeFiles
|
|
About other assets system in fact : we have php in some other assets (third_party) |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21425 |
|
We can not exclude by .pstpl and .php .... Yii have an 'includeFilesTypes' https://github.com/LimeSurvey/LimeSurvey/blob/master/framework/utils/CFileHelper.php#L144 |
|
It has been added to Yii2. For Yii1, they say that if someone wants it, he should a PR. Maybe I'll do it: |
|
Yes : about .php files : it come from bootsrap : really think it's not needed too. But : think there are a bug by us : No : we have a assets directory inside bs, then must be (i think) But : fonts are not in assets .... maybe boostrap need fix too ;). About boostrap : what do you think about something like this
PS : php files in assets directory : |
|
It's not only about php/view file It's too for an asset directory in template. Less files in this dir, only needed files in this directory etc .... |
|
Version 3.0.0-beta.1 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-10-31 02:12 | DenisChenu | New Issue | |
2016-10-31 02:15 | DenisChenu | Assigned To | => LouisGac |
2016-10-31 02:15 | DenisChenu | Status | new => feedback |
2016-10-31 02:15 | DenisChenu | Note Added: 41608 | |
2016-10-31 02:15 | DenisChenu | Note Edited: 41608 | |
2016-10-31 10:06 |
|
Note Added: 41613 | |
2016-10-31 10:22 | DenisChenu | Note Added: 41615 | |
2016-10-31 10:22 | DenisChenu | Status | feedback => assigned |
2016-10-31 14:33 | DenisChenu | Note Added: 41618 | |
2016-10-31 14:34 | DenisChenu | Assigned To | LouisGac => DenisChenu |
2016-10-31 15:38 | DenisChenu | Assigned To | DenisChenu => |
2016-10-31 15:38 | DenisChenu | Status | assigned => feedback |
2016-10-31 15:38 | DenisChenu | Note Added: 41619 | |
2016-10-31 15:52 |
|
Note Added: 41620 | |
2016-10-31 18:59 | DenisChenu | Note Added: 41622 | |
2016-10-31 18:59 | DenisChenu | Status | feedback => new |
2016-11-04 02:14 | DenisChenu | Note Added: 41710 | |
2016-11-14 16:07 |
|
Assigned To | => LouisGac |
2016-11-14 16:07 |
|
Status | new => assigned |
2016-11-15 18:15 |
|
Sticky Issue | No => Yes |
2016-11-15 19:06 |
|
Changeset attached | => LimeSurvey master 3085e0a9 |
2016-11-15 19:06 |
|
Note Added: 41967 | |
2016-11-15 19:06 |
|
Resolution | open => fixed |
2016-11-15 19:08 |
|
Sticky Issue | Yes => No |
2016-11-16 00:00 | DenisChenu | Note Added: 41973 | |
2016-11-16 09:52 |
|
Note Added: 41974 | |
2016-11-16 10:13 | DenisChenu | Note Added: 41976 | |
2016-12-07 11:36 |
|
Status | assigned => resolved |
2016-12-07 11:38 | DenisChenu | Note Added: 42431 | |
2017-02-21 11:45 | c_schmitz | Fixed in Version | => 3.0.x |
2017-07-21 17:07 | c_schmitz | Note Added: 44125 | |
2017-07-21 17:07 | c_schmitz | Status | resolved => closed |