View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 252
IDProjectCategoryView StatusDate SubmittedLast Update
11818Bug reportsSecuritypublic2016-10-19 14:002016-10-21 10:41
Reporterniph Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.54 
Fixed in Version2.55.x 
Summary11818: not exploitable XSS
Description

Hey

while reviewing your code I encountered the following issues which are fortunately not exploitable. Anyway I would recommend to implement some sanitization at the following resources.

limesurvey/application/views/admin/survey/Question/massive_actions/_set_questions_other.php
12: <input type="hidden" name="sid" value="<?php echo $_GET['surveyid']; ?>" class="custom-data"/>

limesurvey/application/views/admin/survey/Question/massive_actions/_set_css_class.php
12: <input type="hidden" name="sid" value="<?php echo $_GET['surveyid']; ?>" class="custom-data"/>

limesurvey/application/views/admin/survey/Question/massive_actions/_set_statistics_options.php
59: <input type="hidden" name="sid" value="<?php echo $_GET['surveyid']; ?>" class="custom-data"/>

cheers
niph

TagsNo tags attached.
Bug heat252
Complete LimeSurvey version number (& build)limesurvey2.54.4+161018.
I will donate to the project if issue is resolvedNo
Browser
Database type & versionnone
Server OS (if known)none
Webserver software & version (if known)none
PHP Versionnone

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-10-19 17:29

administrator   ~41489

Thank you!
c_schmitz

c_schmitz

2016-10-20 14:48

administrator   ~41498

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=21115
c_schmitz

c_schmitz

2016-10-21 10:41

administrator   ~41516

Version 2.55 released

Related Changesets

LimeSurvey: master 5443235d

2016-10-19 17:27:37

c_schmitz

Details Diff 		Fixed issue 11818: Non-sanitized output in massive actions for question list Affected Issues
11818
mod - application/views/admin/survey/Question/massive_actions/_set_css_class.php Diff File
mod - application/views/admin/survey/Question/massive_actions/_set_questions_other.php Diff File
mod - application/views/admin/survey/Question/massive_actions/_set_statistics_options.php Diff File

Issue History

Date Modified Username Field Change
2016-10-19 14:00 niph New Issue
2016-10-19 17:27 c_schmitz Assigned To => c_schmitz
2016-10-19 17:27 c_schmitz Status new => resolved
2016-10-19 17:27 c_schmitz Resolution open => fixed
2016-10-19 17:27 c_schmitz Fixed in Version => 2.55.x
2016-10-19 17:29 c_schmitz Note Added: 41489
2016-10-20 14:48 c_schmitz Changeset attached => LimeSurvey master 5443235d
2016-10-20 14:48 c_schmitz Note Added: 41498
2016-10-21 10:41 c_schmitz Note Added: 41516
2016-10-21 10:41 c_schmitz Status resolved => closed