View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
11800Bug reportsSurvey takingpublic2017-07-21 17:07
Reportertpartner Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.54 
Fixed in Version3.0.x 
Summary11800: Issues with question timer in answers_html branch
Description

Hi Denis, I assume you want these reported in Mantis. If not, let me know where to report.

1) The countdown is not reset when using /newtest/Y/ in the URL. Should this not start a new session, therefore a new countdown?

2) "Time limit expiry message display time" is broken - in line 183 of timer_javascript.php, the ".$time_limit_message_delay." variable is not defined.

3) Disabling the "Next" button works but shouldn't this also apply to the "Submit" button (on last page of survey)?

4) Maybe we should use fadeIn() and fadeOut() for the warnings. I find show() and hide() to be quite abrupt.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)2.54.3 (answers_html branch)
I will donate to the project if issue is resolvedNo
BrowserN/A
Database type & versionN/A
Server OS (if known)N/A
Webserver software & version (if known)N/A
PHP VersionN/A

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-10-15 11:31

developer   ~41369

Hi Tony:

1) The countdown is not reset when using /newtest/Y/ in the URL: no it's the desired behaviour : time is set in cookie.
2) Can you test if if not the same in master ?
3) Must be (and easy) : master don't disable it too :)
4) Use a function for this : allow update in template.js. In fact : i use a lot more 'class update' now , with just some transition in CSS : https://github.com/SondagesPro/skeletonquest/blob/master/jquery-ui-custom.css#L1272

Think i update to use addClass("ls-hidden") (to be more framework agnostic)

DenisChenu

DenisChenu

2016-10-16 16:27

developer   ~41379

Fix committed to answers_html branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21041

DenisChenu

DenisChenu

2016-10-16 16:29

developer   ~41382

Last edited: 2016-10-16 16:30

1: leave like 2.06 and older
4 : usage oif transition

Example :
.ls-timer-content{-webkit-transition: all 1000ms linear; transition: all 1000ms linear;}
.ls-timer-content{
height:auto;
}
.hidden.ls-timer-content{
height:0;margin:0;padding:0;box-sizing:border-box;
overflow:hidden;
display:block !important;
}

c_schmitz

c_schmitz

2017-07-21 17:07

administrator   ~44129

Version 3.0.0-beta.1 released

Related Changesets

LimeSurvey: answers_html 8b977014

2016-10-16 16:25:01

DenisChenu

Details Diff
Fixed issue 11800 : time limit expiry message + disable submit
Fixed issue 11795 : superfluous class .col-xs-12 in timer
Dev : for 11800 : use css transition
Affected Issues
11795, 11800
mod - application/controllers/survey/index.php Diff File
mod - application/core/packages/limesurvey/survey.css Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - application/views/survey/question_timer/timer_content.php Diff File
mod - application/views/survey/question_timer/timer_footer.php Diff File
mod - application/views/survey/question_timer/timer_header.php Diff File
mod - application/views/survey/question_timer/timer_javascript.php Diff File
add - scripts/timer.js Diff File

Issue History

Date Modified Username Field Change
2016-10-14 15:43 tpartner New Issue
2016-10-14 15:43 tpartner Status new => assigned
2016-10-14 15:43 tpartner Assigned To => DenisChenu
2016-10-15 11:31 DenisChenu Note Added: 41369
2016-10-16 16:27 DenisChenu Changeset attached => LimeSurvey answers_html 8b977014
2016-10-16 16:27 DenisChenu Note Added: 41379
2016-10-16 16:27 DenisChenu Resolution open => fixed
2016-10-16 16:29 DenisChenu Status assigned => resolved
2016-10-16 16:29 DenisChenu Fixed in Version => 3.0.x
2016-10-16 16:29 DenisChenu Note Added: 41382
2016-10-16 16:29 DenisChenu Status resolved => feedback
2016-10-16 16:29 DenisChenu Resolution fixed => reopened
2016-10-16 16:30 DenisChenu Note Edited: 41382
2016-10-16 16:30 DenisChenu Status feedback => resolved
2016-10-16 16:30 DenisChenu Resolution reopened => fixed
2016-10-16 16:30 DenisChenu Target Version 2.55.x => 3.0
2017-07-21 17:07 c_schmitz Note Added: 44129
2017-07-21 17:07 c_schmitz Status resolved => closed