View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
11779Bug reportsSurvey editingpublic2016-10-11 19:082017-07-21 17:08
Reportertammo Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.53 
Summary11779: 2.54 Ranking question different styling
Description

The ranking question suffers from different styling (border-radius, border-width, border-color) from other inputs.

It also has double padding on the right side.

Panels are of different height

Steps To Reproduce

Default template

TagsNo tags attached.
Attached Files
ranking.png (36,678 bytes)   
ranking.png (36,678 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)2.54 GIT
I will donate to the project if issue is resolvedNo
Browser
Database type & versionnn
Server OS (if known)nn
Webserver software & version (if known)nn
PHP Versionnn

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-10-12 12:21

developer   ~41260

And in answers_html ?

You want to remove .list-group-item and .list-group ?

Hard to remove ui-sortable without hacking jqueryui i think.

I can have a look.

For height : seems a miscalculation in the javascript : i can fix it (take outerHeight surely)
tammo

tammo

2016-10-12 12:24

developer   ~41261

Only remove them if it does not break anything. I believe they are not needed in het CSS. Not sure now... Have to go...
DenisChenu

DenisChenu

2016-10-12 12:46

developer   ~41266

It's just to have a default part from the framework :)

But you're rigfht : we can only remove it : ranking.css offer core css without any framework.

I minimalize a little ranking.css
DenisChenu

DenisChenu

2016-10-15 15:40

developer   ~41374

Fix committed to answers_html branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21031
DenisChenu

DenisChenu

2016-10-15 15:41

developer   ~41375

Fixed actually for the class. Unsure for "core class" : but we need some border i think.
c_schmitz

c_schmitz

2017-07-21 17:08

administrator   ~44183

Version 3.0.0-beta.1 released

Related Changesets

LimeSurvey: answers_html c6ccf7b5

2016-10-15 17:38

DenisChenu


Details Diff		 Fixed issue 11779: Ranking question different styling
Dev: height are really hard to fix : We need a margin bottom
Dev: set the height fix the issue with border-box
Dev: BUT border-box is not apply when using min-height
Dec: We CAN NOT use height : some element can be hidden : then the list can be bigger with array filtering after		 Affected Issues
11779
mod - application/helpers/qanda_helper.php Diff File
mod - application/views/survey/questions/ranking/answer.php Diff File
mod - scripts/ranking.js Diff File
mod - styles-public/ranking.css Diff File

Issue History

Date Modified Username Field Change
2016-10-11 19:08 tammo New Issue
2016-10-11 19:08 tammo File Added: ranking.png
2016-10-12 12:06 ollehar Assigned To => DenisChenu
2016-10-12 12:06 ollehar Status new => assigned
2016-10-12 12:21 DenisChenu Note Added: 41260
2016-10-12 12:24 tammo Note Added: 41261
2016-10-12 12:46 DenisChenu Note Added: 41266
2016-10-15 15:40 DenisChenu Changeset attached => LimeSurvey answers_html c6ccf7b5
2016-10-15 15:40 DenisChenu Note Added: 41374
2016-10-15 15:40 DenisChenu Resolution open => fixed
2016-10-15 15:41 DenisChenu Status assigned => resolved
2016-10-15 15:41 DenisChenu Fixed in Version => 3.0
2016-10-15 15:41 DenisChenu Note Added: 41375
2017-07-21 17:08 c_schmitz Note Added: 44183
2017-07-21 17:08 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing