View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
11765Bug reportsData Entry (non public)public2016-10-08 20:072016-10-14 10:24
Reporteraesteban Assigned Toollehar  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.52.x 
Fixed in Version2.54 
Summary11765: Admin data entry doesn't work if survey has restricted access
Description

If survey has restricted access (i.e. admin has to enter a token) the data entry window doesn't work. "Save" and "Save and Close" button do nothing when clicking them.

Steps To Reproduce

1.- Create a restricted access survey
2.- In admin panel, go to survey -> responses -> data entry
3.- Fill in the token and responses

Result: Nothing happens

Additional Information

It seems to work when survey is public

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)2.52+160929
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionPostgres 9.4.8
Server OS (if known)Debian 8 Jessie
Webserver software & version (if known)nginx 1.6.2
PHP Version5.6.26

Users monitoring this issue

There are no users monitoring this issue.

Activities

aesteban

aesteban

2016-10-09 01:16

developer   ~41205

It works in 2.06LTS. In 206LTS, the button is disabled when the page is loaded and enabled when user enter the token. In 2.5 the button is always disabled.

I tried to enable the button with this patch:

diff --git a/application/views/admin/dataentry/active_html_view.php b/application/views/admin/dataentry/active_html_view.php
index d9e3817..85cef35 100644
--- a/application/views/admin/dataentry/active_html_view.php
+++ b/application/views/admin/dataentry/active_html_view.php
@@ -71,14 +71,7 @@ if ($thissurvey['active'] == "Y")
<td colspan='3' align='center'>
<input type='submit' id='submitdata' class="btn btn-default hidden" value='<?php eT("Submit"); ?>'

  • <?php if (tableExists('tokens_'.$thissurvey['sid']))
  • { ?>
  • disabled='disabled'/>
  • <?php }
  • else
  • { ?>
    />
  • <?php } ?>
    </td>
    </tr>
    <?php }

but another error raises if token is empty.
DenisChenu

DenisChenu

2016-10-11 00:11

developer   ~41222

In fact : why force token set ?

Start a survey
Enter some answers
Activate token
Deactivate token
etc ....

Maybe best : allow empty token here :)
ollehar

ollehar

2016-10-13 12:59

administrator   ~41293

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=20994
ollehar

ollehar

2016-10-13 14:30

administrator   ~41302

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=20995
c_schmitz

c_schmitz

2016-10-14 10:24

administrator   ~41332

Version 2.54.3 Build 161014 released

Related Changesets

LimeSurvey: master a7e0537b

2016-10-13 12:58:59

ollehar

Details Diff 		Fixed issue 11765: Admin data entry doesn't work if survey has restricted access Affected Issues
11765
mod - application/views/admin/dataentry/active_html_view.php Diff File
mod - application/views/admin/dataentry/caption_view.php Diff File
mod - application/views/admin/dataentry/includes/editdata/editdata.php Diff File

LimeSurvey: master 476e78da

2016-10-13 13:11:05

ollehar

Details Diff 		Fixed issue 11765: Admin data entry doesn't work if survey has restricted access Affected Issues
11765
mod - application/controllers/admin/dataentry.php Diff File
mod - application/views/admin/dataentry/insert.php Diff File

Issue History

Date Modified Username Field Change
2016-10-08 20:07 aesteban New Issue
2016-10-09 01:16 aesteban Note Added: 41205
2016-10-11 00:11 DenisChenu Note Added: 41222
2016-10-13 11:44 ollehar Assigned To => ollehar
2016-10-13 11:44 ollehar Status new => assigned
2016-10-13 12:59 ollehar Changeset attached => LimeSurvey master a7e0537b
2016-10-13 12:59 ollehar Note Added: 41293
2016-10-13 12:59 ollehar Resolution open => fixed
2016-10-13 14:28 ollehar Status assigned => resolved
2016-10-13 14:28 ollehar Fixed in Version => 2.54
2016-10-13 14:30 ollehar Changeset attached => LimeSurvey master 476e78da
2016-10-13 14:30 ollehar Note Added: 41302
2016-10-14 10:24 c_schmitz Note Added: 41332
2016-10-14 10:24 c_schmitz Status resolved => closed