View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
11752Feature requestsSurvey editingpublic2016-10-14 10:28
ReporterDenisChenu Assigned Tomarkusfluer 
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Summary11752: Review 5 point choice "emoji" and "5 stars"
Description

This javascripot is old, and the look is oldy .

Think must be updated

Additional Information

But : who use it ? Can easily be done in plugin.

TagsNo tags attached.
Attached Files
Bug heat8
Story point estimate
Users affected %

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2016-10-06 10:35

developer   ~41159

The core question should be updated. In advanced options, it should be possible to upload different pictures for the emoticons.

DenisChenu

DenisChenu

2016-10-06 10:59

developer   ~41160

Emoticon from FontAwesome by default ?

ELse : we can already fix partially the html for JS to use boostrap class

LouisGac

LouisGac

2016-10-06 11:05

developer   ~41161

ok, seems a good idea to do it asap

DenisChenu

DenisChenu

2016-10-11 14:53

developer   ~41228

There are only one emoticon in FontAwesome .... :snif:

pmonstad

pmonstad

2016-10-11 16:11

updater   ~41230

Denis, you are right. There is only one emoticon in FontAwsome. But there are a lot of other nice icons there. Could a smiley font be included in addition to FontAwsome?

DenisChenu

DenisChenu

2016-10-11 16:18

developer   ~41231

Last edited: 2016-10-11 16:25

We have 3 emote in FA.

In a not out plugin : i use image:
http://demonstration.sondages.pro/plugins/sliderEmote/assets/1.png
http://demonstration.sondages.pro/plugins/sliderEmote/assets/2.png

.. release and put the link here in some minute

https://framagit.org/SondagePro-LimeSurvey-plugin/sliderEmote/tree/master

markusfluer

markusfluer

2016-10-11 17:21

administrator   ~41233

Maybe better to use svg?
We can even adapt it for 10- or 7-point question then

DenisChenu

DenisChenu

2016-10-11 17:24

developer   ~41234

SVG : yes .

Adapatation is not answers_html point : but do it if you want ;)

I already have a plugin for that :https://framagit.org/SondagePro-LimeSurvey-plugin/radioToStarRating (star only)

Just a registerScript

markusfluer

markusfluer

2016-10-12 11:40

administrator   ~41251

Fixed with commit a4f468cc

markusfluer

markusfluer

2016-10-12 11:40

administrator   ~41253

https://github.com/LimeSurvey/LimeSurvey/commit/a4f468cc27084d74748ca6bfca884b40a26ed266

DenisChenu

DenisChenu

2016-10-12 12:10

developer   ~41256

Sorry : i'm unclear .

I talk about the 2 slider_rating options : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/questionHelper.php#L890

Stars + Slider with emoticon

Stars is done, not emoticon ;).

And : sure to be in 2.5X ? You think it's not a breaker API fix (template API) ?

DenisChenu

DenisChenu

2016-10-12 15:25

developer   ~41272

Last edited: 2016-10-12 15:26

Another issue: mandatory radio star show 4 stars only (1 to 4).

See included lss file + http://testing.sondages.pro/masterall/index.php/89495/newtest/Y

PS: maybe time to add a "reset" to emoticon slider too :)

markusfluer

markusfluer

2016-10-12 16:33

administrator   ~41276

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20976

markusfluer

markusfluer

2016-10-12 16:35

administrator   ~41277

Emoji-slider: 11788

markusfluer

markusfluer

2016-10-12 16:36

administrator   ~41278

I will fix the emoji slider in a different branch
it is more complicated, though i may have to insert a new font

Related Changesets

LimeSurvey: master 3bb2c265

2016-10-12 16:33:03

markusfluer

Details Diff
Fixed issue 11752: mandatory radio star show 4 stars only Affected Issues
11752
mod - scripts/star-rating.js Diff File

Issue History

Date Modified Username Field Change
2016-10-05 19:29 DenisChenu New Issue
2016-10-05 19:29 DenisChenu File Added: Capture du 2016-10-05 19-13-28.png
2016-10-05 19:30 DenisChenu Tag Attached: answers_html
2016-10-06 10:35 LouisGac Note Added: 41159
2016-10-06 10:59 DenisChenu Note Added: 41160
2016-10-06 11:05 LouisGac Note Added: 41161
2016-10-11 14:53 DenisChenu Note Added: 41228
2016-10-11 15:10 LouisGac Assigned To => markusfluer
2016-10-11 15:10 LouisGac Status new => assigned
2016-10-11 16:11 pmonstad Note Added: 41230
2016-10-11 16:18 DenisChenu Note Added: 41231
2016-10-11 16:25 DenisChenu Note Edited: 41231
2016-10-11 17:21 markusfluer Note Added: 41233
2016-10-11 17:24 DenisChenu Note Added: 41234
2016-10-12 11:40 markusfluer Note Added: 41251
2016-10-12 11:40 markusfluer Status assigned => resolved
2016-10-12 11:40 markusfluer Resolution open => fixed
2016-10-12 11:40 markusfluer Fixed in Version => 2.5+
2016-10-12 11:40 markusfluer Note Added: 41253
2016-10-12 12:10 DenisChenu Status resolved => feedback
2016-10-12 12:10 DenisChenu Resolution fixed => reopened
2016-10-12 12:10 DenisChenu Note Added: 41256
2016-10-12 15:24 DenisChenu File Added: limesurvey_survey_5radio.lss
2016-10-12 15:25 DenisChenu Note Added: 41272
2016-10-12 15:25 DenisChenu Status feedback => assigned
2016-10-12 15:26 DenisChenu Note Edited: 41272
2016-10-12 16:33 markusfluer Changeset attached => LimeSurvey master 3bb2c265
2016-10-12 16:33 markusfluer Note Added: 41276
2016-10-12 16:35 markusfluer Note Added: 41277
2016-10-12 16:36 markusfluer Note Added: 41278
2016-10-12 16:36 markusfluer Status assigned => resolved
2016-10-12 16:36 markusfluer Resolution reopened => fixed
2016-10-14 10:28 c_schmitz Tag Detached: answers_html
2016-10-14 10:28 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing