View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
11736Bug reportsExpression Managerpublic2016-10-04 17:11
Reporterteracomp Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.52.x 
Fixed in Version2.52.x 
Summary11736: Uncaught ReferenceError: Decimal is not defined
Description

em_javascript.js:753 (and throughout)
Chrome & Safari browsers on Mac OS X halts execution because of this declaration:
var decimal_safe = new Decimal(value);

Steps To Reproduce

Looking at Expression Manager sample. Won't run because of the exception.
/limesurvey/index.php/admin/expressions/sa/relevance

TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build)Version 2.51.4+160908
I will donate to the project if issue is resolvedNo
BrowserChrome and Safari
Database type & versionMySql, 5.6.33
Server OS (if known)Linux
Webserver software & version (if known)Apache 2.4.23
PHP Version5.6.24

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-10-02 16:13

developer   ~41053

Can youy upload a litlle lss file for testing and reproduce purpose :)

teracomp

teracomp

2016-10-02 19:11

reporter   ~41054

I don't have an lss file to upload because I'm still trying to learn how to build surveys with EM.

I'm actually referring the an internal file that ships with Lime Survey. The link is from the source: /limesurvey/index.php/admin/expressions/sa/relevance when it refers to em_javascript.js.

DenisChenu

DenisChenu

2016-10-03 09:06

developer   ~41057

Last edited: 2016-10-03 09:06

OK, got it, please : put more detail on "Steps To Reproduce" :)

teracomp

teracomp

2016-10-03 12:15

reporter   ~41058

Steps to Reproduce:

  1. Login: as LimeSurveys Site Admin
  2. Click: Configuration Tab
  3. Select: Unit test of dynamic relevance processing
    Page opens: http://hgctools.com/limesurvey/index.php/admin/expressions/sa/relevance
    Open Console to inspect interaction
    Complete the form:
  4. [Q0] What is your name?: Dave
  5. [Q1] How Old are you?: 55
  6. Console shows error (attached)
relevance-example-error.jpg (50,747 bytes)   
relevance-example-error.jpg (50,747 bytes)   
mfavetti

mfavetti

2016-10-03 22:29

developer   ~41061

Confirmed

mfavetti

mfavetti

2016-10-03 22:42

developer   ~41062

Ok, problem is the decimal js package is not registered in the controller for this page. I'll submit a PR in a few minutes.

mfavetti

mfavetti

2016-10-03 22:45

developer   ~41063

https://github.com/LimeSurvey/LimeSurvey/pull/548

c_schmitz

c_schmitz

2016-10-04 10:23

administrator   ~41073

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20786

c_schmitz

c_schmitz

2016-10-04 17:11

administrator   ~41110

Version 2.53+161004 released

Related Changesets

LimeSurvey: master 30bed462

2016-10-04 00:44

mfavetti


Details Diff
Fixed issue 11736: Uncaught ReferenceError: Decimal is not defined Affected Issues
11736
mod - application/controllers/admin/expressions.php Diff File

LimeSurvey: master 94e62959

2016-10-04 12:23

c_schmitz

Committer: GitHub


Details Diff
Merge pull request #548 from mfavetti/issue11736

Fixed issue 11736: Uncaught ReferenceError: Decimal is not defined
Affected Issues
11736
mod - application/controllers/admin/expressions.php Diff File

Issue History

Date Modified Username Field Change
2016-10-01 23:53 teracomp New Issue
2016-10-02 16:13 DenisChenu Note Added: 41053
2016-10-02 19:11 teracomp Note Added: 41054
2016-10-03 09:06 DenisChenu Note Added: 41057
2016-10-03 09:06 DenisChenu Note Edited: 41057
2016-10-03 09:07 DenisChenu File Added: Capture du 2016-10-03 09-06-05.png
2016-10-03 12:15 teracomp File Added: relevance-example-error.jpg
2016-10-03 12:15 teracomp Note Added: 41058
2016-10-03 22:29 mfavetti Note Added: 41061
2016-10-03 22:42 mfavetti Note Added: 41062
2016-10-03 22:45 mfavetti Note Added: 41063
2016-10-04 10:23 mfavetti Changeset attached => LimeSurvey master 30bed462
2016-10-04 10:23 c_schmitz Changeset attached => LimeSurvey master 94e62959
2016-10-04 10:23 c_schmitz Note Added: 41073
2016-10-04 10:23 c_schmitz Assigned To => c_schmitz
2016-10-04 10:23 c_schmitz Resolution open => fixed
2016-10-04 10:24 c_schmitz Status new => resolved
2016-10-04 10:24 c_schmitz Fixed in Version => 2.52.x
2016-10-04 17:11 c_schmitz Note Added: 41110
2016-10-04 17:11 c_schmitz Status resolved => closed