View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
11691Bug reportsSurvey participants (Tokens)public2016-10-04 17:11
Reporterxksefa Assigned ToDenisChenu  
PrioritynoneSeveritycrash 
Status closedResolutionfixed 
Product Version2.52.x 
Fixed in Version2.52.x 
Summary11691: Can't upload CSV files with valid tokens
Description

Hi,
When I try to upload CSV file which contains firstname,lastname,email and token It says,

1 lines with invalid tokens skipped (tokens may only contain 0-9,a-z,A-Z,_). [List]
Line 1 : Ahmet Nehnet (abc@abc.com) - token : 20020023032

As you see, the token contain numbers only but couldn't create any token.
I tried to create it manually and succeed.
So there is a problem about uploading.

Note that: Token length set to 11 in survey settings.

Steps To Reproduce

Try to upload csv file which contains information like below.
firstname;lastname;email;token
Ahmet;Nehnet;abc@abc.com;20020023032

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)160920
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5.6.31
Server OS (if known)Linux
Webserver software & version (if known)linux
PHP Version5.5.37

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-09-21 08:50

developer   ~40870

Confirmed in last GIT version

DenisChenu

DenisChenu

2016-09-21 08:57

developer   ~40871

Last edited: 2016-09-21 08:59

Really strange ....

tracevar(array(
trim($aWriteArray['token']),
sanitize_token($aWriteArray['token']),
trim($aWriteArray['token']) != sanitize_token($aWriteArray['token'])
));

Result:
./LimeSurvey/application/controllers/admin/tokens.php
(2195):
array
(
0 => '20020023032'
1 => '20020023032'
2 => false
)

Something i don't understand here .... X-Files ?

==== got it :
if (trim($aWriteArray['token']) != sanitize_token($aWriteArray['token']));
{
$aInvalidTokenList[] = sprintf(gT("Line %s : %s %s (%s) - token : %s"),$iRecordCount,CHtml::encode($aWriteArray['firstname']),CHtml::encode($aWriteArray['lastname']),CHtml::encode($aWriteArray['email']),CHtml::encode($aWriteArray['token']));
$bInvalidToken=true;
}

What is this ; ?

DenisChenu

DenisChenu

2016-09-21 09:02

developer   ~40872

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20530

c_schmitz

c_schmitz

2016-10-04 17:11

administrator   ~41120

Version 2.53+161004 released

Related Changesets

LimeSurvey: master 98736279

2016-09-19 14:03:39

c_schmitz

Details Diff
Fixed issue: Tokens are silently sanitized on import - should be skipped instead with proper error message in import summary Affected Issues
11691
mod - application/views/admin/token/csvimportresult.php Diff File

LimeSurvey: master b0e61ac2

2016-09-21 09:01:55

DenisChenu

Details Diff
Fixed issue 11691: Can't upload CSV files with valid tokens
Dev: remove the ; typo
Affected Issues
11691
mod - application/controllers/admin/tokens.php Diff File

Issue History

Date Modified Username Field Change
2016-09-21 08:36 xksefa New Issue
2016-09-21 08:50 DenisChenu Note Added: 40870
2016-09-21 08:50 DenisChenu Assigned To => c_schmitz
2016-09-21 08:50 DenisChenu Status new => assigned
2016-09-21 08:51 DenisChenu Changeset attached => LimeSurvey master 98736279
2016-09-21 08:57 DenisChenu Note Added: 40871
2016-09-21 08:59 DenisChenu Note Edited: 40871
2016-09-21 09:02 DenisChenu Changeset attached => LimeSurvey master b0e61ac2
2016-09-21 09:02 DenisChenu Note Added: 40872
2016-09-21 09:02 DenisChenu Assigned To c_schmitz => DenisChenu
2016-09-21 09:02 DenisChenu Resolution open => fixed
2016-09-21 09:03 DenisChenu Status assigned => resolved
2016-09-21 09:03 DenisChenu Fixed in Version => 2.52.x
2016-10-04 17:11 c_schmitz Note Added: 41120
2016-10-04 17:11 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)