View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11633 | Bug reports | Survey participants (Tokens) | public | 2016-09-07 10:12 | 2016-09-08 12:27 |
Reporter | Mazi | Assigned To | |||
Priority | urgent | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.51.x | ||||
Target Version | 2.51.x | Fixed in Version | 2.52.x | ||
Summary | 11633: User can access closed surveys of no tokens were generated | ||||
Description | Users are currently able to access closed surveys even though a token table was set up and token data sets were added. | ||||
Steps To Reproduce |
| ||||
Additional Information | Please remove attached test survey before making this report public | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 160907 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL 5 | ||||
Server OS (if known) | Linux | ||||
Webserver software & version (if known) | Apache 2 | ||||
PHP Version | 5.5 | ||||
How and when did you create the token table? If I delete and re-create it, it works again. |
|
This commit is to blame: https://github.com/LimeSurvey/LimeSurvey/commit/f5606a3ac2a0f72dd0f0470ad14ddf1031d76b51 |
|
But it's not possible to revert it because |
|
Olle, the token table was created during survey creation. But even if I de-activate the survey, then activate again and during activation decide to use tokens and then loading the old, backed up token table, I can still enter the survey without being asked for a token. Thus, I assume the token check somehow fails. Maybe it checks if the not existing token is empty...? |
|
Actually this only seems to happen if none of the participants have a token code. |
|
After closer examination i could reproduce the bug. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20420 |
|
Version 2.51.4 released. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-09-07 10:12 | Mazi | New Issue | |
2016-09-07 10:12 | Mazi | File Added: survey_archive_292873.lsa | |
2016-09-07 10:13 | c_schmitz | View Status | public => private |
2016-09-07 10:21 | ollehar | Note Added: 40704 | |
2016-09-07 10:54 | ollehar | Note Added: 40705 | |
2016-09-07 10:55 | ollehar | Note Added: 40706 | |
2016-09-07 12:08 | Mazi | Note Added: 40707 | |
2016-09-07 12:43 | c_schmitz | Note Added: 40709 | |
2016-09-07 12:43 | c_schmitz | Priority | none => urgent |
2016-09-07 12:44 | c_schmitz | Assigned To | => markusfluer |
2016-09-07 12:44 | c_schmitz | Status | new => assigned |
2016-09-07 12:44 | c_schmitz | File Deleted: survey_archive_292873.lsa | |
2016-09-07 12:44 | c_schmitz | View Status | private => public |
2016-09-07 12:56 |
|
Note Added: 40710 | |
2016-09-07 12:56 |
|
Changeset attached | => LimeSurvey master 37f60ab6 |
2016-09-07 12:56 |
|
Note Added: 40711 | |
2016-09-07 12:56 |
|
Resolution | open => fixed |
2016-09-07 12:57 |
|
Note Edited: 40710 | |
2016-09-07 12:57 |
|
Status | assigned => resolved |
2016-09-07 12:57 |
|
Fixed in Version | => 2.52.x |
2016-09-08 12:27 | c_schmitz | Note Added: 40731 | |
2016-09-08 12:27 | c_schmitz | Status | resolved => closed |
2016-12-08 10:39 | c_schmitz | Category | Tokens => Survey participants (Tokens) |