View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
11502Bug reportsData Entry (non public)public2016-07-26 19:382016-08-01 14:15
Reportermmartinwechu Assigned Tomarkusfluer 
PriorityimmediateSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11502: Popup editor does not launch. Error in DOM naming
Description

When clicking on the editor the error

13:34:07.302 TypeError: document.getElementsByName(...)[0] is undefined
start_popup_editor() 97:1178
<anonymous> /:1
1 97:1178:13

is logged. The naming of the fields is incorrect and it cannot be found in the document.

The text field is id="answer_en_2_0" but the call is using the QID to find the element - answer_en_97_0

javascript:start_popup_editor('answer_en_97_0','Subquestion:','756986','11','97','editanswer','editanswer')

The call to start_popup_editor is wrong

Steps To Reproduce

Create a question
Save the question
Try to edit the question

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)160727
I will donate to the project if issue is resolvedNo
BrowserFirefox, ie and chrome
Database type & versionMariadb 10.1
Server OS (if known)Cenots 7
Webserver software & version (if known)Apache 2.4
PHP Version5.6.23

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-07-26 21:13

developer   ~40064

Last edited: 2016-07-26 21:14

All this popup editor must be rewrite in jquery + move in own external file and use data- etc ....

But i can not confirm issue with Question .....

BUT : i confirm with ANSWERS edition (dor single choice for example)
mmartinwechu

mmartinwechu

2016-07-27 21:20

reporter   ~40086

You are correct. Im sorry - I meant to say ANSWERS not questions.
Is this fix in the road map?
markusfluer

markusfluer

2016-07-28 16:48

administrator   ~40101

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19848
mmartinwechu

mmartinwechu

2016-07-28 18:03

reporter   ~40104

I don't use postgre and changed my local application/core/Survey_Common_Action.php with the diff from the commit you made.

It doesnt seem to make any difference to the issue I reported.

Was there other files affected?
markusfluer

markusfluer

2016-07-28 18:44

administrator   ~40105

Yes, there should be a release today.
There where multiple bugs fixed in the admin/subquestions.js and admin/answer.js
c_schmitz

c_schmitz

2016-08-01 14:15

administrator   ~40136

Version 2.50 Build 160731 released

Related Changesets

LimeSurvey: master 480939a5

2016-07-28 16:14

markusfluer


Details Diff		 Fixed issue 11502: Popup editor does not launch. Error in DOM naming
Fixed issue: Problem with inserting new subquestions in a postgresql environment.
Dev: Added a check to prevent non-numeric id-values to be checked against the database to prevent postgresql type errors		 Affected Issues
11502
mod - application/core/Survey_Common_Action.php Diff File

Issue History

Date Modified Username Field Change
2016-07-26 19:38 mmartinwechu New Issue
2016-07-26 21:13 DenisChenu Note Added: 40064
2016-07-26 21:14 DenisChenu Note Edited: 40064
2016-07-27 08:22 c_schmitz Priority none => immediate
2016-07-27 21:20 mmartinwechu Note Added: 40086
2016-07-28 15:05 c_schmitz Assigned To => markusfluer
2016-07-28 15:05 c_schmitz Status new => assigned
2016-07-28 16:48 markusfluer Changeset attached => LimeSurvey master 480939a5
2016-07-28 16:48 markusfluer Note Added: 40101
2016-07-28 16:48 markusfluer Resolution open => fixed
2016-07-28 16:48 markusfluer Status assigned => resolved
2016-07-28 16:48 markusfluer Fixed in Version => 2.5
2016-07-28 18:03 mmartinwechu Note Added: 40104
2016-07-28 18:44 markusfluer Note Added: 40105
2016-08-01 14:15 c_schmitz Note Added: 40136
2016-08-01 14:15 c_schmitz Status resolved => closed