View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
11494Bug reportsSurvey takingpublic2016-07-25 19:462016-08-01 14:15
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11494: NANS cpode for single radio break HTML
Description

If you add a answer with code NANS : this break HTML validirty + break selection of "No answer"

Steps To Reproduce

Import included survey, test it : look at HTML

Additional Information

There are 2 radio with same id answer{SGQ}NANS

2 solutions :

  • Disallow NANS for answer
  • Use a code longer than 5 characters
  • Don't add any code (in Fact No answer have value=="")

We have the same issue in 2.06. I dooooooon't control multiple question type.
For Y/N or List withc comment : we use directly answer{SGQ} for no answer: It's logic : answer{SGQ}{valueOfAnswer}

TagsNo tags attached.
Attached Files
limesurvey_survey_NANSbug.lss (13,030 bytes)
Bug heat4
Complete LimeSurvey version number (& build)20160725
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-07-26 11:10

administrator   ~40054

Just disallow NANS as code ;)
DenisChenu

DenisChenu

2016-07-26 11:28

developer   ~40055

I really think using same system than "List with comment" is OK.

In fact : there are no reason to use NANS ? If there are a reason : we need to fix the other answer id (Yes/No - List with comments - Gender etc ....)
DenisChenu

DenisChenu

2016-07-26 18:38

developer   ~40062

extensions/questionTypes/listRadio/listRadio.php: $answer .= ' <label for="answer'.$ia[1].'NANS" class="answertext control-label">'.gT('No answer').'</label>';
extensions/questionTypes/listRadio/listRadio.php: $answer .= ' <input class="radio" type="radio" name="'.$ia[1].'" id="answer'.$ia[1].'NANS" value=""'.$check_ans.' onclick="if (document.getElementById(\'answer'.$ia[1].'othertext\') != null) document.getElementById(\'answer'.$ia[1].'othertext\').value=\'\';'.$checkconditionFunction.'(this.value, this.name, this.type)" />';
helpers/qanda_helper.php: 'id' => $ia[1].'NANS',
helpers/expressions/em_manager_helper.php: // DETECT WHETHER QUESTION SHOULD BE FLAGGED AS UNANSWERED //
helpers/expressions/em_manager_helper.php: $relParts[] = " $('#answer" . $sq['sgqa'] . "NANS').attr('checked',true);\n";
views/admin/templates/templateeditor_question_answer_view.php: id="answer319974X233X4277NANS"
views/admin/templates/templateeditor_question_answer_view.php: aria-labelledby="label-answer319974X233X4277NANS"
views/admin/templates/templateeditor_question_answer_view.php: <label for="answer319974X233X4277NANS" class="answertext control-label label-radio"></label>
views/admin/templates/templateeditor_question_answer_view.php: <div class="label-text label-clickable" id="label-answer319974X233X4277NANS">
views/survey/questions/listradio/rows/answer_row_noanswer.php: id="answer<?php echo $name; ?>NANS"
views/survey/questions/listradio/rows/answer_row_noanswer.php: aria-labelledby="label-answer<?php echo $name; ?>NANS"
views/survey/questions/listradio/rows/answer_row_noanswer.php: <label for="answer<?php echo $name; ?>NANS" class="answertext control-label label-radio"></label>
views/survey/questions/listradio/rows/answer_row_noanswer.php: <div class="label-text label-clickable" id="label-answer<?php echo $name; ?>NANS">

Musr control em mangare helper BUT if it work for Y/N , it miust work the same way for List radio
DenisChenu

DenisChenu

2016-07-26 21:37

developer   ~40065

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19790
c_schmitz

c_schmitz

2016-08-01 14:15

administrator   ~40141

Version 2.50 Build 160731 released

Related Changesets

LimeSurvey: master 2c293f02

2016-07-26 21:37

DenisChenu


Details Diff		 Fixed issue 11494: NANS code for single radio break HTML
Dev: remove NANS and leave empty string (the answer value in gact, like other radio button)
Dev: same for other radio select, or array ( SGQ- for no answer)		 Affected Issues
11494
mod - application/extensions/questionTypes/listRadio/listRadio.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - application/views/admin/templates/templateeditor_question_answer_view.php Diff File
mod - application/views/survey/questions/listradio/rows/answer_row_noanswer.php Diff File

Issue History

Date Modified Username Field Change
2016-07-25 19:46 DenisChenu New Issue
2016-07-25 19:48 DenisChenu File Added: limesurvey_survey_NANSbug.lss
2016-07-26 10:44 c_schmitz Priority none => normal
2016-07-26 11:10 c_schmitz Note Added: 40054
2016-07-26 11:28 DenisChenu Note Added: 40055
2016-07-26 11:28 DenisChenu Assigned To => DenisChenu
2016-07-26 11:28 DenisChenu Status new => assigned
2016-07-26 18:38 DenisChenu Note Added: 40062
2016-07-26 21:37 DenisChenu Changeset attached => LimeSurvey master 2c293f02
2016-07-26 21:37 DenisChenu Note Added: 40065
2016-07-26 21:37 DenisChenu Resolution open => fixed
2016-07-26 21:38 DenisChenu Status assigned => resolved
2016-07-26 21:38 DenisChenu Fixed in Version => 2.5
2016-08-01 14:15 c_schmitz Note Added: 40141
2016-08-01 14:15 c_schmitz Status resolved => closed