View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11448 | Bug reports | Theme editor | public | 2016-07-14 12:03 | 2017-07-21 17:07 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.50.x | ||||
Target Version | 3.0.x | Fixed in Version | 3.0.x | ||
Summary | 11448: Unable to show list radio as button without JS | ||||
Description | In 2.06 and before : we can show label as button : using some css : li.radio-item input.radio:checked + label, li.checkbox-item input.checkbox:checked + label { example here : http://accessible.sondages.pro/89495 It's not possible actually : we have an empty label : then we can not access the background color of the real label. | ||||
Steps To Reproduce | Try to set a background color on :radio .label-clickable without javascript | ||||
Additional Information | Css speed is better than JS There are really no reason to add an empty element .... except using awesome-bootstrap-checkbox without updating it (we already update a lot of think). ANd more : awesome-bootstrap-checkbox can broke some survey (see https://bugs.limesurvey.org/view.php?id=11425 : fonts not loaded : broken system, and fonts are not loaded when user goes with a Phone connexion ....) | ||||
Tags | answers_html | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 20160714 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | All | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 11425 | closed | Bug reports | Opera mobile : checkbox are not showned checked | |
related to | 11463 | closed | DenisChenu | Bug reports | Unable to vertical align Radio button without javascript |
related to | 11449 | closed | DenisChenu | Feature requests | Readding real label |
yes the logic is different, it use bootstrap awesome checkboxes: You can change it background color (it's yet different in the 3 core templates). The empty label is because in LimeSurvey Admin interface, you can enter whatever you want in the question label : text, pictures, div, table, etc. So we can't push that content inside an inline element. Having an empty label doesn't any problem. |
|
The empty label broke all CSS system : you can not have a clean way to I try this morning : really no clean way ..... due toi empty label. |
|
When i want to change bg color : Send screenshit : able to do it in 2.06, not able to do it in 2.50 |
|
yes, you can do it: |
|
No : BACKGROUND of whole "answer" part ..... not only the "radio" |
|
Example : set disable option : your example show text grey. Not in LimeSurvey : because it apply to label , not after .... |
|
In fact : tehre are 2 solutions: 1 : Do or fix awesome-bootstrap-checkbox-css with .label-clickable and remove the empty label |
|
removing the empty label is not related to being able to change the background of anything. |
|
Mais si : li.radio-item input.radio:checked + label, li.checkbox-item input.checkbox:checked + label { li.radio-item input.radio:checked + .label-clickable, li.checkbox-item input.checkbox:checked + .label-clickable { Second solution work if you remove the empty label ..... |
|
Louis : i can do the pull request :
BUT : i don't want to work without your agreement on one or other of the methods The only alternative is
Because really : this empty label broke a lot of css things. |
|
Can be done now |
|
Version 3.0.0-beta.1 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-07-14 12:03 | DenisChenu | New Issue | |
2016-07-14 12:14 | DenisChenu | Relationship added | related to 11449 |
2016-07-14 12:14 | DenisChenu | Relationship added | related to 11425 |
2016-07-14 15:47 |
|
Note Added: 39898 | |
2016-07-14 15:47 |
|
Status | new => resolved |
2016-07-14 15:47 |
|
Resolution | open => no change required |
2016-07-14 15:47 |
|
Assigned To | => LouisGac |
2016-07-14 15:51 | DenisChenu | Note Added: 39900 | |
2016-07-14 15:51 | DenisChenu | Status | resolved => feedback |
2016-07-14 15:51 | DenisChenu | Resolution | no change required => reopened |
2016-07-14 15:54 | DenisChenu | File Added: Capture du 2016-07-14 15-53-28.png | |
2016-07-14 15:54 | DenisChenu | File Added: Focused.png | |
2016-07-14 15:55 | DenisChenu | Note Added: 39901 | |
2016-07-14 15:55 | DenisChenu | Status | feedback => assigned |
2016-07-14 15:58 |
|
Note Added: 39903 | |
2016-07-14 15:58 |
|
Assigned To | LouisGac => |
2016-07-14 16:00 | DenisChenu | Note Added: 39906 | |
2016-07-14 16:01 | DenisChenu | Note Edited: 39906 | |
2016-07-14 16:04 | DenisChenu | Note Added: 39907 | |
2016-07-14 16:04 | DenisChenu | File Added: Capture du 2016-07-14 16-03-47.png | |
2016-07-14 16:06 | DenisChenu | Note Added: 39908 | |
2016-07-14 16:06 | DenisChenu | Status | assigned => new |
2016-07-14 16:08 |
|
Note Added: 39912 | |
2016-07-14 16:09 | DenisChenu | Note Added: 39914 | |
2016-07-18 09:23 | DenisChenu | Note Added: 39937 | |
2016-07-18 09:23 | DenisChenu | Assigned To | => LouisGac |
2016-07-18 09:23 | DenisChenu | Status | new => feedback |
2016-07-18 09:23 | DenisChenu | Relationship added | related to 11463 |
2016-07-28 16:53 | DenisChenu | Assigned To | LouisGac => DenisChenu |
2016-07-28 16:53 | DenisChenu | Status | feedback => assigned |
2016-10-04 18:43 | DenisChenu | Target Version | => 3.0.x |
2016-10-05 10:26 | DenisChenu | Tag Attached: answers_html | |
2016-10-07 18:31 | DenisChenu | Status | assigned => resolved |
2016-10-07 18:31 | DenisChenu | Resolution | reopened => fixed |
2016-10-07 18:31 | DenisChenu | Fixed in Version | => 3.0.x |
2016-10-07 18:31 | DenisChenu | Note Added: 41201 | |
2017-07-21 17:07 | c_schmitz | Note Added: 44134 | |
2017-07-21 17:07 | c_schmitz | Status | resolved => closed |