View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
11391Bug reportsSurvey editingpublic2016-08-12 14:53
Reporterpmonstad Assigned Toc_schmitz  
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11391: clicking Relevance equation opens a new tab
Description

I'm not sure what the expected behavior is to be, but when I click the link in Relevance equation the browser opens a new tab with the exact same content. The same happens in 2.06.

When I click the link I belive it has something to do with editing the relevance, but that is not happening. As I said, I'm not sure what the intention is to be here...

TagsNo tags attached.
Attached Files
Bug heat6
Complete LimeSurvey version number (& build)160616
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionirrelevant
Server OS (if known)irrelevant
Webserver software & version (if known)irrelevant
PHP Versionirrelevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-06-16 09:29

developer   ~39615

In 2.06 : it's a desired behaviour (we open a lot of tab in 2.06), maybe must be different for 2.50 where we don't open a lot of tab.

c_schmitz

c_schmitz

2016-06-17 09:15

administrator   ~39655

Fixed the faulty link - I like it better that it is opened in a new tab.

c_schmitz

c_schmitz

2016-06-17 09:15

administrator   ~39656

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19482

DenisChenu

DenisChenu

2016-06-17 09:30

developer   ~39661

PS : if i don't make error : this can be set by plugin/admin template

https://github.com/LimeSurvey/LimeSurvey/blob/master/scripts/admin/expression.js#L8

Something like:
$(document).ready(){
$(''.em-expression a').off('click');
});

c_schmitz

c_schmitz

2016-06-20 15:31

administrator   ~39736

Version 2.50 Build 160620 released

pmonstad

pmonstad

2016-06-20 17:14

updater   ~39748

The link still opens a new tab. Why is this a preferred behavior, Carsten?

c_schmitz

c_schmitz

2016-08-12 14:53

administrator   ~40274

Because usually it is because you want to look up what's behind it, not necessarily to change to that question completely.

Related Changesets

LimeSurvey: master 155bb0cb

2016-06-17 07:14:35

c_schmitz

Details Diff
Fixed issue 11391: Clicking a question code in EM expression opens survey home page instead of particular question Affected Issues
11391
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/expressions/em_core_helper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/views/admin/survey/QuestionGroups/questiongroupbar_view.php Diff File

Issue History

Date Modified Username Field Change
2016-06-15 22:14 pmonstad New Issue
2016-06-15 22:14 pmonstad File Added: Skjermbilde 2016-06-15 kl. 22.10.01.png
2016-06-15 23:14 c_schmitz Priority none => low
2016-06-16 09:29 DenisChenu Note Added: 39615
2016-06-17 09:15 c_schmitz Note Added: 39655
2016-06-17 09:15 c_schmitz Status new => resolved
2016-06-17 09:15 c_schmitz Fixed in Version => 2.5
2016-06-17 09:15 c_schmitz Resolution open => fixed
2016-06-17 09:15 c_schmitz Assigned To => c_schmitz
2016-06-17 09:15 c_schmitz Changeset attached => LimeSurvey master 155bb0cb
2016-06-17 09:15 c_schmitz Note Added: 39656
2016-06-17 09:30 DenisChenu Note Added: 39661
2016-06-20 15:31 c_schmitz Note Added: 39736
2016-06-20 15:31 c_schmitz Status resolved => closed
2016-06-20 17:14 pmonstad Note Added: 39748
2016-06-20 17:14 pmonstad Status closed => feedback
2016-06-20 17:14 pmonstad Resolution fixed => reopened
2016-08-12 14:53 c_schmitz Note Added: 40274
2016-08-12 14:53 c_schmitz Status feedback => closed
2016-08-12 14:53 c_schmitz Resolution reopened => fixed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing