View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
11359Bug reportsSurvey participants (Tokens)public2016-06-09 11:242018-02-22 14:18
Reporterszigeti Assigned ToLouisGac 
PriorityimmediateSeveritypartial_block 
Status closedResolutionfixed 
Summary11359: doesn't search for additional attributes
Description

After updating a limesurvey Version 2.50+ from Build 160529 to Build 160606 the filter option has changed. Filter (magnifying glass) doesn't show below the page, which has worked perfectly before and a filter on top of page does not works for any additional token attribute.

BTW this filtering works only in Google Chrome. I have tried it with Firefox and it does not update the list of participants.

Steps To Reproduce

1.Initialize a token table.

  1. add extra attribute, something like "foo"
  2. add tokens into table
  3. Survey Participants -> Display Participants and try to filter for a "foo" attribute
TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)160606
I will donate to the project if issue is resolvedNo
BrowserFirefox/46.0.1
Database type & versionmysql 5.5.49
Server OS (if known)Debian 7
Webserver software & version (if known)Apache 2.2.22
PHP Version5.4.45

Users monitoring this issue

jelo

Activities

szigeti

szigeti

2016-06-10 14:04

reporter   ~39403

Here is a patch which can be solve this issue:

--- TokenDynamic.php 2016-06-10 14:01:20.585493283 +0200
+++ ../www/application/models/TokenDynamic.php 2016-06-10 14:00:31.585003295 +0200
@@ -944,6 +944,12 @@ class TokenDynamic extends LSActiveRecor
$criteria->compare('validfrom',$this->validfrom,true);
$criteria->compare('validuntil',$this->validuntil,true);

  • // Make filterable custom attributes
  • foreach($this->custom_attributes as $sColName => $oColumn)
  • {
  • $criteria->compare($sColName,$this->$sColName,true);
  • }

  • $dataProvider=new CActiveDataProvider('TokenDynamic', array(
    'sort'=>$sort,
    'criteria'=>$criteria,
LouisGac

LouisGac

2016-06-13 10:24

developer   ~39443

nice patch ;-)
LouisGac

LouisGac

2016-06-13 10:41

developer   ~39445

First impressions :

  • Filters work fine in Firefox
  • Attributes filters don't work
LouisGac

LouisGac

2016-06-13 10:45

developer   ~39446

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19418
LouisGac

LouisGac

2016-06-13 10:46

developer   ~39447

You did the patch the exact same way I would have done it myself (using the method getCustom_attributes, etc).

Feel free to do some pull request to the Git repository
;-)
c_schmitz

c_schmitz

2016-06-13 12:26

administrator   ~39472

Version 2.50 Build 160613 released

Related Changesets

LimeSurvey: master c488e96b

2016-06-13 10:44

LouisGac


Details Diff		 Fixed issue 11359: Token display doesn't search for additional attributes Affected Issues
11359
mod - application/models/TokenDynamic.php Diff File

Issue History

Date Modified Username Field Change
2016-06-09 11:24 szigeti New Issue
2016-06-09 12:59 c_schmitz Priority none => immediate
2016-06-09 16:11 ollehar Assigned To => ollehar
2016-06-09 16:11 ollehar Status new => assigned
2016-06-09 16:11 ollehar Assigned To ollehar =>
2016-06-09 16:11 ollehar Assigned To => ollehar
2016-06-09 16:11 ollehar Status assigned => new
2016-06-09 16:15 ollehar Assigned To ollehar =>
2016-06-10 00:43 jelo Issue Monitored: jelo
2016-06-10 14:04 szigeti Note Added: 39403
2016-06-13 10:24 LouisGac Note Added: 39443
2016-06-13 10:36 LouisGac Sticky Issue No => Yes
2016-06-13 10:36 LouisGac Assigned To => LouisGac
2016-06-13 10:36 LouisGac Status new => assigned
2016-06-13 10:41 LouisGac Note Added: 39445
2016-06-13 10:45 LouisGac Changeset attached => LimeSurvey master c488e96b
2016-06-13 10:45 LouisGac Note Added: 39446
2016-06-13 10:45 LouisGac Resolution open => fixed
2016-06-13 10:46 LouisGac Note Added: 39447
2016-06-13 10:46 LouisGac Status assigned => resolved
2016-06-13 12:26 c_schmitz Note Added: 39472
2016-06-13 12:26 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)
2018-02-22 14:18 c_schmitz Sticky Issue Yes => No
2021-08-05 03:45 guest Bug heat 6 => 8