View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11319 | Bug reports | Theme editor | public | 2016-06-02 11:50 | 2016-06-13 12:26 |
Reporter | sth | Assigned To | c_schmitz | ||
Priority | high | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.50.x | ||||
Fixed in Version | 2.50.x | ||||
Summary | 11319: Theme editor URL / Risk of overwriting existing template details | ||||
Description | I've discovered some problems with the theme editor. 1.) When switching between themes via the the dropdown list, sometimes the theme doesn't change to the selected theme, even though it is selected in the dropdown list (it's not reloading) But the more importantly 2.) I am missing a direct URL to a specific theme, like for example "/index.php/admin/templates/sa/view/editfile/pstpl_0/screenname/welcome/templatename/default" - there was one time where i could copy that link, but couldn't find it ever since; when using the theme editor and selecting a theme, the URL stays as | ||||
Tags | No tags attached. | ||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | 160529 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome (Mac) | ||||
Database type & version | MySQL 5.5 | ||||
Server OS (if known) | Ubuntu | ||||
Webserver software & version (if known) | Apache 2 | ||||
PHP Version | 5.5.9 | ||||
I agree that for template development it would be very helpful to have the full template + file URL available. At previous versions this URL could simply be copied from the browser to hand the link to other designers for checking certain files of a certain template. |
|
I was just working with the theme editor, and selected a theme that I wanted to delete, but the previous theme I had selected was deleted instead of the currently selected one... not fun! |
|
Carsten spent a lot of time to move everything from GET to POST. But I agree in a point : Post should be use only to post datas, and get should be use when getting datas, so you can share the URL to get the very same page. |
|
Mazi give a good idea : the line at top "Editing file 'startpage.pstpl'" can be link with GET. |
|
@all, I have raised the priority to "high" because this issue leads to existing custom template details getting overwritten. That is quite painful. |
|
I have experienced this issue when i was switching between different themes to copy code from one theme to another. It looks like the theme changes, but actions sometimes affect a previous selected theme. One time i saved changes in one theme, and they got applied to another theme (it basically overwrote the code of a .pstpl of another theme) - hope this info helps! |
|
RE "Carsten spent a lot of time to move everything from GET to POST." Do you know where I can find the related commit? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19412 |
|
This was no a single commit but a series of commits by Louis and me. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19413 |
|
Version 2.50 Build 160613 released |
|
LimeSurvey: master f166dc27 2016-06-11 21:43 Details Diff |
Fixed issue 11319: Risk of template mismanagement when working in several browser windows |
Affected Issues 11319 |
|
mod - application/config/third_party.php | Diff File | ||
mod - application/controllers/admin/templates.php | Diff File | ||
mod - application/helpers/admin/template_helper.php | Diff File | ||
mod - application/views/admin/templates/templateeditorbar_view.php | Diff File | ||
mod - application/views/admin/templates/templatesummary_view.php | Diff File | ||
LimeSurvey: master 227c0866 2016-06-11 22:15 Details Diff |
Fixed issue 11319: Risk of template mismanagement when working in several browser windows |
Affected Issues 11319 |
|
mod - application/controllers/admin/templates.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-06-02 11:50 | sth | New Issue | |
2016-06-02 12:09 | Mazi | Note Added: 39079 | |
2016-06-02 13:25 | sth | Note Added: 39082 | |
2016-06-03 11:10 |
|
Note Added: 39129 | |
2016-06-03 11:48 | DenisChenu | Note Added: 39138 | |
2016-06-07 17:06 |
|
Priority | none => low |
2016-06-10 15:35 | Mazi | Note Added: 39419 | |
2016-06-10 15:35 | Mazi | Priority | low => high |
2016-06-10 15:36 | Mazi | Summary | Theme editor URL => Theme editor URL / Risk of overwriting existing template details |
2016-06-10 23:54 | duvemyster | Issue Monitored: duvemyster | |
2016-06-11 12:10 | c_schmitz | Assigned To | => c_schmitz |
2016-06-11 12:10 | c_schmitz | Status | new => assigned |
2016-06-11 12:48 | sth | Note Added: 39431 | |
2016-06-11 14:23 | Mazi | Note Added: 39432 | |
2016-06-11 21:43 | c_schmitz | Changeset attached | => LimeSurvey master f166dc27 |
2016-06-11 21:43 | c_schmitz | Note Added: 39433 | |
2016-06-11 21:43 | c_schmitz | Resolution | open => fixed |
2016-06-11 21:46 | c_schmitz | Note Added: 39434 | |
2016-06-11 21:47 | c_schmitz | Status | assigned => resolved |
2016-06-11 21:47 | c_schmitz | Fixed in Version | => 2.5 |
2016-06-11 21:47 | c_schmitz | Note Edited: 39434 | |
2016-06-11 22:15 | c_schmitz | Changeset attached | => LimeSurvey master 227c0866 |
2016-06-11 22:15 | c_schmitz | Note Added: 39436 | |
2016-06-13 12:26 | c_schmitz | Note Added: 39481 | |
2016-06-13 12:26 | c_schmitz | Status | resolved => closed |
2021-08-07 09:24 | guest | Bug heat | 10 => 12 |