View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
11088Bug reportsSurvey editingpublic2016-04-29 16:062016-05-03 11:22
Reportertammo Assigned ToDenisChenu  
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Fixed in Version2.50.x 
Summary11088: Do not show all javascript in question overview
Description

Version 2.50
In the screen that shows all questions in the column "Question" not only the questiontext is shown, but also all javascript that the question text contains. This leads to an overview that contains much info that is not neccessary at this point in the flow.

Additional Information

Possible solution directions:

  • do not show all javascript code that is between the <script> tags, but do show the script tags, because is show that there is javascript in the question text.
  • introduce an extra text editor for Javascript
  • other methods for using Javascript within a question?
  • ...
TagsNo tags attached.
Attached Files
javascripttoomuch.png (144,507 bytes)
Bug heat4
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-04-30 16:12

developer   ~38034

In Question oververview : seems to be striptag and not same than Question reorder.

I move it to bug and fix ity.
DenisChenu

DenisChenu

2016-04-30 16:39

developer   ~38055

@c_schmitz : i already fix it with 'viewHelper::flatEllipsizeText($data->description,true,0)', no ?
c_schmitz

c_schmitz

2016-04-30 16:40

administrator   ~38056

Yep.
DenisChenu

DenisChenu

2016-04-30 16:45

developer   ~38057

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=18837
DenisChenu

DenisChenu

2016-04-30 16:47

developer   ~38058

OK, done .

But : maybe it's better if we show "Expression Error" in it and some other part. I go to work on some extra viewHelper system.

Some idea
viewHelper::flattenText
viewHelper::flattenEm

Make a pull requet for it
c_schmitz

c_schmitz

2016-05-03 11:22

administrator   ~38144

Version 2.50 Build 160503 released

Related Changesets

LimeSurvey: master e80f1afc

2016-04-30 14:43:59

DenisChenu

Details Diff 		Fixed issue 11088: Do not show all javascript in question overview
Dev: same for question group
Dev: must add viewHelper cleanest function : whole flattenText must be review to really flatten text.
Dev: move it to viewHelper ? If OK
Dev: Think keepspan is not used actually		 Affected Issues
11088
mod - application/views/admin/survey/Question/listquestions.php Diff File
mod - application/views/admin/survey/QuestionGroups/listquestiongroups.php Diff File

LimeSurvey: master abb5d472

2016-04-30 14:45:33

DenisChenu

Details Diff 		Merge pull request #484 from Shnoulle/master_11088

Fixed issue 11088: Do not show all javascript in question overview		 Affected Issues
11088
mod - application/views/admin/survey/Question/listquestions.php Diff File
mod - application/views/admin/survey/QuestionGroups/listquestiongroups.php Diff File

Issue History

Date Modified Username Field Change
2016-04-29 16:06 tammo New Issue
2016-04-29 16:06 tammo File Added: javascripttoomuch.png
2016-04-30 16:12 DenisChenu Note Added: 38034
2016-04-30 16:12 DenisChenu Project Feature requests => Bug reports
2016-04-30 16:17 c_schmitz Assigned To => c_schmitz
2016-04-30 16:17 c_schmitz Status new => assigned
2016-04-30 16:39 DenisChenu Note Added: 38055
2016-04-30 16:40 c_schmitz Note Added: 38056
2016-04-30 16:40 c_schmitz Assigned To c_schmitz => DenisChenu
2016-04-30 16:45 DenisChenu Changeset attached => LimeSurvey master e80f1afc
2016-04-30 16:45 DenisChenu Changeset attached => LimeSurvey master abb5d472
2016-04-30 16:45 DenisChenu Note Added: 38057
2016-04-30 16:45 DenisChenu Resolution open => fixed
2016-04-30 16:47 DenisChenu Note Added: 38058
2016-04-30 16:47 DenisChenu Status assigned => resolved
2016-04-30 16:47 DenisChenu Fixed in Version => 2.5
2016-05-03 11:22 c_schmitz Note Added: 38144
2016-05-03 11:22 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing