View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
11035 | Bug reports | Survey editing | public | 2016-04-25 13:39 | 2016-05-02 11:35 |
Reporter | tammo | Assigned To | ollehar | ||
Priority | high | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Fixed in Version | 2.50.x | ||||
Summary | 11035: Group name and group description styling shown despite not chosen to show | ||||
Description | In my survey it says: "Hide both" when we talk about the Group name and group description. Still the HTML is generated: <div id='group-0' class='row'> <!-- Group description -->
</div> Which results in empty styling elements that occupy precious space... | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 18 | ||||
Complete LimeSurvey version number (& build) | 2.5 b160421 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FF | ||||
Database type & version | gg | ||||
Server OS (if known) | gg | ||||
Webserver software & version (if known) | gg | ||||
PHP Version | gg | ||||
It is the same in 2.06 - you will have to modify the CSS if you want less space. |
|
OK, but this is the default template, I think this does not look good. But you decide... |
|
I think an easy fix would be to take away the class jumbotron at least... |
|
...and the blockquote styling.... |
|
All in all, it would be better not to output empty HTML in this case... |
|
hack: hide with js. |
|
Strange for groupdescription : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/SurveyRuntimeHelper.php#L1242 |
|
For grouptitle : alternative : add a grouptitle.pstpl and add it only according to survey settings. |
|
Exclude groupdescriptions.pstpl if it is trim() empty. |
|
It must be actually ...... |
|
OK : got bthe original fix : https://github.com/LimeSurvey/LimeSurvey/commit/7ab13bd0f498a9177066e6af793080a5c6ce1b1c |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18797 |
|
Version 2.50+ Build 160430 released |
|
LimeSurvey: master a3ca4960 2016-04-28 16:13 Details Diff |
Fixed issue 11035: Group name and group description styling shown despite not chosen to show Dev: Remove <blockquote> because it renders even if content is empty. Dev: Check group description settings before rending group description. |
Affected Issues 11035 |
|
mod - application/helpers/SurveyRuntimeHelper.php | Diff File | ||
mod - templates/default/views/startgroup.pstpl | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-04-25 13:39 | tammo | New Issue | |
2016-04-25 13:39 | tammo | File Added: groupheadingdesc.png | |
2016-04-25 14:27 | c_schmitz | Note Added: 37805 | |
2016-04-25 14:27 | c_schmitz | Status | new => closed |
2016-04-25 14:27 | c_schmitz | Assigned To | => c_schmitz |
2016-04-25 14:27 | c_schmitz | Resolution | open => won't fix |
2016-04-25 14:31 | tammo | Note Added: 37806 | |
2016-04-25 14:31 | tammo | Status | closed => feedback |
2016-04-25 14:31 | tammo | Resolution | won't fix => reopened |
2016-04-25 14:54 | tammo | Note Added: 37813 | |
2016-04-25 14:54 | tammo | Status | feedback => assigned |
2016-04-25 14:56 | tammo | Note Added: 37814 | |
2016-04-27 22:58 | tammo | Note Added: 37918 | |
2016-04-28 15:24 | ollehar | Note Added: 37962 | |
2016-04-28 15:42 | DenisChenu | Note Added: 37963 | |
2016-04-28 15:43 | DenisChenu | Note Added: 37964 | |
2016-04-28 15:43 | c_schmitz | Note Added: 37965 | |
2016-04-28 15:43 | c_schmitz | Priority | none => high |
2016-04-28 15:44 | DenisChenu | Note Added: 37966 | |
2016-04-28 15:48 | DenisChenu | Note Added: 37969 | |
2016-04-28 16:15 | ollehar | Changeset attached | => LimeSurvey master a3ca4960 |
2016-04-28 16:15 | ollehar | Note Added: 37973 | |
2016-04-28 16:15 | ollehar | Assigned To | c_schmitz => ollehar |
2016-04-28 16:15 | ollehar | Status | assigned => resolved |
2016-04-28 16:15 | ollehar | Fixed in Version | => 2.5 |
2016-04-28 16:15 | ollehar | Resolution | reopened => fixed |
2016-04-30 16:13 | c_schmitz | Note Added: 38044 | |
2016-04-30 16:13 | c_schmitz | Status | resolved => closed |
2016-05-02 11:35 | DenisChenu | Relationship added | has duplicate 11093 |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |
2021-08-02 17:23 | guest | Bug heat | 16 => 18 |