View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
11016Bug reportsSurvey editingpublic2016-04-22 13:122016-06-17 10:40
Reportertammo Assigned ToLouisGac 
PriorityurgentSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Summary11016: 10 point array does not fit on tablet screen
Description

See picture. There should be room enough.

Steps To Reproduce

Make 10 point array. Resize screen. Default template.

TagsNo tags attached.
Attached Files
10pointarray.png (22,832 bytes)   
10pointarray.png (22,832 bytes)   
limesurvey_survey_459676.lss (355,847 bytes)
nearlythere.png (27,989 bytes)   
nearlythere.png (27,989 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)2.50 B160421
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionMySQL
Server OS (if known)Linux
Webserver software & version (if known)Apache
PHP Version5.5

Relationships

Relationship GraphDependency Graph
parent of 11400 closedLouisGac Loosing Array text when changing width of browser-window 

Users monitoring this issue

There are no users monitoring this issue.

Activities

tammo

tammo

2016-04-22 13:14

developer   ~37694

Uploaded .lss file with many test questions. This one is on the first page.
c_schmitz

c_schmitz

2016-04-22 13:45

administrator   ~37697

Cause by some fake padding in the CSS
ollehar

ollehar

2016-04-25 12:12

administrator   ~37762

In which screen-size did you get the error?
tammo

tammo

2016-04-25 12:35

developer   ~37765

1200 wide
ollehar

ollehar

2016-04-25 12:37

administrator   ~37766

This is caused by Louis' CSS (written after media specific CSS), so I'll assign it to him.
LouisGac

LouisGac

2016-04-25 16:34

developer   ~37825

I forget the # : https://github.com/LimeSurvey/LimeSurvey/commit/be33b4bd22ddea6a37b402a76eee9b55568a0efa
c_schmitz

c_schmitz

2016-04-26 17:54

administrator   ~37879

Version 2.50+ Build 160426 released
tammo

tammo

2016-04-27 10:50

developer   ~37887

Nearly there: still issue at screen size 800 px wide...
ollehar

ollehar

2016-04-27 10:53

administrator   ~37889

Louis, please use relative units instead of pixels (em or whatever).
LouisGac

LouisGac

2016-04-27 14:04

developer   ~37897

relative unit are good for height problems.
have a look in bootstrap css, width are defined in px
LouisGac

LouisGac

2016-04-27 14:05

developer   ~37898

tammo: we should probably force no-more-table behavior with a different logic...
when a table doesn't fit anymore in its container ==> no more table.
LouisGac

LouisGac

2016-04-27 14:09

developer   ~37899

and by the way: em is relative to the font size as defined in the browser.
So it would just not change nothing for the problem here. We could make a try with %, but it would then probably make more problems.

I'll make a piece of js to apply no more table transformation when needed, and not in the base of the screen specifications.
ollehar

ollehar

2016-04-27 14:22

administrator   ~37900

Or make proper center-align?
LouisGac

LouisGac

2016-04-27 15:51

developer   ~37902

I don't think that a center align change will fix the problem on 800px screens.
ollehar

ollehar

2016-04-27 15:53

administrator   ~37903

Sure it would. Just replace it with the padding.
LouisGac

LouisGac

2016-04-27 16:16

developer   ~37904

sure it wouldn't.
give it a test.

also: the space between two items should be superior to the width of a finger.
ollehar

ollehar

2016-04-27 16:16

administrator   ~37905

I can test home later.
IT'S ON! Winner gets a beer.
LouisGac

LouisGac

2016-04-27 16:17

developer   ~37906

Last edited: 2016-04-27 16:20

also: the space between two items should be superior to the width of a finger.
Think about it while drinking beer ;-)

[Because of touch-screen usability.]
LouisGac

LouisGac

2016-04-28 11:28

developer   ~37950

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18790
LouisGac

LouisGac

2016-04-28 11:28

developer   ~37951

no more table is now applied to 800px screens.
c_schmitz

c_schmitz

2016-04-30 16:13

administrator   ~38050

Version 2.50+ Build 160430 released
LouisGac

LouisGac

2016-06-17 10:37

developer   ~39665

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19483
LouisGac

LouisGac

2016-06-17 10:38

developer   ~39666

Last edited: 2016-06-17 10:38

No more table transformation applies when screen is under 801px (for a few exotic tablet screens, see 11016),whereas visible-xs-block respect bootstrap standards (767px) If too many bugs of this kind appears in the future, we should just refuse to support weird exotic tablet screens. We should repsect standards, we should not try to fit to non standards devices.

see: https://bugs.limesurvey.org/view.php?id=11016

Related Changesets

LimeSurvey: master 14ffa8b7

2016-04-28 09:27:27

LouisGac

Details Diff 		Fixed issue 11016: 10 point array does not fit on tablet screen Affected Issues
11016
mod - templates/default/css/template.css Diff File
mod - templates/news_paper/css/template.css Diff File
mod - templates/ubuntu_orange/css/template.css Diff File

LimeSurvey: master 1e5387a8

2016-06-17 08:37:18

LouisGac

Details Diff 		Fixed issue 11400: Loosing Array text when changing width of browser-window
Fixed issue 11016: 10 point array does not fit on tablet screen
Dev: No more table transformation applies when screen is under 801px (for a few exotic tablet screens, see 11016), whereas visible-xs-block respect bootstrap standards (767px),If too many bugs of this kind appears in the future, we should just refuse to support weird exotic tablet screens.We should repsect standards, we should not try to fit to non standards devices.		 Affected Issues
11016, 11400
mod - templates/default/css/template.css Diff File
mod - templates/news_paper/css/template.css Diff File
mod - templates/ubuntu_orange/css/template.css Diff File

Issue History

Date Modified Username Field Change
2016-04-22 13:12 tammo New Issue
2016-04-22 13:12 tammo File Added: 10pointarray.png
2016-04-22 13:14 tammo File Added: limesurvey_survey_459676.lss
2016-04-22 13:14 tammo Note Added: 37694
2016-04-22 13:45 c_schmitz Note Added: 37697
2016-04-22 13:45 c_schmitz Priority none => urgent
2016-04-22 13:45 c_schmitz Assigned To => ollehar
2016-04-22 13:45 c_schmitz Status new => assigned
2016-04-25 12:12 ollehar Note Added: 37762
2016-04-25 12:35 tammo Note Added: 37765
2016-04-25 12:37 ollehar Assigned To ollehar => LouisGac
2016-04-25 12:37 ollehar Note Added: 37766
2016-04-25 15:48 LouisGac Sticky Issue No => Yes
2016-04-25 16:34 LouisGac Note Added: 37825
2016-04-25 16:34 LouisGac Status assigned => resolved
2016-04-25 16:34 LouisGac Resolution open => fixed
2016-04-25 18:38 LouisGac Sticky Issue Yes => No
2016-04-26 17:54 c_schmitz Note Added: 37879
2016-04-26 17:54 c_schmitz Status resolved => closed
2016-04-27 10:50 tammo Note Added: 37887
2016-04-27 10:50 tammo Status closed => feedback
2016-04-27 10:50 tammo Resolution fixed => reopened
2016-04-27 10:51 tammo File Added: nearlythere.png
2016-04-27 10:53 ollehar Note Added: 37889
2016-04-27 14:04 LouisGac Note Added: 37897
2016-04-27 14:05 LouisGac Note Added: 37898
2016-04-27 14:09 LouisGac Note Added: 37899
2016-04-27 14:22 ollehar Note Added: 37900
2016-04-27 15:51 LouisGac Note Added: 37902
2016-04-27 15:53 ollehar Note Added: 37903
2016-04-27 16:16 LouisGac Note Added: 37904
2016-04-27 16:16 ollehar Note Added: 37905
2016-04-27 16:17 LouisGac Note Added: 37906
2016-04-27 16:20 ollehar Note Edited: 37906
2016-04-28 11:28 LouisGac Changeset attached => LimeSurvey master 14ffa8b7
2016-04-28 11:28 LouisGac Note Added: 37950
2016-04-28 11:28 LouisGac Note Added: 37951
2016-04-28 11:28 LouisGac Status feedback => resolved
2016-04-28 11:28 LouisGac Resolution reopened => fixed
2016-04-30 16:13 c_schmitz Note Added: 38050
2016-04-30 16:13 c_schmitz Status resolved => closed
2016-06-17 10:37 LouisGac Changeset attached => LimeSurvey master 1e5387a8
2016-06-17 10:37 LouisGac Note Added: 39665
2016-06-17 10:38 LouisGac Note Added: 39666
2016-06-17 10:38 LouisGac Status closed => feedback
2016-06-17 10:38 LouisGac Resolution fixed => reopened
2016-06-17 10:38 LouisGac Note Edited: 39666
2016-06-17 10:38 LouisGac Status feedback => closed
2016-06-17 10:38 LouisGac Resolution reopened => fixed
2016-06-17 10:40 LouisGac Relationship added parent of 11400
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing