View Issue Details

This bug affects 1 person(s).
 28
IDProjectCategoryView StatusLast Update
11001Bug reportsTheme editorpublic2016-05-06 10:11
Reporterakeyser Assigned Toc_schmitz  
PrioritynoneSeveritycrash 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11001: Regression: Selecting a theme from the drop-down no longer functions properly
Description

Selecting a theme from the drop-down no longer functions; instead causes "Invalid Screen Name" error, shows the Theme Upload page.

Steps To Reproduce

Browse to theme editor
Select a different theme from the theme drop-down
Observe results

Additional Information

Perhaps caused by the fix to 10985 or 10982

TagsNo tags attached.
Bug heat28
Complete LimeSurvey version number (& build)160421
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome 49
Database type & versionMySQL 5.6.27-log
Server OS (if known)Windows Server 2008 R2
Webserver software & version (if known)IIS 7.5
PHP Version5.6.14

Relationships

has duplicate 10971 closedc_schmitz CSS pages not available - not visible 
has duplicate 11121 closedc_schmitz Template Editor: Invalid screen name 
has duplicate 11044 closedc_schmitz Invalid screen name 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-04-22 12:39

administrator   ~37692

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18688

c_schmitz

c_schmitz

2016-04-25 13:54

administrator   ~37772

Version 2.50+ Build 160425 released

akeyser

akeyser

2016-04-26 18:19

reporter   ~37882

This is still broken with the same behaviour on 160426

akeyser

akeyser

2016-04-26 18:31

reporter   ~37883

Last edited: 2016-04-26 18:39

I found the issue;

line 191, templateeditorbar_view.php:

<select class="listboxtemplates form-control" id='listboxtemplates' name='screenname' onchange="javascript: window.open('<?php echo $this->createUrl("admin/templates/sa/view/editfile/".$editfile);?>/screenname/'+encodeURI(this.value)+'?templatename=<?php echo urlencode ($templatename); ?>', '_top')">

createURL returns a URL that already contains one '?' on servers without mod_rewrite (like my IIS server), so the ?templatename= should, in that case, be &templatename=.
This is on the screen switcher, but the same applies to the actual template switcher, which is on line 184.

If I modify the HTML with Chrome's Inspector to change ?templatename= to &templatename=, it works flawlessly.

It also works with /templatename/ in place of ?templatename=, which might be the cleaner option, with less edge cases that depend on webserver type and features

wimpie3

wimpie3

2016-05-02 15:42

reporter   ~38115

I can confirm that this is the behaviour I see as well. The URL is malformed. On IIS, this URL is opened:

http://xxxxx/forms/index.php?r=admin/templates/sa/view/editfile/startpage.pstpl/screenname/welcome?templatename=my-template

Which contains indeed twice a question mark...

dtosun

dtosun

2016-05-04 09:37

reporter   ~38174

The problem is exist in latest version. I m comfirmed.

c_schmitz

c_schmitz

2016-05-04 15:47

administrator   ~38202

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=18889

c_schmitz

c_schmitz

2016-05-06 09:27

administrator   ~38225

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=18905

c_schmitz

c_schmitz

2016-05-06 10:11

administrator   ~38227

Version 2.50+ Build 160506 released

Related Changesets

LimeSurvey: master 32aa2e8d

2016-04-22 10:39:19

c_schmitz

Details Diff
Fixed issue 11001: Selecting a screen in the template editor fails Affected Issues
11001
mod - application/controllers/admin/templates.php Diff File
mod - application/views/admin/templates/templateeditorbar_view.php Diff File

LimeSurvey: master ffdaa7c2

2016-05-04 11:47:27

c_schmitz

Details Diff
Fixed issue 11001: Selecting a theme in the theme editor does not function properly Affected Issues
11001
mod - application/controllers/admin/templates.php Diff File
mod - application/helpers/admin/template_helper.php Diff File
mod - application/views/admin/templates/templateeditorbar_view.php Diff File
mod - application/views/admin/templates/templatesummary_view.php Diff File

LimeSurvey: master e953ef11

2016-05-04 14:45:31

c_schmitz

Details Diff
Fixed issue 11001: Selecting a theme in the theme editor does not function properly
Dev Removed some obsolete code
Affected Issues
11001
mod - application/controllers/admin/templates.php Diff File
mod - application/views/admin/templates/templateeditorbar_view.php Diff File

Issue History

Date Modified Username Field Change
2016-04-21 18:35 akeyser New Issue
2016-04-22 12:39 c_schmitz Assigned To => c_schmitz
2016-04-22 12:39 c_schmitz Status new => assigned
2016-04-22 12:39 c_schmitz Status assigned => resolved
2016-04-22 12:39 c_schmitz Fixed in Version => 2.5
2016-04-22 12:39 c_schmitz Resolution open => fixed
2016-04-22 12:39 c_schmitz Changeset attached => LimeSurvey master 32aa2e8d
2016-04-22 12:39 c_schmitz Note Added: 37692
2016-04-25 10:13 c_schmitz Relationship added parent of 10971
2016-04-25 10:13 c_schmitz Relationship replaced has duplicate 10971
2016-04-25 13:54 c_schmitz Note Added: 37772
2016-04-25 13:54 c_schmitz Status resolved => closed
2016-04-26 18:19 akeyser Note Added: 37882
2016-04-26 18:19 akeyser Status closed => feedback
2016-04-26 18:19 akeyser Resolution fixed => reopened
2016-04-26 18:31 akeyser Note Added: 37883
2016-04-26 18:31 akeyser Status feedback => assigned
2016-04-26 18:39 akeyser Note Edited: 37883
2016-05-02 15:42 wimpie3 Note Added: 38115
2016-05-04 09:37 dtosun Note Added: 38174
2016-05-04 15:44 c_schmitz Relationship added has duplicate 11121
2016-05-04 15:46 c_schmitz Relationship added has duplicate 11044
2016-05-04 15:47 c_schmitz Status assigned => resolved
2016-05-04 15:47 c_schmitz Resolution reopened => fixed
2016-05-04 15:47 c_schmitz Changeset attached => LimeSurvey master ffdaa7c2
2016-05-04 15:47 c_schmitz Note Added: 38202
2016-05-06 09:27 c_schmitz Changeset attached => LimeSurvey master e953ef11
2016-05-06 09:27 c_schmitz Note Added: 38225
2016-05-06 10:11 c_schmitz Note Added: 38227
2016-05-06 10:11 c_schmitz Status resolved => closed
2021-08-02 19:33 guest Bug heat 26 => 28