View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
10883Bug reportsOtherpublic2016-04-07 23:55
Reportermaxoumat Assigned Toollehar  
PriorityhighSeveritycrash 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10883: Error 500 survey permission
Description

when you want to change the permissions of a survey, we have an 500 page error : /admin/surveypermission/sa/view/surveyid/33364

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)160405
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql 5.5
Server OS (if known)debian
Webserver software & version (if known)Apache 2
PHP Version5.5

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2016-04-07 12:57

administrator   ~37056

Could you attach the relevant survey, please?

ollehar

ollehar

2016-04-07 12:57

administrator   ~37057

Or enable debug=2 in config.php, reload and send us the error message on screen.

asch

asch

2016-04-07 13:23

reporter   ~37059

Fatal error: Can't use method return value in write context in /var/www/application/controllers/admin/surveypermission.php on line 596

ollehar

ollehar

2016-04-07 13:37

administrator   ~37060

That line is in the delete function. So the error appears when you delete rights?

ollehar

ollehar

2016-04-07 13:40

administrator   ~37061

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18374

asch

asch

2016-04-07 14:01

reporter   ~37062

sorry, one question: in string check for Gid param, but set Uid param is it right?
$postusergroupid = (!empty(App()->getRequest()->getParam('gid'))) ? App()->getRequest()->getParam('uid') : false;

ollehar

ollehar

2016-04-07 14:01

administrator   ~37063

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18375

ollehar

ollehar

2016-04-07 14:08

administrator   ~37064

Could you pull and check again?

ollehar

ollehar

2016-04-07 14:09

administrator   ~37065

$postusergroupid is fixed in last commit.

maxoumat

maxoumat

2016-04-07 14:17

reporter   ~37066

error is the same...

$postuserid = !(App()->getRequest()->getParam('uid')) ? App()->getRequest()->getParam('uid') : false;

it's ok now

ollehar

ollehar

2016-04-07 14:26

administrator   ~37071

Is it OK or the same error?

maxoumat

maxoumat

2016-04-07 14:30

reporter   ~37074

better i think :

$postuserid = (App()->getRequest()->getParam('uid')) ? App()->getRequest()->getParam('uid') : false;
if (! empty($postuserid));

maxoumat

maxoumat

2016-04-07 14:30

reporter   ~37075

no error

add user : ok
delete user : ok

ollehar

ollehar

2016-04-07 14:38

administrator   ~37077

You can check the commit:

  • $uid = App()->getRequest()->getParam('uid');
  • $postuserid = (!empty($uid)) ? $uid : false;

Great, I'll mark it as resolved!

c_schmitz

c_schmitz

2016-04-07 23:55

administrator   ~37106

Version 2.50 Build 160407 released

Related Changesets

LimeSurvey: master 98e736d2

2016-04-07 11:39:00

ollehar

Details Diff
Fixed issue 10883: Error 500 survey permission Affected Issues
10883
mod - application/controllers/admin/surveypermission.php Diff File

LimeSurvey: master f0efa6a6

2016-04-07 12:01:06

ollehar

Details Diff
Fixed issue 10883: Error 500 survey permission Affected Issues
10883
mod - application/controllers/admin/surveypermission.php Diff File

Issue History

Date Modified Username Field Change
2016-04-07 11:20 maxoumat New Issue
2016-04-07 12:57 ollehar Note Added: 37056
2016-04-07 12:57 ollehar Note Added: 37057
2016-04-07 12:58 ollehar Assigned To => ollehar
2016-04-07 12:58 ollehar Status new => acknowledged
2016-04-07 12:58 ollehar Status acknowledged => feedback
2016-04-07 13:23 asch Note Added: 37059
2016-04-07 13:37 ollehar Note Added: 37060
2016-04-07 13:40 ollehar Changeset attached => LimeSurvey master 98e736d2
2016-04-07 13:40 ollehar Note Added: 37061
2016-04-07 13:40 ollehar Resolution open => fixed
2016-04-07 14:01 asch Note Added: 37062
2016-04-07 14:01 ollehar Changeset attached => LimeSurvey master f0efa6a6
2016-04-07 14:01 ollehar Note Added: 37063
2016-04-07 14:08 ollehar Note Added: 37064
2016-04-07 14:09 ollehar Note Added: 37065
2016-04-07 14:17 maxoumat Note Added: 37066
2016-04-07 14:17 maxoumat Status feedback => assigned
2016-04-07 14:20 c_schmitz Priority none => high
2016-04-07 14:20 c_schmitz Description Updated
2016-04-07 14:26 ollehar Note Added: 37071
2016-04-07 14:30 maxoumat Note Added: 37074
2016-04-07 14:30 maxoumat Note Added: 37075
2016-04-07 14:38 ollehar Note Added: 37077
2016-04-07 14:38 ollehar Status assigned => resolved
2016-04-07 14:38 ollehar Fixed in Version => 2.5
2016-04-07 23:55 c_schmitz Note Added: 37106
2016-04-07 23:55 c_schmitz Status resolved => closed