View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
10840 | Bug reports | Survey taking | public | 2016-03-30 09:37 | 2016-04-18 22:48 |
Reporter | DenisChenu | Assigned To | ollehar | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.50.x | ||||
Fixed in Version | 2.50.x | ||||
Summary | 10840: DB issue in susrvey : system is broken | ||||
Description | When there are a DB issue in survey : all system is broken. | ||||
Steps To Reproduce | Get the file in https://bugs.limesurvey.org/view.php?id=10827 Set debug to 0
Set debug to ,2:
In the mail : show no infoirmation on the error. | ||||
Additional Information | https://bugs.limesurvey.org/view.php?id=10827 must be fixed but even after there can have DB issue. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 160330 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | PostgreSQL 9.1.20 (but other DB can have issue too) | ||||
Server OS (if known) | debian7/linux | ||||
Webserver software & version (if known) | apache | ||||
PHP Version | PHP Version 5.4 | ||||
related to | 10827 | closed | DenisChenu | Whole answers must be filtered before try to save in DB |
Thank you olle:) |
|
How is this a bug? When you're putting "MoreThan5" as value, you're breaking the interface of the question? |
|
You need pg because with mysql : no issue. With "MoreThan5" : you broke "Response save" here : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/expressions/em_manager_helper.php#L5424 Then submitfailed function from front_end helper is called. This function :
But you need an adminemail .... The "MoreThan5" broke pgsql : it's another issue. |
|
Is the solution a proper error message? Because I don't want pgsql to fail silently, as mysql. |
|
I work actually in 10827 . I want to show message for some "Error" too . But don't break Survey (don't reset session). I want to do 2 thing:
Actually i search a way to add message in _validateUestion ... to add it in EM system dynamicly . But :
If you're OK : i just condtruct an error message Example here; https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/expressions/em_manager_helper.php#L5401 Adding regexp for DECIMAL(30,10), don't reset the $_SESSION var The we mist shown the "Question page" with error somewhere. Just like it was "mandatory" or somethiug like here. I send some of code tomorrow :
OK ? |
|
Oups ... another poiunt: |
|
@olle : see comment here : https://github.com/LimeSurvey/LimeSurvey/commit/f438b28914917dec7944291a7bad67719ceec419#diff-796aba4d06254b9caea9d461e4ea80c9R5404 For information : i try to update $this->qid2validationEqn[$qid]['eqn'] and msg here : but _validateUestion is already done .... Then i add it before // DETECT ANY VIOLATIONS OF VALIDATION RULES // manually but really .... it's not the best way .... EM is awfull .. |
|
Yeah, we need a system to show messages that's not "echo". |
|
I'd say Yii flash message. |
|
flash message : only JS ? Else we have a place for error here : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/SurveyRuntimeHelper.php#L1207 You adde an infor on stepInfo ? |
|
http://www.yiiframework.com/wiki/21/how-to-work-with-flash-messages/ Think it generates HTML, and then do some Bootstrap enhancement. Not sure. I want to avoid adding things in run(). Also echo is hard to get good control-flow with. What's stepinfo? |
|
Yes, i know flashMessage :). Sorry bad reading didn't see the Yii before. Very good idea : and popups can be moved to view system for flashMessage. Actually : we don't have flashMessage for public. I like to extedn flashMessage to have different "style". |
|
Version 2.06LTS Build 160417 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-03-30 09:37 | DenisChenu | New Issue | |
2016-03-30 13:44 | ollehar | Assigned To | => ollehar |
2016-03-30 13:44 | ollehar | Status | new => assigned |
2016-03-30 14:10 | DenisChenu | Note Added: 36836 | |
2016-03-30 14:23 | ollehar | Note Added: 36837 | |
2016-03-30 14:27 | DenisChenu | Note Added: 36838 | |
2016-03-30 14:28 | DenisChenu | Relationship added | related to 10827 |
2016-03-30 14:48 | ollehar | Note Added: 36839 | |
2016-03-30 15:01 | DenisChenu | Note Added: 36841 | |
2016-03-30 15:06 | DenisChenu | Note Added: 36842 | |
2016-03-30 15:21 | DenisChenu | Note Added: 36844 | |
2016-03-30 16:39 | ollehar | Note Added: 36845 | |
2016-03-30 16:39 | ollehar | Note Added: 36846 | |
2016-03-30 17:32 | DenisChenu | Note Added: 36847 | |
2016-03-30 18:00 | ollehar | Note Added: 36849 | |
2016-03-30 19:36 | DenisChenu | Note Added: 36850 | |
2016-04-18 12:37 | ollehar | Status | assigned => resolved |
2016-04-18 12:37 | ollehar | Fixed in Version | => 2.5 |
2016-04-18 12:37 | ollehar | Resolution | open => fixed |
2016-04-18 22:48 | c_schmitz | Note Added: 37512 | |
2016-04-18 22:48 | c_schmitz | Status | resolved => closed |