View Issue Details

This bug affects 1 person(s).
 12
IDProjectCategoryView StatusLast Update
10730Bug reportsResponse browsingpublic2016-04-01 11:36
Reportersteve_81 Assigned ToLouisGac 
PriorityurgentSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10730: default templates errors with (dual) matrix on small screens
Description

Hi guys, if I scale down the screen / reduce width of the browser the matrix questions wraps not correctly. Answer options are no longer displayed.

Steps To Reproduce

Create a matix question
test survey
scale down / reduce width of the browser
see the wrapping matrix question -> the answer options are no longer displayed

TagsNo tags attached.
Attached Files
Wrap_Error_Scale.png (35,786 bytes)   
Wrap_Error_Scale.png (35,786 bytes)   
capture1.png (12,104 bytes)   
capture1.png (12,104 bytes)   
capture2.png (13,959 bytes)   
capture2.png (13,959 bytes)   
array_dual_scale_1.png (72,436 bytes)   
array_dual_scale_1.png (72,436 bytes)   
Bug heat12
Complete LimeSurvey version number (& build)20160309
I will donate to the project if issue is resolvedNo
Browserat least Firefox and InternetExplorer
Database type & versionNA
Server OS (if known)NA
Webserver software & version (if known)NA
PHP VersionNA

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-03-10 11:50

developer   ~36268

Please provide screenshot

steve_81

steve_81

2016-03-10 12:35

reporter   ~36276

Upload Screenshot

tpartner

tpartner

2016-03-10 14:45

partner   ~36288

Last edited: 2016-03-10 14:50

Something missing in the onresize event - if you reload the reduced screen the labels appear, however when increasing the screen width after reload the labels are persistent (screenshot capture1.png).

Additionally, between ~760 and ~800 px screen width, it's totally messed up (screenshot capture2.png).

LouisGac

LouisGac

2016-03-10 14:50

developer   ~36289

there is no onresize event. That's a choice. I could easily add one, but what for? It's not a normal behavior, and it would make heavier the JS for nothing.
If really you want it for debugging purposes, I could add one when debug mode is on.

tpartner

tpartner

2016-03-10 14:51

partner   ~36291

...but if someone resizes their screen below 800px the survey is broken

tpartner

tpartner

2016-03-10 14:54

partner   ~36293

CSS solution - add a <span> element to the label with the text. Hide that span above 800px, show it below.

LouisGac

LouisGac

2016-03-10 14:57

developer   ~36294

resizing the screen while passing a survey is just not a normal behavior. Coders and designers do it for testing purposes, but not final users.

again: it's only 3 lines of js to add. so if you really, really, really want it, I could do it. But keep in mind that in general, "responsive" doesn't mean that the website is "resizable on the fly", but rather that it can display correctly in different screen sizes. So, reloading the page after the resize is a necessary step in general.

DenisChenu

DenisChenu

2016-03-10 15:01

developer   ~36295

Last edited: 2016-03-10 15:02

CSS soliution : no need span,

Just label :

  • out of screen with screen > 800px (position absolute (or relative)) (or some other way)
  • in screen, display inline with screen < 800px

I use a lot of combination with
td input label

WIth this : we can do all with some css.

LouisGac

LouisGac

2016-03-10 15:03

developer   ~36297

yep, like for the case "multiple short text" with checkboxes.
we yet spoke about it, and I agree that we should use it everywhere.

tpartner

tpartner

2016-03-10 15:03

partner   ~36298

I disagree, resizing the screen is a common practice - folks may want to check other applications while completing the survey. In my opinion, responsive is, well, responsive. All decent responsive website designs accommodate screen resizing.

tpartner

tpartner

2016-03-10 15:09

partner   ~36299

@DenisChenu, yes but not without some HTML modifications. The array radio input are inside the label elements so hiding the labels will hide the radios.

LouisGac

LouisGac

2016-03-10 15:11

developer   ~36300

Last edited: 2016-03-10 15:28

tpartner : it's not my personal point of view or theory. We're speaking about it in the IRC with Denis. Many JavaScript component are officially responsive, but doesn't support natively re-sizing on the fly (eg : Chartjs).

Responsiveness is about displaying well in any screen size, not about adapting to windows resize.

By the way, re-sizing is just a quick and dirty way of testing. There are much more advanced tools to do it.

DenisChenu

DenisChenu

2016-03-10 15:13

developer   ~36301

@tpartner : yse, is what i think we must review HTML workflow and have the same than 2.06
https://github.com/LimeSurvey/LimeSurvey/blob/2.06lts/application/helpers/qanda_helper.php#L6081

tpartner

tpartner

2016-03-10 15:45

partner   ~36303

@DenisChenu, yes going back to the 2.06 layout (label followed by input) and using media queries to hide/show the label would work. But if Louis needs the input inside the label, adding my <span> would also work. In either case the text would always be available, leaving how to handle it up to the template designer.

ollehar

ollehar

2016-03-21 11:25

administrator   ~36649

All questions should now be fixed on all screens (phone, iPad, laptop). Please update to latest release and confirm.

steve_81

steve_81

2016-03-23 15:31

reporter   ~36743

In the dirty way of testing it is not solved. If I change the size of the window the labels are still hidden (built 160317). Or didn't I understand it correctly, should it be fixed?
But it is okay: Who changes his screen size on the fly?

ollehar

ollehar

2016-03-23 15:35

administrator   ~36744

Not an iPhone user. ;) Or iPad.

tpartner

tpartner

2016-03-23 15:56

partner   ~36748

@olle, the layout issues are fixed but I don't see the scale headers in the Array Dual Scale on mobile devices. Please see the attached array_dual_scale_1.png

ollehar

ollehar

2016-03-23 16:42

administrator   ~36751

That's correct, will fix.

ollehar

ollehar

2016-03-23 17:39

administrator   ~36754

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=18153

c_schmitz

c_schmitz

2016-04-01 11:36

administrator   ~36887

Version 2.50+ Build 160401 released

Related Changesets

LimeSurvey: master f456edd8

2016-03-23 16:39:12

ollehar

Details Diff
Fixed issue 10730: default templates errors with (dual) matrix on small
screens

Dev: Add headers only visible at xs
Affected Issues
10730
mod - application/helpers/qanda_helper.php Diff File

Issue History

Date Modified Username Field Change
2016-03-10 11:33 steve_81 New Issue
2016-03-10 11:50 DenisChenu Note Added: 36268
2016-03-10 12:35 steve_81 File Added: Wrap_Error_Scale.png
2016-03-10 12:35 steve_81 Note Added: 36276
2016-03-10 14:26 c_schmitz Assigned To => ollehar
2016-03-10 14:26 c_schmitz Status new => assigned
2016-03-10 14:27 c_schmitz Assigned To ollehar => LouisGac
2016-03-10 14:27 c_schmitz Priority none => urgent
2016-03-10 14:41 tpartner File Added: capture1.png
2016-03-10 14:41 tpartner File Added: capture2.png
2016-03-10 14:45 tpartner Note Added: 36288
2016-03-10 14:50 LouisGac Note Added: 36289
2016-03-10 14:50 tpartner Note Edited: 36288
2016-03-10 14:51 tpartner Note Added: 36291
2016-03-10 14:54 tpartner Note Added: 36293
2016-03-10 14:57 LouisGac Note Added: 36294
2016-03-10 15:01 DenisChenu Note Added: 36295
2016-03-10 15:02 DenisChenu Note Edited: 36295
2016-03-10 15:03 LouisGac Note Added: 36297
2016-03-10 15:03 tpartner Note Added: 36298
2016-03-10 15:09 tpartner Note Added: 36299
2016-03-10 15:11 LouisGac Note Added: 36300
2016-03-10 15:13 DenisChenu Note Added: 36301
2016-03-10 15:28 LouisGac Note Edited: 36300
2016-03-10 15:45 tpartner Note Added: 36303
2016-03-21 11:25 ollehar Note Added: 36649
2016-03-21 11:25 ollehar Status assigned => resolved
2016-03-21 11:25 ollehar Fixed in Version => 2.5
2016-03-21 11:25 ollehar Resolution open => fixed
2016-03-23 15:31 steve_81 Note Added: 36743
2016-03-23 15:35 ollehar Note Added: 36744
2016-03-23 15:54 tpartner File Added: array_dual_scale_1.png
2016-03-23 15:56 tpartner Note Added: 36748
2016-03-23 16:42 ollehar Note Added: 36751
2016-03-23 17:39 ollehar Changeset attached => LimeSurvey master f456edd8
2016-03-23 17:39 ollehar Note Added: 36754
2016-04-01 11:36 c_schmitz Note Added: 36887
2016-04-01 11:36 c_schmitz Status resolved => closed