View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
10633Bug reportsSurvey editingpublic2016-03-01 09:432016-03-07 11:45
Reporterautopoiesis Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Target Version2.50.xFixed in Version2.50.x 
Summary10633: Reference to $oTemplate is undefined
Description

In commit b5483988a2cf36e450bbe64619040e37e2f165a6, in file LimeSurvey/application/models/Template.php, on line 375:

return (! self::hasConfigFile($sTemplatePath) && is_file($oTemplate->path.DIRECTORY_SEPARATOR.'startpage.pstpl'));

the reference to $oTemplate is undefined, since it’s not being passed into the function isOldTemplate. It’s easy to fix. Instead of passing $sTemplatePath, $oTemplate should be passed, and $sTemplatePath should be changed to $oTemplate->path.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)b5483988a2cf36e450bbe6461904
I will donate to the project if issue is resolvedNo
BrowserNot relevant
Database type & versionNot relevant
Server OS (if known)Not relevant
Webserver software & version (if known)Not relevant
PHP VersionNot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-03-01 10:41

developer   ~35808

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17693
DenisChenu

DenisChenu

2016-03-01 10:42

developer   ~35809

Thank you :)
It can be more speed if you can do the pull request (but here : have another issue with siteLogo).
c_schmitz

c_schmitz

2016-03-07 11:45

administrator   ~36025

Version 2.60 Build 150307 released

Related Changesets

LimeSurvey: master 0fc15400

2016-03-01 10:41

DenisChenu


Details Diff		 Fixed issue 10633 : unable to use 2.06 template (Thanks to autopoiesis)
Dev: debug 2 show an error and debug 0 always return false for isOldTemplate
Dev: $oTemplate->siteLogo send error if not set debug 2		 Affected Issues
10633
mod - application/helpers/replacements_helper.php Diff File
mod - application/models/Template.php Diff File

Issue History

Date Modified Username Field Change
2016-03-01 09:43 autopoiesis New Issue
2016-03-01 10:29 DenisChenu Assigned To => DenisChenu
2016-03-01 10:29 DenisChenu Status new => assigned
2016-03-01 10:41 DenisChenu Changeset attached => LimeSurvey master 0fc15400
2016-03-01 10:41 DenisChenu Note Added: 35808
2016-03-01 10:41 DenisChenu Resolution open => fixed
2016-03-01 10:42 DenisChenu Note Added: 35809
2016-03-01 10:42 DenisChenu Status assigned => resolved
2016-03-01 10:42 DenisChenu Product Version 2.06+ => 2.5
2016-03-01 10:42 DenisChenu Fixed in Version => 2.5
2016-03-01 10:42 DenisChenu Target Version => 2.5
2016-03-07 11:45 c_schmitz Note Added: 36025
2016-03-07 11:45 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing